Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ProcessStatusResponse #21352

Merged

Conversation

woody-apple
Copy link
Contributor

Problem

Improve ProcessStatusResponse signature so that we can tell if the
error is caused by malformed status response or the error is from stored
value inside status response.
This PR is cut from #19356.

Change overview

See above

Testing

no logic change, the existing test covers.

* Improve ProcessStatusResponse

-- Improve ProcessStatusResponse signature so that we can tell if the
error is caused by malformed status response or the error is from stored
value inside status response.

* address comments

* Fix unexpected non-StatusResponse handling.

Co-authored-by: Boris Zbarsky <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 28, 2022

PR #21352: Size comparison from c803dab to e4ca419

Increases (5 builds for linux, mbed, nrfconnect)
platform target config section c803dab e4ca419 change % change
linux chip-tool-ipv6only arm64 (read only) 9839076 9839908 832 0.0
(read/write) 678609 678753 144 0.0
.data.rel.ro 623936 624080 144 0.0
.text 7788932 7789620 688 0.0
thermostat-no-ble arm64 (read only) 2342668 2342812 144 0.0
(read/write) 141409 141425 16 0.0
.data.rel.ro 75672 75696 24 0.0
.text 1966288 1966400 112 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2450240 2450464 224 0.0
.text 1412884 1413108 224 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177095 1177111 16 0.0
text 812496 812504 8 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157147 1157163 16 0.0
text 801808 801816 8 0.0
Full report (5 builds for linux, mbed, nrfconnect)
platform target config section c803dab e4ca419 change % change
linux chip-tool-ipv6only arm64 (read only) 9839076 9839908 832 0.0
(read/write) 678609 678753 144 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 623936 624080 144 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467796 467796 0 0.0
.text 7788932 7789620 688 0.0
thermostat-no-ble arm64 (read only) 2342668 2342812 144 0.0
(read/write) 141409 141425 16 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75672 75696 24 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139332 139332 0 0.0
.text 1966288 1966400 112 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2450240 2450464 224 0.0
.bss 214516 214516 0 0.0
.data 5872 5872 0 0.0
.text 1412884 1413108 224 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177095 1177111 16 0.0
bss 143140 143140 0 0.0
rodata 142544 142544 0 0.0
text 812496 812504 8 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157147 1157163 16 0.0
bss 142376 142376 0 0.0
rodata 134076 134076 0 0.0
text 801808 801816 8 0.0

@woody-apple woody-apple merged commit c5e69d7 into sve Jul 28, 2022
@woody-apple woody-apple deleted the cherry-pick-73d0fae65827229bd0304efba83b412147dbbbac branch July 28, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants