Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix status response in write client #21511

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Fix status response in write client #21511

merged 1 commit into from
Aug 10, 2022

Conversation

yunhanw-google
Copy link
Contributor

Problem

Fix status response in write client
This PR is cut from #19356

Change overview

Then onMessageReceived in WriteClient would send status response message with invalid action when there is error happening in incoming message.

Testing

WriteClient sends write requests, and Injects malformed write response, status response, unknown message in client side, and client would send status response message with invalid action.

@restyled-io restyled-io bot mentioned this pull request Aug 2, 2022
Closed
@yunhanw-google yunhanw-google force-pushed the feature/fix_write_client_status_response branch from 49ab5ca to 4eaaad8 Compare August 2, 2022 01:13
@github-actions
Copy link

github-actions bot commented Aug 2, 2022 •
edited
Loading

PR #21511: Size comparison from 456bed5 to 4eaaad8

Increases (5 builds for esp32, linux)
platform target config section 456bed5 4eaaad8 change % change
esp32 all-clusters-app c3devkit (read only) 1024446 1024450 4 0.0
.flash.text 1024446 1024450 4 0.0
linux chip-tool debug (read only) 10558601 10558649 48 0.0
.text 8523140 8523188 48 0.0
chip-tool-ipv6only arm64 (read only) 9960844 9960908 64 0.0
.text 7862836 7862900 64 0.0
tv-app debug (read only) 3155833 3155881 48 0.0
.text 2709842 2709890 48 0.0
tv-casting-app debug (read only) 5393105 5393153 48 0.0
.text 4785986 4786034 48 0.0
Decreases (3 builds for bl602, telink)
platform target config section 456bed5 4eaaad8 change % change
bl602 lighting-app bl602 (read/write) 1382658 1382650 -8 -0.0
.text 1052768 1052764 -4 -0.0
telink light-switch-app tlsr9518adk80d text 569418 569416 -2 -0.0
lighting-app tlsr9518adk80d text 586306 586304 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 456bed5 4eaaad8 change % change
bl602 lighting-app bl602 (read/write) 1382658 1382650 -8 -0.0
.bss 117626 117626 0 0.0
.data 4480 4480 0 0.0
.text 1052768 1052764 -4 -0.0
bl602+rpc (read/write) 1428058 1428058 0 0.0
.bss 125066 125066 0 0.0
.data 4600 4600 0 0.0
.text 1084432 1084432 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 669979 669979 0 0.0
(read/write) 181404 181404 0 0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88467 88467 0 0.0
.text 581196 581196 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 635491 635491 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77691 77691 0 0.0
.text 557476 557476 0 0.0
lock-ftd LP_CC2652R7 (read only) 672959 672959 0 0.0
(read/write) 168608 168608 0 0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76535 76535 0 0.0
.text 595944 595944 0 0.0
lock-mtd LP_CC2652R7 (read only) 655507 655507 0 0.0
(read/write) 181748 181748 0 0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101531 101531 0 0.0
.text 553496 553496 0 0.0
pump-app LP_CC2652R7 (read only) 681447 681447 0 0.0
(read/write) 160928 160928 0 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 88919 88919 0 0.0
.text 592044 592044 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667023 667023 0 0.0
(read/write) 175488 175488 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84743 84743 0 0.0
.text 581800 581800 0 0.0
shell LP_CC2652R7 (read only) 662678 662678 0 0.0
(read/write) 184224 184224 0 0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85446 85446 0 0.0
.text 576916 576916 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584142 584142 0 0.0
.app_xip_area 460952 460952 0 0.0
.bss 65632 65632 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590614 590614 0 0.0
.app_xip_area 462640 462640 0 0.0
.bss 70416 70416 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589850 589850 0 0.0
.app_xip_area 467468 467468 0 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1089152 1089152 0 0.0
.bss 133268 133268 0 0.0
.data 2064 2064 0 0.0
.text 953800 953800 0 0.0
BRD4161A+rpc (read/write) 1143460 1143460 0 0.0
.bss 149948 149948 0 0.0
.data 2276 2276 0 0.0
.text 991216 991216 0 0.0
BRD4161A+rs911x (read/write) 975120 975120 0 0.0
.bss 161744 161744 0 0.0
.data 2048 2048 0 0.0
.text 811308 811308 0 0.0
lock-app BRD4161A+wf200 (read/write) 1130552 1130552 0 0.0
.bss 144400 144400 0 0.0
.data 2056 2056 0 0.0
.text 984076 984076 0 0.0
window-app BRD4161A (read/write) 1082460 1082460 0 0.0
.bss 134748 134748 0 0.0
.data 2092 2092 0 0.0
.text 945596 945596 0 0.0
esp32 all-clusters-app c3devkit (read only) 1024446 1024450 4 0.0
(read/write) 1487042 1487042 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216672 216672 0 0.0
.flash.text 1024446 1024450 4 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1077927 1077927 0 0.0
(read/write) 489064 489064 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247084 247084 0 0.0
.flash.text 1072543 1072543 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643528 643528 0 0.0
.bss 69720 69720 0 0.0
.data 2044 2044 0 0.0
.text 569036 569036 0 0.0
lock k32w0+release (read/write) 701896 701896 0 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626932 626932 0 0.0
linux all-clusters-app debug (read only) 3015057 3015057 0 0.0
(read/write) 155720 155720 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85384 85384 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 271915 271915 0 0.0
.text 2564258 2564258 0 0.0
all-clusters-minimal-app debug (read only) 2856873 2856873 0 0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77992 77992 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 271947 271947 0 0.0
.text 2408674 2408674 0 0.0
bridge-app debug+rpc (read only) 2362201 2362201 0 0.0
(read/write) 127584 127584 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67544 67544 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202728 202728 0 0.0
.text 1996466 1996466 0 0.0
chip-tool debug (read only) 10558601 10558649 48 0.0
(read/write) 646336 646336 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 611704 611704 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 539509 539509 0 0.0
.text 8523140 8523188 48 0.0
chip-tool-ipv6only arm64 (read only) 9960844 9960908 64 0.0
(read/write) 694017 694017 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639264 639264 0 0.0
.dynamic 560 560 0 0.0
.got 13624 13624 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471180 471180 0 0.0
.text 7862836 7862900 64 0.0
lighting-app debug+rpc (read only) 2584673 2584673 0 0.0
(read/write) 130232 130232 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72456 72456 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 218384 218384 0 0.0
.text 2195218 2195218 0 0.0
lock-app debug (read only) 2573337 2573337 0 0.0
(read/write) 125568 125568 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69592 69592 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 235920 235920 0 0.0
.text 2170402 2170402 0 0.0
ota-provider-app debug (read only) 2353265 2353265 0 0.0
(read/write) 119048 119048 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63416 63416 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 208920 208920 0 0.0
.text 1980466 1980466 0 0.0
ota-requestor-app debug (read only) 2473857 2473857 0 0.0
(read/write) 126440 126440 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 68072 68072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212448 212448 0 0.0
.text 2088914 2088914 0 0.0
shell debug (read only) 2586265 2586265 0 0.0
(read/write) 141872 141872 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77008 77008 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 232882 232882 0 0.0
.text 2195154 2195154 0 0.0
thermostat-no-ble arm64 (read only) 2350700 2350700 0 0.0
(read/write) 141761 141761 0 0.0
.bss 55329 55329 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75976 75976 0 0.0
.dynamic 560 560 0 0.0
.got 5016 5016 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139412 139412 0 0.0
.text 1973776 1973776 0 0.0
tv-app debug (read only) 3155833 3155881 48 0.0
(read/write) 257744 257744 0 0.0
.bss 167352 167352 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79104 79104 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 256392 256392 0 0.0
.text 2709842 2709890 48 0.0
tv-casting-app debug (read only) 5393105 5393153 48 0.0
(read/write) 158728 158728 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98504 98504 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 339825 339825 0 0.0
.text 4785986 4786034 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453416 2453416 0 0.0
.bss 214548 214548 0 0.0
.data 5872 5872 0 0.0
.text 1416060 1416060 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176571 1176571 0 0.0
bss 143224 143224 0 0.0
rodata 142620 142620 0 0.0
text 811888 811888 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156459 1156459 0 0.0
bss 142460 142460 0 0.0
rodata 134148 134148 0 0.0
text 801036 801036 0 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1689268 1689268 0 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1529064 1529064 0 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1633300 1633300 0 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1473816 1473816 0 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553556 1553556 0 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402392 1402392 0 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1592212 1592212 0 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1436552 1436552 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805560 805560 0 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569418 569416 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 826000 826000 0 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 586306 586304 -2 -0.0

@yunhanw-google yunhanw-google force-pushed the feature/fix_write_client_status_response branch from 4eaaad8 to 958f244 Compare August 2, 2022 04:15
@github-actions
Copy link

github-actions bot commented Aug 2, 2022 •
edited
Loading

PR #21511: Size comparison from 97134c5 to 958f244

Increases (5 builds for cc13x2_26x2, linux)
platform target config section 97134c5 958f244 change % change
cc13x2_26x2 shell LP_CC2652R7 (read/write) 184224 184232 8 0.0
linux chip-tool debug (read only) 10558633 10558681 48 0.0
.text 8523172 8523220 48 0.0
chip-tool-ipv6only arm64 (read only) 9960892 9960956 64 0.0
.text 7862884 7862948 64 0.0
tv-app debug (read only) 3155865 3155913 48 0.0
.text 2709874 2709922 48 0.0
tv-casting-app debug (read only) 5393105 5393153 48 0.0
.text 4785986 4786034 48 0.0
Decreases (2 builds for cc13x2_26x2, esp32)
platform target config section 97134c5 958f244 change % change
cc13x2_26x2 shell LP_CC2652R7 (read only) 662678 662670 -8 -0.0
.text 576916 576908 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1024448 1024446 -2 -0.0
.flash.text 1024448 1024446 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 97134c5 958f244 change % change
bl602 lighting-app bl602 (read/write) 1382658 1382658 0 0.0
.bss 117626 117626 0 0.0
.data 4480 4480 0 0.0
.text 1052768 1052768 0 0.0
bl602+rpc (read/write) 1428058 1428058 0 0.0
.bss 125066 125066 0 0.0
.data 4600 4600 0 0.0
.text 1084432 1084432 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 669979 669979 0 0.0
(read/write) 181404 181404 0 0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88467 88467 0 0.0
.text 581196 581196 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 635491 635491 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77691 77691 0 0.0
.text 557476 557476 0 0.0
lock-ftd LP_CC2652R7 (read only) 672959 672959 0 0.0
(read/write) 168608 168608 0 0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76535 76535 0 0.0
.text 595944 595944 0 0.0
lock-mtd LP_CC2652R7 (read only) 655507 655507 0 0.0
(read/write) 181748 181748 0 0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101531 101531 0 0.0
.text 553496 553496 0 0.0
pump-app LP_CC2652R7 (read only) 681447 681447 0 0.0
(read/write) 160928 160928 0 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 88919 88919 0 0.0
.text 592044 592044 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667023 667023 0 0.0
(read/write) 175488 175488 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84743 84743 0 0.0
.text 581800 581800 0 0.0
shell LP_CC2652R7 (read only) 662678 662670 -8 -0.0
(read/write) 184224 184232 8 0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85446 85446 0 0.0
.text 576916 576908 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584142 584142 0 0.0
.app_xip_area 460952 460952 0 0.0
.bss 65632 65632 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590614 590614 0 0.0
.app_xip_area 462640 462640 0 0.0
.bss 70416 70416 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589850 589850 0 0.0
.app_xip_area 467468 467468 0 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1089152 1089152 0 0.0
.bss 133268 133268 0 0.0
.data 2064 2064 0 0.0
.text 953800 953800 0 0.0
BRD4161A+rpc (read/write) 1143460 1143460 0 0.0
.bss 149948 149948 0 0.0
.data 2276 2276 0 0.0
.text 991216 991216 0 0.0
BRD4161A+rs911x (read/write) 975120 975120 0 0.0
.bss 161744 161744 0 0.0
.data 2048 2048 0 0.0
.text 811308 811308 0 0.0
lock-app BRD4161A+wf200 (read/write) 1130552 1130552 0 0.0
.bss 144400 144400 0 0.0
.data 2056 2056 0 0.0
.text 984076 984076 0 0.0
window-app BRD4161A (read/write) 1082460 1082460 0 0.0
.bss 134748 134748 0 0.0
.data 2092 2092 0 0.0
.text 945596 945596 0 0.0
esp32 all-clusters-app c3devkit (read only) 1024448 1024446 -2 -0.0
(read/write) 1487042 1487042 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216672 216672 0 0.0
.flash.text 1024448 1024446 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1077927 1077927 0 0.0
(read/write) 489064 489064 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247084 247084 0 0.0
.flash.text 1072543 1072543 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643528 643528 0 0.0
.bss 69720 69720 0 0.0
.data 2044 2044 0 0.0
.text 569036 569036 0 0.0
lock k32w0+release (read/write) 701896 701896 0 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626932 626932 0 0.0
linux all-clusters-app debug (read only) 3015057 3015057 0 0.0
(read/write) 155720 155720 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85384 85384 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 271915 271915 0 0.0
.text 2564258 2564258 0 0.0
all-clusters-minimal-app debug (read only) 2856873 2856873 0 0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77992 77992 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 271947 271947 0 0.0
.text 2408674 2408674 0 0.0
bridge-app debug+rpc (read only) 2362201 2362201 0 0.0
(read/write) 127584 127584 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67544 67544 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202728 202728 0 0.0
.text 1996466 1996466 0 0.0
chip-tool debug (read only) 10558633 10558681 48 0.0
(read/write) 646336 646336 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 611704 611704 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 539509 539509 0 0.0
.text 8523172 8523220 48 0.0
chip-tool-ipv6only arm64 (read only) 9960892 9960956 64 0.0
(read/write) 694017 694017 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639264 639264 0 0.0
.dynamic 560 560 0 0.0
.got 13624 13624 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471180 471180 0 0.0
.text 7862884 7862948 64 0.0
lighting-app debug+rpc (read only) 2584673 2584673 0 0.0
(read/write) 130232 130232 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72456 72456 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 218384 218384 0 0.0
.text 2195218 2195218 0 0.0
lock-app debug (read only) 2573337 2573337 0 0.0
(read/write) 125568 125568 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69592 69592 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 235920 235920 0 0.0
.text 2170402 2170402 0 0.0
ota-provider-app debug (read only) 2353265 2353265 0 0.0
(read/write) 119048 119048 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63416 63416 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 208920 208920 0 0.0
.text 1980466 1980466 0 0.0
ota-requestor-app debug (read only) 2473857 2473857 0 0.0
(read/write) 126440 126440 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 68072 68072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212448 212448 0 0.0
.text 2088914 2088914 0 0.0
shell debug (read only) 2586265 2586265 0 0.0
(read/write) 141872 141872 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77008 77008 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 232882 232882 0 0.0
.text 2195154 2195154 0 0.0
thermostat-no-ble arm64 (read only) 2350700 2350700 0 0.0
(read/write) 141761 141761 0 0.0
.bss 55329 55329 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75976 75976 0 0.0
.dynamic 560 560 0 0.0
.got 5016 5016 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139412 139412 0 0.0
.text 1973776 1973776 0 0.0
tv-app debug (read only) 3155865 3155913 48 0.0
(read/write) 257744 257744 0 0.0
.bss 167352 167352 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79104 79104 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 256392 256392 0 0.0
.text 2709874 2709922 48 0.0
tv-casting-app debug (read only) 5393105 5393153 48 0.0
(read/write) 158728 158728 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98504 98504 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 339825 339825 0 0.0
.text 4785986 4786034 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453416 2453416 0 0.0
.bss 214548 214548 0 0.0
.data 5872 5872 0 0.0
.text 1416060 1416060 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176571 1176571 0 0.0
bss 143224 143224 0 0.0
rodata 142620 142620 0 0.0
text 811888 811888 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156459 1156459 0 0.0
bss 142460 142460 0 0.0
rodata 134148 134148 0 0.0
text 801036 801036 0 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1689268 1689268 0 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1529064 1529064 0 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1633300 1633300 0 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1473816 1473816 0 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553556 1553556 0 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402392 1402392 0 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1592212 1592212 0 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1436552 1436552 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805560 805560 0 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569418 569418 0 0.0
lighting-app tlsr9518adk80d (read/write) 826000 826000 0 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 586306 586306 0 0.0

bzbarsky-apple
bzbarsky-apple reviewed Aug 9, 2022
View reviewed changes
src/app/tests/TestWriteInteraction.cpp Outdated Show resolved Hide resolved
src/app/tests/TestWriteInteraction.cpp Outdated Show resolved Hide resolved
src/app/tests/TestWriteInteraction.cpp Outdated Show resolved Hide resolved
src/app/tests/TestWriteInteraction.cpp Outdated Show resolved Hide resolved
src/app/tests/TestWriteInteraction.cpp Outdated Show resolved Hide resolved
src/app/tests/TestWriteInteraction.cpp Outdated Show resolved Hide resolved
src/app/tests/TestWriteInteraction.cpp Outdated Show resolved Hide resolved
src/app/tests/TestWriteInteraction.cpp Outdated Show resolved Hide resolved
src/app/tests/TestWriteInteraction.cpp Outdated Show resolved Hide resolved
src/app/tests/TestWriteInteraction.cpp Outdated Show resolved Hide resolved
@yunhanw-google yunhanw-google force-pushed the feature/fix_write_client_status_response branch from 65a17a5 to d3029f9 Compare August 10, 2022 00:48
@github-actions
Copy link

github-actions bot commented Aug 10, 2022 •
edited
Loading

PR #21511: Size comparison from a6cdfbb to d3029f9

Increases (3 builds for cc13x2_26x2, cyw30739, linux)
platform target config section a6cdfbb d3029f9 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 181860 181868 8 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596954 596962 8 0.0
.app_xip_area 474476 474484 8 0.0
linux chip-tool-ipv6only arm64 (read only) 10007084 10007148 64 0.0
.text 7903284 7903348 64 0.0
Decreases (5 builds for bl602, cc13x2_26x2, esp32, telink)
platform target config section a6cdfbb d3029f9 change % change
bl602 lighting-app bl602+rpc .text 1079636 1079632 -4 -0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 655395 655387 -8 -0.0
.text 553552 553544 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1026078 1026076 -2 -0.0
.flash.text 1026078 1026076 -2 -0.0
telink light-switch-app tlsr9518adk80d text 569826 569822 -4 -0.0
lighting-app tlsr9518adk80d text 587800 587798 -2 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a6cdfbb d3029f9 change % change
bl602 lighting-app bl602 (read/write) 1379962 1379962 0 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1048136 1048136 0 0.0
bl602+rpc (read/write) 1425210 1425210 0 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079636 1079632 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670927 670927 0 0.0
(read/write) 180456 180456 0 0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88471 88471 0 0.0
.text 582140 582140 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636471 636471 0 0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77727 77727 0 0.0
.text 558420 558420 0 0.0
lock-ftd LP_CC2652R7 (read only) 672787 672787 0 0.0
(read/write) 168780 168780 0 0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76411 76411 0 0.0
.text 595896 595896 0 0.0
lock-mtd LP_CC2652R7 (read only) 655395 655387 -8 -0.0
(read/write) 181860 181868 8 0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101363 101363 0 0.0
.text 553552 553544 -8 -0.0
pump-app LP_CC2652R7 (read only) 683019 683019 0 0.0
(read/write) 159356 159356 0 0.0
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89315 89315 0 0.0
.text 593220 593220 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667487 667487 0 0.0
(read/write) 175024 175024 0 0.0
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84863 84863 0 0.0
.text 582144 582144 0 0.0
shell LP_CC2652R7 (read only) 663610 663610 0 0.0
(read/write) 183292 183292 0 0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85418 85418 0 0.0
.text 577876 577876 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584646 584646 0 0.0
.app_xip_area 461448 461448 0 0.0
.bss 65640 65640 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590582 590582 0 0.0
.app_xip_area 462600 462600 0 0.0
.bss 70424 70424 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596954 596962 8 0.0
.app_xip_area 474476 474484 8 0.0
.bss 64952 64952 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1096372 1096372 0 0.0
.bss 132844 132844 0 0.0
.data 2068 2068 0 0.0
.text 961436 961436 0 0.0
BRD4161A+rpc (read/write) 1150636 1150636 0 0.0
.bss 149532 149532 0 0.0
.data 2280 2280 0 0.0
.text 998804 998804 0 0.0
BRD4161A+rs911x (read/write) 985908 985908 0 0.0
.bss 162184 162184 0 0.0
.data 2056 2056 0 0.0
.text 821648 821648 0 0.0
lock-app BRD4161A+wf200 (read/write) 1136484 1136484 0 0.0
.bss 144824 144824 0 0.0
.data 2064 2064 0 0.0
.text 989576 989576 0 0.0
window-app BRD4161A (read/write) 1088104 1088104 0 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 951696 951696 0 0.0
esp32 all-clusters-app c3devkit (read only) 1026078 1026076 -2 -0.0
(read/write) 1487418 1487418 0 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217048 217048 0 0.0
.flash.text 1026078 1026076 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079367 1079367 0 0.0
(read/write) 489392 489392 0 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247412 247412 0 0.0
.flash.text 1073983 1073983 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643644 643644 0 0.0
.bss 69712 69712 0 0.0
.data 2044 2044 0 0.0
.text 569160 569160 0 0.0
lock k32w0+release (read/write) 701076 701076 0 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626112 626112 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10007084 10007148 64 0.0
(read/write) 695153 695153 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 640360 640360 0 0.0
.dynamic 560 560 0 0.0
.got 13656 13656 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 474124 474124 0 0.0
.text 7903284 7903348 64 0.0
thermostat-no-ble arm64 (read only) 2350956 2350956 0 0.0
(read/write) 141681 141681 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75880 75880 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139716 139716 0 0.0
.text 1973712 1973712 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452720 2452720 0 0.0
.bss 214556 214556 0 0.0
.data 5872 5872 0 0.0
.text 1415364 1415364 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177959 1177959 0 0.0
bss 143222 143222 0 0.0
rodata 142776 142776 0 0.0
text 813112 813112 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157983 1157983 0 0.0
bss 142460 142460 0 0.0
rodata 134472 134472 0 0.0
text 802232 802232 0 0.0
p6 all-clusters-app default (read only) 881520 881520 0 0.0
(read/write) 1693812 1693812 0 0.0
.bss 149168 149168 0 0.0
.data 2656 2656 0 0.0
.text 1533600 1533600 0 0.0
all-clusters-minimal-app default (read only) 882240 882240 0 0.0
(read/write) 1637980 1637980 0 0.0
.bss 148448 148448 0 0.0
.data 2656 2656 0 0.0
.text 1478488 1478488 0 0.0
light-app default (read only) 890560 890560 0 0.0
(read/write) 1556668 1556668 0 0.0
.bss 140336 140336 0 0.0
.data 2448 2448 0 0.0
.text 1405496 1405496 0 0.0
lock-app default (read only) 886064 886064 0 0.0
(read/write) 1593980 1593980 0 0.0
.bss 144816 144816 0 0.0
.data 2464 2464 0 0.0
.text 1438312 1438312 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 806120 806120 0 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569826 569822 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 827928 827928 0 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587800 587798 -2 -0.0

@yunhanw-google yunhanw-google merged commit a211643 into project-chip:master Aug 10, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@yunhanw-google @isiu-apple
Fix status reponse in write client (project-chip#21511)
f3acea1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunhanw-google @yufengwangca @bzbarsky-apple