Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix status report in ReadClient #21458

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Fix status report in ReadClient #21458

merged 1 commit into from
Aug 2, 2022

Conversation

woody-apple
Copy link
Contributor

Problem

Fix status report in ReadClient
This PR is cut from #19356

Change overview

ProcessStatusReport would send status report with Success when the processing is successful, otherwise, the status report with invalid action would be sent by the caller.

Then onMessageReceived in ReadClient would send status report with invalid action when there is error happening in incoming message.

Fix InteractionModelEngine::OnUnsolicitedReportData, when error happens, we should send status report with invalid action.

Testing

Add tests to test how readClient for read/subscribe handle problematic message.

@bzbarsky-apple
Copy link
Contributor

@woody-apple I think you'll need to cherry-pick #21321 to get this one to pass tests...

@bzbarsky-apple
Copy link
Contributor

Created #21462 to do that.

@github-actions
Copy link

github-actions bot commented Jul 30, 2022 •
edited
Loading

PR #21458: Size comparison from 4052fa1 to 968bd2d

Increases (13 builds for bl602, cc13x2_26x2, efr32, linux, p6, telink)
platform target config section 4052fa1 968bd2d change % change
bl602 lighting-app bl602 (read/write) 1382018 1382034 16 0.0
.text 1052128 1052144 16 0.0
bl602+rpc (read/write) 1427450 1427466 16 0.0
.text 1083824 1083840 16 0.0
cc13x2_26x2 shell LP_CC2652R7 (read only) 661558 661566 8 0.0
.text 575980 575988 8 0.0
efr32 lighting-app BRD4161A (read/write) 1088688 1088704 16 0.0
.text 953336 953352 16 0.0
BRD4161A+rpc (read/write) 1143044 1143060 16 0.0
.text 990800 990816 16 0.0
linux chip-tool debug (read only) 10424385 10424417 32 0.0
.text 8443300 8443332 32 0.0
chip-tool-ipv6only arm64 (read only) 9836564 9836740 176 0.0
.text 7792804 7792980 176 0.0
thermostat-no-ble arm64 (read only) 2345324 2345436 112 0.0
.text 1968688 1968800 112 0.0
tv-app debug (read only) 3131937 3131969 32 0.0
.text 2687938 2687970 32 0.0
tv-casting-app debug (read only) 5384457 5384505 48 0.0
.text 4778386 4778434 48 0.0
p6 all-clusters-minimal-app default (read/write) 1632084 1632100 16 0.0
.text 1472624 1472640 16 0.0
light-app default (read/write) 1553052 1553068 16 0.0
.text 1401896 1401912 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 820648 820656 8 0.0
text 584528 584530 2 0.0
Decreases (10 builds for cc13x2_26x2, linux)
platform target config section 4052fa1 968bd2d change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 634467 634459 -8 -0.0
.text 556636 556628 -8 -0.0
shell LP_CC2652R7 (read/write) 185312 185304 -8 -0.0
linux all-clusters-app debug (read only) 3005089 3005057 -32 -0.0
.text 2555906 2555874 -32 -0.0
all-clusters-minimal-app debug (read only) 2848113 2848081 -32 -0.0
.text 2401378 2401346 -32 -0.0
bridge-app debug+rpc (read only) 2355665 2355633 -32 -0.0
.text 1990946 1990914 -32 -0.0
lighting-app debug+rpc (read only) 2578009 2577977 -32 -0.0
.text 2189634 2189602 -32 -0.0
lock-app debug (read only) 2563905 2563873 -32 -0.0
.text 2162306 2162274 -32 -0.0
ota-provider-app debug (read only) 2346361 2346329 -32 -0.0
.text 1974610 1974578 -32 -0.0
ota-requestor-app debug (read only) 2467225 2467193 -32 -0.0
.text 2083330 2083298 -32 -0.0
shell debug (read only) 2577249 2577217 -32 -0.0
.text 2187474 2187442 -32 -0.0
Full report (39 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, p6, telink)
platform target config section 4052fa1 968bd2d change % change
bl602 lighting-app bl602 (read/write) 1382018 1382034 16 0.0
.bss 117626 117626 0 0.0
.data 4480 4480 0 0.0
.text 1052128 1052144 16 0.0
bl602+rpc (read/write) 1427450 1427466 16 0.0
.bss 125066 125066 0 0.0
.data 4600 4600 0 0.0
.text 1083824 1083840 16 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668851 668851 0 0.0
(read/write) 182500 182500 0 0.0
.bss 74244 74244 0 0.0
.data 3372 3372 0 0.0
.rodata 88283 88283 0 0.0
.text 580252 580252 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634467 634459 -8 -0.0
(read/write) 157828 157828 0 0.0
.bss 73540 73540 0 0.0
.data 3372 3372 0 0.0
.rodata 77507 77507 0 0.0
.text 556636 556628 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 671727 671727 0 0.0
(read/write) 169816 169816 0 0.0
.bss 71324 71324 0 0.0
.data 3296 3296 0 0.0
.rodata 76351 76351 0 0.0
.text 594896 594896 0 0.0
lock-mtd LP_CC2652R7 (read only) 653995 653995 0 0.0
(read/write) 183236 183236 0 0.0
.bss 67012 67012 0 0.0
.data 3296 3296 0 0.0
.rodata 101107 101107 0 0.0
.text 552408 552408 0 0.0
pump-app LP_CC2652R7 (read only) 680839 680839 0 0.0
(read/write) 161528 161528 0 0.0
.bss 71380 71380 0 0.0
.data 3296 3296 0 0.0
.rodata 88919 88919 0 0.0
.text 591436 591436 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666415 666415 0 0.0
(read/write) 176088 176088 0 0.0
.bss 71516 71516 0 0.0
.data 3292 3292 0 0.0
.rodata 84743 84743 0 0.0
.text 581192 581192 0 0.0
shell LP_CC2652R7 (read only) 661558 661566 8 0.0
(read/write) 185312 185304 -8 -0.0
.bss 76564 76564 0 0.0
.data 3376 3376 0 0.0
.rodata 85262 85262 0 0.0
.text 575980 575988 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583542 583542 0 0.0
.app_xip_area 460496 460496 0 0.0
.bss 65632 65632 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589390 589390 0 0.0
.app_xip_area 461616 461616 0 0.0
.bss 70360 70360 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589242 589242 0 0.0
.app_xip_area 467012 467012 0 0.0
.bss 64872 64872 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1088688 1088704 16 0.0
.bss 133268 133268 0 0.0
.data 2064 2064 0 0.0
.text 953336 953352 16 0.0
BRD4161A+rpc (read/write) 1143044 1143060 16 0.0
.bss 149948 149948 0 0.0
.data 2276 2276 0 0.0
.text 990800 990816 16 0.0
BRD4161A+rs911x (read/write) 973984 973984 0 0.0
.bss 161744 161744 0 0.0
.data 2048 2048 0 0.0
.text 810172 810172 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128944 1128944 0 0.0
.bss 144376 144376 0 0.0
.data 2056 2056 0 0.0
.text 982492 982492 0 0.0
window-app BRD4161A (read/write) 1081988 1081988 0 0.0
.bss 134740 134740 0 0.0
.data 2092 2092 0 0.0
.text 945132 945132 0 0.0
k32w light k32w0+release (read/write) 643128 643128 0 0.0
.bss 69720 69720 0 0.0
.data 2044 2044 0 0.0
.text 568636 568636 0 0.0
lock k32w0+release (read/write) 700304 700304 0 0.0
.bss 70160 70160 0 0.0
.data 2052 2052 0 0.0
.text 625364 625364 0 0.0
linux all-clusters-app debug (read only) 3005089 3005057 -32 -0.0
(read/write) 155712 155712 0 0.0
.bss 61920 61920 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85384 85384 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 270347 270347 0 0.0
.text 2555906 2555874 -32 -0.0
all-clusters-minimal-app debug (read only) 2848113 2848081 -32 -0.0
(read/write) 147448 147448 0 0.0
.bss 61120 61120 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77992 77992 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 270507 270507 0 0.0
.text 2401378 2401346 -32 -0.0
bridge-app debug+rpc (read only) 2355665 2355633 -32 -0.0
(read/write) 127576 127576 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67544 67544 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 201736 201736 0 0.0
.text 1990946 1990914 -32 -0.0
chip-tool debug (read only) 10424385 10424417 32 0.0
(read/write) 628376 628376 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 593744 593744 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 535893 535893 0 0.0
.text 8443300 8443332 32 0.0
chip-tool-ipv6only arm64 (read only) 9836564 9836740 176 0.0
(read/write) 675905 675905 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 621248 621248 0 0.0
.dynamic 560 560 0 0.0
.got 13528 13528 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468004 468004 0 0.0
.text 7792804 7792980 176 0.0
lighting-app debug+rpc (read only) 2578009 2577977 -32 -0.0
(read/write) 130256 130256 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72456 72456 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 217328 217328 0 0.0
.text 2189634 2189602 -32 -0.0
lock-app debug (read only) 2563905 2563873 -32 -0.0
(read/write) 125528 125528 0 0.0
.bss 48224 48224 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69592 69592 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 234608 234608 0 0.0
.text 2162306 2162274 -32 -0.0
ota-provider-app debug (read only) 2346361 2346329 -32 -0.0
(read/write) 119040 119040 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63416 63416 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207896 207896 0 0.0
.text 1974610 1974578 -32 -0.0
ota-requestor-app debug (read only) 2467225 2467193 -32 -0.0
(read/write) 126432 126432 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 68072 68072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 211424 211424 0 0.0
.text 2083330 2083298 -32 -0.0
shell debug (read only) 2577249 2577217 -32 -0.0
(read/write) 141832 141832 0 0.0
.bss 57768 57768 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77008 77008 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 231570 231570 0 0.0
.text 2187474 2187442 -32 -0.0
thermostat-no-ble arm64 (read only) 2345324 2345436 112 0.0
(read/write) 141761 141761 0 0.0
.bss 55329 55329 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75976 75976 0 0.0
.dynamic 560 560 0 0.0
.got 5016 5016 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139124 139124 0 0.0
.text 1968688 1968800 112 0.0
tv-app debug (read only) 3131937 3131969 32 0.0
(read/write) 257512 257512 0 0.0
.bss 167288 167288 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78960 78960 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 254760 254760 0 0.0
.text 2687938 2687970 32 0.0
tv-casting-app debug (read only) 5384457 5384505 48 0.0
(read/write) 158720 158720 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98504 98504 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 338801 338801 0 0.0
.text 4778386 4778434 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2451480 2451480 0 0.0
.bss 214524 214524 0 0.0
.data 5872 5872 0 0.0
.text 1414124 1414124 0 0.0
p6 all-clusters-app default (read only) 881552 881552 0 0.0
(read/write) 1687972 1687972 0 0.0
.bss 149144 149144 0 0.0
.data 2648 2648 0 0.0
.text 1527792 1527792 0 0.0
all-clusters-minimal-app default (read only) 882272 882272 0 0.0
(read/write) 1632084 1632100 16 0.0
.bss 148424 148424 0 0.0
.data 2648 2648 0 0.0
.text 1472624 1472640 16 0.0
light-app default (read only) 890576 890576 0 0.0
(read/write) 1553052 1553068 16 0.0
.bss 140328 140328 0 0.0
.data 2440 2440 0 0.0
.text 1401896 1401912 16 0.0
lock-app default (read only) 886104 886104 0 0.0
(read/write) 1590684 1590684 0 0.0
.bss 144784 144784 0 0.0
.data 2456 2456 0 0.0
.text 1435056 1435056 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 800240 800240 0 0.0
bss 70804 70804 0 0.0
noinit 40416 40416 0 0.0
text 567666 567666 0 0.0
lighting-app tlsr9518adk80d (read/write) 820648 820656 8 0.0
bss 71648 71648 0 0.0
noinit 40416 40416 0 0.0
text 584528 584530 2 0.0

@woody-apple woody-apple force-pushed the cherry-pick-ad27b61e1460cbf5c9899516fea39422ec862b16 branch from 968bd2d to 04eff3c Compare July 30, 2022 16:02
@github-actions
Copy link

github-actions bot commented Jul 30, 2022 •
edited
Loading

PR #21458: Size comparison from 8e606b5 to 04eff3c

Increases (6 builds for bl602, esp32, linux)
platform target config section 8e606b5 04eff3c change % change
bl602 lighting-app bl602 (read/write) 1382018 1382034 16 0.0
.text 1052132 1052144 12 0.0
bl602+rpc (read/write) 1427450 1427466 16 0.0
.text 1083824 1083840 16 0.0
esp32 all-clusters-app c3devkit (read only) 1023534 1023546 12 0.0
.flash.text 1023534 1023546 12 0.0
linux chip-tool debug (read only) 10424385 10424417 32 0.0
.text 8443300 8443332 32 0.0
tv-app debug (read only) 3131937 3131969 32 0.0
.text 2687938 2687970 32 0.0
tv-casting-app debug (read only) 5384457 5384505 48 0.0
.text 4778386 4778434 48 0.0
Decreases (10 builds for esp32, linux, nrfconnect)
platform target config section 8e606b5 04eff3c change % change
esp32 all-clusters-app m5stack (read only) 1076859 1076851 -8 -0.0
.flash.text 1071475 1071467 -8 -0.0
linux all-clusters-app debug (read only) 3005089 3005057 -32 -0.0
.text 2555906 2555874 -32 -0.0
all-clusters-minimal-app debug (read only) 2848113 2848081 -32 -0.0
.text 2401378 2401346 -32 -0.0
bridge-app debug+rpc (read only) 2355665 2355633 -32 -0.0
.text 1990946 1990914 -32 -0.0
lighting-app debug+rpc (read only) 2578009 2577977 -32 -0.0
.text 2189634 2189602 -32 -0.0
lock-app debug (read only) 2563905 2563873 -32 -0.0
.text 2162306 2162274 -32 -0.0
ota-provider-app debug (read only) 2346361 2346329 -32 -0.0
.text 1974610 1974578 -32 -0.0
ota-requestor-app debug (read only) 2467225 2467193 -32 -0.0
.text 2083330 2083298 -32 -0.0
shell debug (read only) 2577249 2577217 -32 -0.0
.text 2187474 2187442 -32 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179783 1179767 -16 -0.0
text 814772 814768 -4 -0.0
Full report (18 builds for bl602, esp32, linux, mbed, nrfconnect)
platform target config section 8e606b5 04eff3c change % change
bl602 lighting-app bl602 (read/write) 1382018 1382034 16 0.0
.bss 117626 117626 0 0.0
.data 4480 4480 0 0.0
.text 1052132 1052144 12 0.0
bl602+rpc (read/write) 1427450 1427466 16 0.0
.bss 125066 125066 0 0.0
.data 4600 4600 0 0.0
.text 1083824 1083840 16 0.0
esp32 all-clusters-app c3devkit (read only) 1023534 1023546 12 0.0
(read/write) 1486586 1486586 0 0.0
.dram0.bss 70304 70304 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216248 216248 0 0.0
.flash.text 1023534 1023546 12 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1076859 1076851 -8 -0.0
(read/write) 488616 488616 0 0.0
.dram0.bss 75816 75816 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246660 246660 0 0.0
.flash.text 1071475 1071467 -8 -0.0
.iram0.text 123267 123267 0 0.0
linux all-clusters-app debug (read only) 3005089 3005057 -32 -0.0
(read/write) 155712 155712 0 0.0
.bss 61920 61920 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85384 85384 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 270347 270347 0 0.0
.text 2555906 2555874 -32 -0.0
all-clusters-minimal-app debug (read only) 2848113 2848081 -32 -0.0
(read/write) 147448 147448 0 0.0
.bss 61120 61120 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77992 77992 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 270507 270507 0 0.0
.text 2401378 2401346 -32 -0.0
bridge-app debug+rpc (read only) 2355665 2355633 -32 -0.0
(read/write) 127576 127576 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67544 67544 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 201736 201736 0 0.0
.text 1990946 1990914 -32 -0.0
chip-tool debug (read only) 10424385 10424417 32 0.0
(read/write) 628376 628376 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 593744 593744 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 535893 535893 0 0.0
.text 8443300 8443332 32 0.0
lighting-app debug+rpc (read only) 2578009 2577977 -32 -0.0
(read/write) 130256 130256 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72456 72456 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 217328 217328 0 0.0
.text 2189634 2189602 -32 -0.0
lock-app debug (read only) 2563905 2563873 -32 -0.0
(read/write) 125528 125528 0 0.0
.bss 48224 48224 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69592 69592 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 234608 234608 0 0.0
.text 2162306 2162274 -32 -0.0
ota-provider-app debug (read only) 2346361 2346329 -32 -0.0
(read/write) 119040 119040 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63416 63416 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 207896 207896 0 0.0
.text 1974610 1974578 -32 -0.0
ota-requestor-app debug (read only) 2467225 2467193 -32 -0.0
(read/write) 126432 126432 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 68072 68072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 211424 211424 0 0.0
.text 2083330 2083298 -32 -0.0
shell debug (read only) 2577249 2577217 -32 -0.0
(read/write) 141832 141832 0 0.0
.bss 57768 57768 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77008 77008 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 231570 231570 0 0.0
.text 2187474 2187442 -32 -0.0
tv-app debug (read only) 3131937 3131969 32 0.0
(read/write) 257512 257512 0 0.0
.bss 167288 167288 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78960 78960 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 254760 254760 0 0.0
.text 2687938 2687970 32 0.0
tv-casting-app debug (read only) 5384457 5384505 48 0.0
(read/write) 158720 158720 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98504 98504 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 338801 338801 0 0.0
.text 4778386 4778434 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2451480 2451480 0 0.0
.bss 214524 214524 0 0.0
.data 5872 5872 0 0.0
.text 1414124 1414124 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179783 1179767 -16 -0.0
bss 143200 143200 0 0.0
rodata 142928 142928 0 0.0
text 814772 814768 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159767 1159767 0 0.0
bss 142436 142436 0 0.0
rodata 134456 134456 0 0.0
text 804028 804028 0 0.0

@yunhanw-google @woody-apple
Fix status report in ReadClient (#21368)
048e55d 
* Fix status report in ReadClient

* address comments

* comments
@woody-apple woody-apple force-pushed the cherry-pick-ad27b61e1460cbf5c9899516fea39422ec862b16 branch from 04eff3c to 048e55d Compare August 1, 2022 21:59
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

PR #21458: Size comparison from c5e7ab6 to 048e55d

Decreases (3 builds for k32w, nrfconnect)
platform target config section c5e7ab6 048e55d change % change
k32w light k32w0+release (read/write) 643368 643352 -16 -0.0
.text 568876 568860 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180935 1180919 -16 -0.0
text 815508 815504 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 804656 804652 -4 -0.0
Full report (5 builds for k32w, mbed, nrfconnect)
platform target config section c5e7ab6 048e55d change % change
k32w light k32w0+release (read/write) 643368 643352 -16 -0.0
.bss 69720 69720 0 0.0
.data 2044 2044 0 0.0
.text 568876 568860 -16 -0.0
lock k32w0+release (read/write) 701496 701496 0 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626532 626532 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453224 2453224 0 0.0
.bss 214548 214548 0 0.0
.data 5872 5872 0 0.0
.text 1415868 1415868 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180935 1180919 -16 -0.0
bss 143224 143224 0 0.0
rodata 143344 143344 0 0.0
text 815508 815504 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160811 1160811 0 0.0
bss 142460 142460 0 0.0
rodata 134876 134876 0 0.0
text 804656 804652 -4 -0.0

@woody-apple woody-apple merged commit 94e6b1b into sve Aug 2, 2022
@woody-apple woody-apple deleted the cherry-pick-ad27b61e1460cbf5c9899516fea39422ec862b16 branch August 2, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sve cherry pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woody-apple @bzbarsky-apple @yunhanw-google