Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix status response in command handler. #21557

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Fix status response in command handler. #21557

merged 1 commit into from
Aug 11, 2022

Conversation

yunhanw-google
Copy link
Contributor

Problem

When there is issue in incoming request, OnInvokeCommandRequest in
CommandRequest would send status response.
This PR is cut from #19356

Change overview

See above

Testing

  1. Send malformed sync invoke command, command handler sends status response with invoke action
  2. Send malformed async invoke command, command handler sends status response with invoke action

@restyled-io restyled-io bot mentioned this pull request Aug 2, 2022
Closed
@yunhanw-google yunhanw-google force-pushed the feature/fix_command_handler_status_response branch from dbfcc99 to 3e0c88c Compare August 2, 2022 20:52
@github-actions
Copy link

github-actions bot commented Aug 2, 2022 •
edited
Loading

PR #21557: Size comparison from 3deee28 to 3e0c88c

Increases (38 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, p6, telink)
platform target config section 3deee28 3e0c88c change % change
bl602 lighting-app bl602 .text 1047200 1047204 4 0.0
bl602+rpc (read/write) 1423986 1423994 8 0.0
.text 1078700 1078704 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 181404 181420 16 0.0
lock-ftd LP_CC2652R7 (read/write) 168608 168624 16 0.0
lock-mtd LP_CC2652R7 (read/write) 181748 181764 16 0.0
pump-app LP_CC2652R7 (read only) 681447 681583 136 0.0
.rodata 88919 89031 112 0.1
.text 592044 592068 24 0.0
pump-controller-app LP_CC2652R7 (read only) 667023 667159 136 0.0
.rodata 84743 84855 112 0.1
.text 581800 581824 24 0.0
shell LP_CC2652R7 (read/write) 184224 184240 16 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589850 589986 136 0.0
.app_xip_area 467468 467604 136 0.0
efr32 lighting-app BRD4161A (read/write) 1089152 1089312 160 0.0
.text 953800 953960 160 0.0
BRD4161A+rpc (read/write) 1143460 1143620 160 0.0
.text 991216 991376 160 0.0
BRD4161A+rs911x (read/write) 975624 975776 152 0.0
.text 811804 811956 152 0.0
lock-app BRD4161A+wf200 (read/write) 1130536 1130680 144 0.0
.text 984060 984204 144 0.0
window-app BRD4161A (read/write) 1082460 1082628 168 0.0
.text 945596 945764 168 0.0
esp32 all-clusters-app c3devkit (read only) 1024448 1024482 34 0.0
(read/write) 1487042 1487162 120 0.0
.flash.rodata 216672 216792 120 0.1
.flash.text 1024448 1024482 34 0.0
m5stack (read/write) 489064 489176 112 0.0
.flash.rodata 247084 247196 112 0.0
linux all-clusters-app debug .rodata 271915 272043 128 0.0
all-clusters-minimal-app debug .rodata 271947 272075 128 0.0
bridge-app debug+rpc .rodata 202728 202856 128 0.1
chip-tool debug .rodata 539509 539637 128 0.0
chip-tool-ipv6only arm64 (read only) 9960892 9961100 208 0.0
.rodata 471180 471340 160 0.0
.text 7862884 7862932 48 0.0
lighting-app debug+rpc .rodata 218384 218512 128 0.1
lock-app debug .rodata 235920 236048 128 0.1
ota-provider-app debug .rodata 208920 209048 128 0.1
ota-requestor-app debug .rodata 212448 212576 128 0.1
shell debug .rodata 232882 233010 128 0.1
thermostat-no-ble arm64 (read only) 2350700 2350892 192 0.0
.rodata 139412 139556 144 0.1
.text 1973776 1973824 48 0.0
tv-app debug .rodata 256392 256520 128 0.0
tv-casting-app debug .rodata 339825 339985 160 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2453416 2453536 120 0.0
.text 1416060 1416180 120 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176571 1176715 144 0.0
rodata 142620 142732 112 0.1
text 811888 811912 24 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156459 1156591 132 0.0
rodata 134148 134264 116 0.1
text 801036 801056 20 0.0
p6 all-clusters-app default (read/write) 1689292 1689444 152 0.0
.text 1529088 1529240 152 0.0
all-clusters-minimal-app default (read/write) 1633332 1633484 152 0.0
.text 1473848 1474000 152 0.0
light-app default (read/write) 1553556 1553708 152 0.0
.text 1402392 1402544 152 0.0
lock-app default (read/write) 1592204 1592356 152 0.0
.text 1436544 1436696 152 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805560 805708 148 0.0
text 569418 569450 32 0.0
lighting-app tlsr9518adk80d (read/write) 826000 826148 148 0.0
text 586308 586338 30 0.0
Decreases (23 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux)
platform target config section 3deee28 3e0c88c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 669979 669963 -16 -0.0
.text 581196 581180 -16 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 635491 635467 -24 -0.0
.rodata 77691 77683 -8 -0.0
.text 557476 557460 -16 -0.0
lock-ftd LP_CC2652R7 (read only) 672959 672943 -16 -0.0
.text 595944 595928 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 655507 655491 -16 -0.0
.text 553496 553480 -16 -0.0
pump-app LP_CC2652R7 (read/write) 160928 160792 -136 -0.1
pump-controller-app LP_CC2652R7 (read/write) 175488 175352 -136 -0.1
shell LP_CC2652R7 (read only) 662678 662662 -16 -0.0
.text 576916 576900 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584142 584126 -16 -0.0
.app_xip_area 460952 460936 -16 -0.0
lock cyw930739m2evb_01 (read/write) 590614 590598 -16 -0.0
.app_xip_area 462640 462624 -16 -0.0
esp32 all-clusters-app m5stack (read only) 1077927 1077923 -4 -0.0
.flash.text 1072543 1072539 -4 -0.0
k32w light k32w0+release (read/write) 643528 643512 -16 -0.0
.text 569036 569020 -16 -0.0
lock k32w0+release (read/write) 701896 701880 -16 -0.0
.text 626932 626916 -16 -0.0
linux all-clusters-app debug (read only) 3015057 3014897 -160 -0.0
.text 2564258 2563970 -288 -0.0
all-clusters-minimal-app debug (read only) 2856873 2856697 -176 -0.0
.text 2408674 2408370 -304 -0.0
bridge-app debug+rpc (read only) 2362201 2362041 -160 -0.0
.text 1996466 1996178 -288 -0.0
chip-tool debug (read only) 10558633 1055845 -176 -0.0
.text 8523172 8522868 -304 -0.0
lighting-app debug+rpc (read only) 2584673 2584497 -176 -0.0
.text 2195218 2194914 -304 -0.0
lock-app debug (read only) 2573337 2573161 -176 -0.0
.text 2170402 2170098 -304 -0.0
ota-provider-app debug (read only) 2353265 2353089 -176 -0.0
.text 1980466 1980162 -304 -0.0
ota-requestor-app debug (read only) 2473857 2473681 -176 -0.0
.text 2088914 2088610 -304 -0.0
shell debug (read only) 2586265 2586089 -176 -0.0
.text 2195154 2194850 -304 -0.0
tv-app debug (read only) 3155729 3155569 -160 -0.0
.text 2709762 2709474 -288 -0.0
tv-casting-app debug (read only) 5393105 5392961 -144 -0.0
.text 4785986 4785682 -304 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3deee28 3e0c88c change % change
bl602 lighting-app bl602 (read/write) 1378738 1378738 0 0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1047200 1047204 4 0.0
bl602+rpc (read/write) 1423986 1423994 8 0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1078700 1078704 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 669979 669963 -16 -0.0
(read/write) 181404 181420 16 0.0
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88467 88467 0 0.0
.text 581196 581180 -16 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 635491 635467 -24 -0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77691 77683 -8 -0.0
.text 557476 557460 -16 -0.0
lock-ftd LP_CC2652R7 (read only) 672959 672943 -16 -0.0
(read/write) 168608 168624 16 0.0
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76535 76535 0 0.0
.text 595944 595928 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 655507 655491 -16 -0.0
(read/write) 181748 181764 16 0.0
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101531 101531 0 0.0
.text 553496 553480 -16 -0.0
pump-app LP_CC2652R7 (read only) 681447 681583 136 0.0
(read/write) 160928 160792 -136 -0.1
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 88919 89031 112 0.1
.text 592044 592068 24 0.0
pump-controller-app LP_CC2652R7 (read only) 667023 667159 136 0.0
(read/write) 175488 175352 -136 -0.1
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84743 84855 112 0.1
.text 581800 581824 24 0.0
shell LP_CC2652R7 (read only) 662678 662662 -16 -0.0
(read/write) 184224 184240 16 0.0
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85446 85446 0 0.0
.text 576916 576900 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584142 584126 -16 -0.0
.app_xip_area 460952 460936 -16 -0.0
.bss 65632 65632 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590614 590598 -16 -0.0
.app_xip_area 462640 462624 -16 -0.0
.bss 70416 70416 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 589850 589986 136 0.0
.app_xip_area 467468 467604 136 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1089152 1089312 160 0.0
.bss 133268 133268 0 0.0
.data 2064 2064 0 0.0
.text 953800 953960 160 0.0
BRD4161A+rpc (read/write) 1143460 1143620 160 0.0
.bss 149948 149948 0 0.0
.data 2276 2276 0 0.0
.text 991216 991376 160 0.0
BRD4161A+rs911x (read/write) 975624 975776 152 0.0
.bss 161752 161752 0 0.0
.data 2048 2048 0 0.0
.text 811804 811956 152 0.0
lock-app BRD4161A+wf200 (read/write) 1130536 1130680 144 0.0
.bss 144400 144400 0 0.0
.data 2056 2056 0 0.0
.text 984060 984204 144 0.0
window-app BRD4161A (read/write) 1082460 1082628 168 0.0
.bss 134748 134748 0 0.0
.data 2092 2092 0 0.0
.text 945596 945764 168 0.0
esp32 all-clusters-app c3devkit (read only) 1024448 1024482 34 0.0
(read/write) 1487042 1487162 120 0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216672 216792 120 0.1
.flash.text 1024448 1024482 34 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1077927 1077923 -4 -0.0
(read/write) 489064 489176 112 0.0
.dram0.bss 75840 75840 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247084 247196 112 0.0
.flash.text 1072543 1072539 -4 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 643528 643512 -16 -0.0
.bss 69720 69720 0 0.0
.data 2044 2044 0 0.0
.text 569036 569020 -16 -0.0
lock k32w0+release (read/write) 701896 701880 -16 -0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626932 626916 -16 -0.0
linux all-clusters-app debug (read only) 3015057 3014897 -160 -0.0
(read/write) 155720 155720 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85384 85384 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 271915 272043 128 0.0
.text 2564258 2563970 -288 -0.0
all-clusters-minimal-app debug (read only) 2856873 2856697 -176 -0.0
(read/write) 147488 147488 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77992 77992 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 271947 272075 128 0.0
.text 2408674 2408370 -304 -0.0
bridge-app debug+rpc (read only) 2362201 2362041 -160 -0.0
(read/write) 127584 127584 0 0.0
.bss 50592 50592 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67544 67544 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202728 202856 128 0.1
.text 1996466 1996178 -288 -0.0
chip-tool debug (read only) 10558633 1055845 -176 -0.0
(read/write) 646336 646336 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 611704 611704 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 539509 539637 128 0.0
.text 8523172 8522868 -304 -0.0
chip-tool-ipv6only arm64 (read only) 9960892 9961100 208 0.0
(read/write) 694017 694017 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639264 639264 0 0.0
.dynamic 560 560 0 0.0
.got 13624 13624 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471180 471340 160 0.0
.text 7862884 7862932 48 0.0
lighting-app debug+rpc (read only) 2584673 2584497 -176 -0.0
(read/write) 130232 130232 0 0.0
.bss 49728 49728 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72456 72456 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 218384 218512 128 0.1
.text 2195218 2194914 -304 -0.0
lock-app debug (read only) 2573337 2573161 -176 -0.0
(read/write) 125568 125568 0 0.0
.bss 48256 48256 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69592 69592 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 235920 236048 128 0.1
.text 2170402 2170098 -304 -0.0
ota-provider-app debug (read only) 2353265 2353089 -176 -0.0
(read/write) 119048 119048 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63416 63416 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 208920 209048 128 0.1
.text 1980466 1980162 -304 -0.0
ota-requestor-app debug (read only) 2473857 2473681 -176 -0.0
(read/write) 126440 126440 0 0.0
.bss 50176 50176 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 68072 68072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 212448 212576 128 0.1
.text 2088914 2088610 -304 -0.0
shell debug (read only) 2586265 2586089 -176 -0.0
(read/write) 141872 141872 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77008 77008 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 232882 233010 128 0.1
.text 2195154 2194850 -304 -0.0
thermostat-no-ble arm64 (read only) 2350700 2350892 192 0.0
(read/write) 141761 141761 0 0.0
.bss 55329 55329 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75976 75976 0 0.0
.dynamic 560 560 0 0.0
.got 5016 5016 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139412 139556 144 0.1
.text 1973776 1973824 48 0.0
tv-app debug (read only) 3155729 3155569 -160 -0.0
(read/write) 257736 257736 0 0.0
.bss 167352 167352 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79104 79104 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 256392 256520 128 0.0
.text 2709762 2709474 -288 -0.0
tv-casting-app debug (read only) 5393105 5392961 -144 -0.0
(read/write) 158728 158728 0 0.0
.bss 51384 51384 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98504 98504 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 339825 339985 160 0.0
.text 4785986 4785682 -304 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453416 2453536 120 0.0
.bss 214548 214548 0 0.0
.data 5872 5872 0 0.0
.text 1416060 1416180 120 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176571 1176715 144 0.0
bss 143224 143224 0 0.0
rodata 142620 142732 112 0.1
text 811888 811912 24 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156459 1156591 132 0.0
bss 142460 142460 0 0.0
rodata 134148 134264 116 0.1
text 801036 801056 20 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1689292 1689444 152 0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1529088 1529240 152 0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1633332 1633484 152 0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1473848 1474000 152 0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1553556 1553708 152 0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1402392 1402544 152 0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1592204 1592356 152 0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1436544 1436696 152 0.0
telink light-switch-app tlsr9518adk80d (read/write) 805560 805708 148 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569418 569450 32 0.0
lighting-app tlsr9518adk80d (read/write) 826000 826148 148 0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 586308 586338 30 0.0

@yunhanw-google yunhanw-google force-pushed the feature/fix_command_handler_status_response branch from 3e0c88c to 954baec Compare August 11, 2022 15:36
@github-actions
Copy link

github-actions bot commented Aug 11, 2022 •
edited
Loading

PR #21557: Size comparison from 1845133 to 954baec

Increases (36 builds for cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, p6, telink)
platform target config section 1845133 954baec change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180024 180040 16 0.0
lock-ftd LP_CC2652R7 (read/write) 168468 168484 16 0.0
lock-mtd LP_CC2652R7 (read/write) 181548 181556 8 0.0
.rodata 101451 101459 8 0.0
pump-app LP_CC2652R7 (read only) 683355 683491 136 0.0
.rodata 89395 89515 120 0.1
.text 593476 593492 16 0.0
pump-controller-app LP_CC2652R7 (read only) 667807 667951 144 0.0
.rodata 84943 85063 120 0.1
.text 582384 582408 24 0.0
shell LP_CC2652R7 (read/write) 182860 182876 16 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 597642 597786 144 0.0
.app_xip_area 475148 475292 144 0.0
efr32 lighting-app BRD4161A (read/write) 1097340 1097500 160 0.0
.text 962388 962548 160 0.0
BRD4161A+rpc (read/write) 1151604 1151764 160 0.0
.text 999756 999916 160 0.0
BRD4161A+rs911x (read/write) 986748 986916 168 0.0
.text 822472 822640 168 0.0
lock-app BRD4161A+wf200 (read/write) 1137068 1137196 128 0.0
.text 990144 990272 128 0.0
window-app BRD4161A (read/write) 1088776 1088936 160 0.0
.text 952368 952528 160 0.0
esp32 all-clusters-app c3devkit (read only) 1026542 1026572 30 0.0
(read/write) 1487570 1487682 112 0.0
.flash.rodata 217168 217280 112 0.1
.flash.text 1026542 1026572 30 0.0
m5stack (read/write) 489528 489640 112 0.0
.flash.rodata 247524 247636 112 0.0
linux all-clusters-app debug .rodata 273643 273771 128 0.0
all-clusters-minimal-app debug .rodata 273803 273899 96 0.0
bridge-app debug+rpc .rodata 202600 202728 128 0.1
chip-tool debug .rodata 552373 552501 128 0.0
chip-tool-ipv6only arm64 (read only) 10067164 10067356 192 0.0
.rodata 482780 482924 144 0.0
.text 7947540 7947588 48 0.0
lighting-app debug+rpc .rodata 219376 219504 128 0.1
lock-app debug .rodata 236496 236592 96 0.0
ota-provider-app debug .rodata 208440 208568 128 0.1
ota-requestor-app debug .rodata 215168 215296 128 0.1
shell debug .rodata 233778 233906 128 0.1
thermostat-no-ble arm64 (read only) 2352012 2352204 192 0.0
.rodata 139828 139972 144 0.1
.text 1974656 1974704 48 0.0
tv-app debug .rodata 258376 258504 128 0.0
tv-casting-app debug .rodata 341649 341777 128 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452976 2453072 96 0.0
.text 1415620 1415716 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1178535 1178679 144 0.0
rodata 142888 143000 112 0.1
text 813580 813608 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1158555 1158703 148 0.0
rodata 134580 134696 116 0.1
text 802568 802596 28 0.0
p6 all-clusters-app default (read/write) 1694516 1694676 160 0.0
.text 1534296 1534456 160 0.0
all-clusters-minimal-app default (read/write) 1638556 1638716 160 0.0
.text 1479056 1479216 160 0.0
light-app default (read/write) 1557244 1557388 144 0.0
.text 1406064 1406208 144 0.0
lock-app default (read/write) 1594412 1594556 144 0.0
.text 1438736 1438880 144 0.0
telink light-switch-app tlsr9518adk80d (read/write) 806648 806796 148 0.0
text 570244 570276 32 0.0
lighting-app tlsr9518adk80d (read/write) 828576 828724 148 0.0
text 588322 588354 32 0.0
Decreases (25 builds for bl602, cc13x2_26x2, cyw30739, esp32, k32w, linux)
platform target config section 1845133 954baec change % change
bl602 lighting-app bl602 (read/write) 1380642 1380634 -8 -0.0
.text 1048712 1048708 -4 -0.0
bl602+rpc .text 1080212 1080208 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 671367 671351 -16 -0.0
.text 582492 582476 -16 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636759 636743 -16 -0.0
.text 558620 558604 -16 -0.0
lock-ftd LP_CC2652R7 (read only) 673115 673099 -16 -0.0
.text 596136 596120 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 655723 655715 -8 -0.0
.text 553792 553776 -16 -0.0
pump-app LP_CC2652R7 (read/write) 159036 158900 -136 -0.1
pump-controller-app LP_CC2652R7 (read/write) 174704 174560 -144 -0.1
shell LP_CC2652R7 (read only) 664050 664034 -16 -0.0
.text 578228 578212 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585166 585150 -16 -0.0
.app_xip_area 461952 461936 -16 -0.0
lock cyw930739m2evb_01 (read/write) 590966 590950 -16 -0.0
.app_xip_area 462968 462952 -16 -0.0
esp32 all-clusters-app m5stack (read only) 1079875 1079859 -16 -0.0
.flash.text 1074491 1074475 -16 -0.0
k32w light k32w0+release (read/write) 644076 644060 -16 -0.0
.text 569576 569560 -16 -0.0
lock k32w0+release (read/write) 701364 701340 -24 -0.0
.text 626384 626360 -24 -0.0
linux all-clusters-app debug (read only) 3028281 3028105 -176 -0.0
.text 2575682 2575378 -304 -0.0
all-clusters-minimal-app debug (read only) 2868105 2867897 -208 -0.0
.text 2418050 2417746 -304 -0.0
bridge-app debug+rpc (read only) 2366929 2366753 -176 -0.0
.text 2001826 2001522 -304 -0.0
chip-tool debug (read only) 10657601 10657425 -176 -0.0
.text 8599460 8599156 -304 -0.0
lighting-app debug+rpc (read only) 2590945 2590769 -176 -0.0
.text 2200978 2200674 -304 -0.0
lock-app debug (read only) 2574921 2574713 -208 -0.0
.text 2171890 2171586 -304 -0.0
ota-provider-app debug (read only) 2352049 2351873 -176 -0.0
.text 1980258 1979954 -304 -0.0
ota-requestor-app debug (read only) 2517745 2517569 -176 -0.0
.text 2130130 2129826 -304 -0.0
shell debug (read only) 2596601 2596425 -176 -0.0
.text 2204594 2204290 -304 -0.0
tv-app debug (read only) 3170361 3170185 -176 -0.0
.text 2722194 2721890 -304 -0.0
tv-casting-app debug (read only) 5411049 5410873 -176 -0.0
.text 4801074 4800770 -304 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1845133 954baec change % change
bl602 lighting-app bl602 (read/write) 1380642 1380634 -8 -0.0
.bss 119762 119762 0 0.0
.data 4480 4480 0 0.0
.text 1048712 1048708 -4 -0.0
bl602+rpc (read/write) 1425890 1425890 0 0.0
.bss 127202 127202 0 0.0
.data 4600 4600 0 0.0
.text 1080212 1080208 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 671367 671351 -16 -0.0
(read/write) 180024 180040 16 0.0
.bss 74284 74284 0 0.0
.data 3372 3372 0 0.0
.rodata 88559 88559 0 0.0
.text 582492 582476 -16 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636759 636743 -16 -0.0
(read/write) 157860 157860 0 0.0
.bss 73572 73572 0 0.0
.data 3372 3372 0 0.0
.rodata 77815 77815 0 0.0
.text 558620 558604 -16 -0.0
lock-ftd LP_CC2652R7 (read only) 673115 673099 -16 -0.0
(read/write) 168468 168484 16 0.0
.bss 71364 71364 0 0.0
.data 3296 3296 0 0.0
.rodata 76499 76499 0 0.0
.text 596136 596120 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 655723 655715 -8 -0.0
(read/write) 181548 181556 8 0.0
.bss 67052 67052 0 0.0
.data 3296 3296 0 0.0
.rodata 101451 101459 8 0.0
.text 553792 553776 -16 -0.0
pump-app LP_CC2652R7 (read only) 683355 683491 136 0.0
(read/write) 159036 158900 -136 -0.1
.bss 71404 71404 0 0.0
.data 3296 3296 0 0.0
.rodata 89395 89515 120 0.1
.text 593476 593492 16 0.0
pump-controller-app LP_CC2652R7 (read only) 667807 667951 144 0.0
(read/write) 174704 174560 -144 -0.1
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84943 85063 120 0.1
.text 582384 582408 24 0.0
shell LP_CC2652R7 (read only) 664050 664034 -16 -0.0
(read/write) 182860 182876 16 0.0
.bss 76604 76604 0 0.0
.data 3376 3376 0 0.0
.rodata 85506 85506 0 0.0
.text 578228 578212 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585166 585150 -16 -0.0
.app_xip_area 461952 461936 -16 -0.0
.bss 65656 65656 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590966 590950 -16 -0.0
.app_xip_area 462968 462952 -16 -0.0
.bss 70440 70440 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 597642 597786 144 0.0
.app_xip_area 475148 475292 144 0.0
.bss 64968 64968 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1097340 1097500 160 0.0
.bss 132860 132860 0 0.0
.data 2068 2068 0 0.0
.text 962388 962548 160 0.0
BRD4161A+rpc (read/write) 1151604 1151764 160 0.0
.bss 149548 149548 0 0.0
.data 2280 2280 0 0.0
.text 999756 999916 160 0.0
BRD4161A+rs911x (read/write) 986748 986916 168 0.0
.bss 162200 162200 0 0.0
.data 2056 2056 0 0.0
.text 822472 822640 168 0.0
lock-app BRD4161A+wf200 (read/write) 1137068 1137196 128 0.0
.bss 144840 144840 0 0.0
.data 2064 2064 0 0.0
.text 990144 990272 128 0.0
window-app BRD4161A (read/write) 1088776 1088936 160 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 952368 952528 160 0.0
esp32 all-clusters-app c3devkit (read only) 1026542 1026572 30 0.0
(read/write) 1487570 1487682 112 0.0
.dram0.bss 70360 70360 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217168 217280 112 0.1
.flash.text 1026542 1026572 30 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079875 1079859 -16 -0.0
(read/write) 489528 489640 112 0.0
.dram0.bss 75864 75864 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247524 247636 112 0.0
.flash.text 1074491 1074475 -16 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 644076 644060 -16 -0.0
.bss 69728 69728 0 0.0
.data 2044 2044 0 0.0
.text 569576 569560 -16 -0.0
lock k32w0+release (read/write) 701364 701340 -24 -0.0
.bss 70200 70200 0 0.0
.data 2052 2052 0 0.0
.text 626384 626360 -24 -0.0
linux all-clusters-app debug (read only) 3028281 3028105 -176 -0.0
(read/write) 155760 155760 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85416 85416 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 273643 273771 128 0.0
.text 2575682 2575378 -304 -0.0
all-clusters-minimal-app debug (read only) 2868105 2867897 -208 -0.0
(read/write) 147496 147496 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78008 78008 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 273803 273899 96 0.0
.text 2418050 2417746 -304 -0.0
bridge-app debug+rpc (read only) 2366929 2366753 -176 -0.0
(read/write) 127456 127456 0 0.0
.bss 50624 50624 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67368 67368 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202600 202728 128 0.1
.text 2001826 2001522 -304 -0.0
chip-tool debug (read only) 10657601 10657425 -176 -0.0
(read/write) 650432 650432 0 0.0
.bss 24856 24856 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 615784 615784 0 0.0
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 552373 552501 128 0.0
.text 8599460 8599156 -304 -0.0
chip-tool-ipv6only arm64 (read only) 10067164 10067356 192 0.0
(read/write) 698177 698177 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643344 643344 0 0.0
.dynamic 560 560 0 0.0
.got 13688 13688 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 482780 482924 144 0.0
.text 7947540 7947588 48 0.0
lighting-app debug+rpc (read only) 2590945 2590769 -176 -0.0
(read/write) 130048 130048 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 219376 219504 128 0.1
.text 2200978 2200674 -304 -0.0
lock-app debug (read only) 2574921 2574713 -208 -0.0
(read/write) 125416 125416 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69416 69416 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 236496 236592 96 0.0
.text 2171890 2171586 -304 -0.0
ota-provider-app debug (read only) 2352049 2351873 -176 -0.0
(read/write) 118848 118848 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63224 63224 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 208440 208568 128 0.1
.text 1980258 1979954 -304 -0.0
ota-requestor-app debug (read only) 2517745 2517569 -176 -0.0
(read/write) 127192 127192 0 0.0
.bss 50304 50304 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68632 68632 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 215168 215296 128 0.1
.text 2130130 2129826 -304 -0.0
shell debug (read only) 2596601 2596425 -176 -0.0
(read/write) 141912 141912 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77024 77024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 233778 233906 128 0.1
.text 2204594 2204290 -304 -0.0
thermostat-no-ble arm64 (read only) 2352012 2352204 192 0.0
(read/write) 141681 141681 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75880 75880 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139828 139972 144 0.1
.text 1974656 1974704 48 0.0
tv-app debug (read only) 3170361 3170185 -176 -0.0
(read/write) 257872 257872 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 258376 258504 128 0.0
.text 2722194 2721890 -304 -0.0
tv-casting-app debug (read only) 5411049 5410873 -176 -0.0
(read/write) 158992 158992 0 0.0
.bss 51448 51448 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98672 98672 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 341649 341777 128 0.0
.text 4801074 4800770 -304 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452976 2453072 96 0.0
.bss 214572 214572 0 0.0
.data 5872 5872 0 0.0
.text 1415620 1415716 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1178535 1178679 144 0.0
bss 143230 143230 0 0.0
rodata 142888 143000 112 0.1
text 813580 813608 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1158555 1158703 148 0.0
bss 142468 142468 0 0.0
rodata 134580 134696 116 0.1
text 802568 802596 28 0.0
p6 all-clusters-app default (read only) 881512 881512 0 0.0
(read/write) 1694516 1694676 160 0.0
.bss 149176 149176 0 0.0
.data 2656 2656 0 0.0
.text 1534296 1534456 160 0.0
all-clusters-minimal-app default (read only) 882232 882232 0 0.0
(read/write) 1638556 1638716 160 0.0
.bss 148456 148456 0 0.0
.data 2656 2656 0 0.0
.text 1479056 1479216 160 0.0
light-app default (read only) 890552 890552 0 0.0
(read/write) 1557244 1557388 144 0.0
.bss 140344 140344 0 0.0
.data 2448 2448 0 0.0
.text 1406064 1406208 144 0.0
lock-app default (read only) 886056 886056 0 0.0
(read/write) 1594412 1594556 144 0.0
.bss 144824 144824 0 0.0
.data 2464 2464 0 0.0
.text 1438736 1438880 144 0.0
telink light-switch-app tlsr9518adk80d (read/write) 806648 806796 148 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 570244 570276 32 0.0
lighting-app tlsr9518adk80d (read/write) 828576 828724 148 0.0
bss 71832 71832 0 0.0
noinit 43488 43488 0 0.0
text 588322 588354 32 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Aug 11, 2022
View reviewed changes
src/app/CommandHandler.cpp Show resolved Hide resolved
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.cpp Show resolved Hide resolved
src/app/tests/TestCommandInteraction.cpp Outdated Show resolved Hide resolved
src/app/tests/TestCommandInteraction.cpp Outdated Show resolved Hide resolved
@yunhanw-google yunhanw-google mentioned this pull request Aug 11, 2022
Closed
@yunhanw-google
Fix status response in command handler.
8774fde 
When there is issue in incoming request, OnInvokeCommandRequest in
CommandRequest would send status response.
@yunhanw-google yunhanw-google force-pushed the feature/fix_command_handler_status_response branch from 541f8eb to 8774fde Compare August 11, 2022 21:19
@github-actions
Copy link

github-actions bot commented Aug 11, 2022 •
edited
Loading

PR #21557: Size comparison from 92a3c2c to 8774fde

Increases (37 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, p6, telink)
platform target config section 92a3c2c 8774fde change % change
bl602 lighting-app bl602+rpc .text 1080208 1080212 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180024 180048 24 0.0
lock-ftd LP_CC2652R7 (read/write) 168468 168492 24 0.0
lock-mtd LP_CC2652R7 (read/write) 181548 181556 8 0.0
.rodata 101451 101459 8 0.0
pump-app LP_CC2652R7 (read only) 683347 683499 152 0.0
.rodata 89395 89515 120 0.1
.text 593468 593500 32 0.0
pump-controller-app LP_CC2652R7 (read only) 667807 667951 144 0.0
.rodata 84943 85063 120 0.1
.text 582384 582408 24 0.0
shell LP_CC2652R7 (read/write) 182860 182884 24 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 597642 597778 136 0.0
.app_xip_area 475148 475284 136 0.0
efr32 lighting-app BRD4161A (read/write) 1097340 1097500 160 0.0
.text 962388 962548 160 0.0
BRD4161A+rpc (read/write) 1151604 1151764 160 0.0
.text 999756 999916 160 0.0
BRD4161A+rs911x (read/write) 986748 986916 168 0.0
.text 822472 822640 168 0.0
lock-app BRD4161A+wf200 (read/write) 1137068 1137180 112 0.0
.text 990144 990256 112 0.0
window-app BRD4161A (read/write) 1088776 1088936 160 0.0
.text 952368 952528 160 0.0
esp32 all-clusters-app c3devkit (read only) 1026544 1026568 24 0.0
(read/write) 1487570 1487682 112 0.0
.flash.rodata 217168 217280 112 0.1
.flash.text 1026544 1026568 24 0.0
m5stack (read/write) 489528 489640 112 0.0
.flash.rodata 247524 247636 112 0.0
linux all-clusters-app debug .rodata 273643 273771 128 0.0
all-clusters-minimal-app debug .rodata 273803 273899 96 0.0
bridge-app debug+rpc .rodata 202600 202728 128 0.1
chip-tool debug .rodata 551861 551989 128 0.0
chip-tool-ipv6only arm64 (read only) 10067292 10067484 192 0.0
.rodata 482892 483036 144 0.0
.text 7947476 7947524 48 0.0
lighting-app debug+rpc .rodata 219376 219504 128 0.1
lock-app debug .rodata 236496 236592 96 0.0
ota-provider-app debug .rodata 208440 208568 128 0.1
ota-requestor-app debug .rodata 215168 215296 128 0.1
shell debug .rodata 233778 233906 128 0.1
thermostat-no-ble arm64 (read only) 2352012 2352204 192 0.0
.rodata 139828 139972 144 0.1
.text 1974656 1974704 48 0.0
tv-app debug .rodata 258376 258504 128 0.0
tv-casting-app debug .rodata 341649 341777 128 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2452976 2453072 96 0.0
.text 1415620 1415716 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1178535 1178663 128 0.0
rodata 142888 143000 112 0.1
text 813580 813600 20 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1158555 1158687 132 0.0
rodata 134580 134696 116 0.1
text 802568 802588 20 0.0
p6 all-clusters-app default (read/write) 1694516 1694676 160 0.0
.text 1534296 1534456 160 0.0
all-clusters-minimal-app default (read/write) 1638556 1638716 160 0.0
.text 1479056 1479216 160 0.0
light-app default (read/write) 1557244 1557388 144 0.0
.text 1406064 1406208 144 0.0
lock-app default (read/write) 1594412 1594556 144 0.0
.text 1438736 1438880 144 0.0
telink light-switch-app tlsr9518adk80d (read/write) 806648 806796 148 0.0
text 570242 570276 34 0.0
lighting-app tlsr9518adk80d (read/write) 828576 828724 148 0.0
text 588318 588354 36 0.0
Decreases (23 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux)
platform target config section 92a3c2c 8774fde change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 671367 671343 -24 -0.0
.text 582492 582468 -24 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636759 636735 -24 -0.0
.text 558620 558596 -24 -0.0
lock-ftd LP_CC2652R7 (read only) 673115 673091 -24 -0.0
.text 596136 596112 -24 -0.0
lock-mtd LP_CC2652R7 (read only) 655723 655715 -8 -0.0
.text 553792 553776 -16 -0.0
pump-app LP_CC2652R7 (read/write) 159044 158892 -152 -0.1
pump-controller-app LP_CC2652R7 (read/write) 174704 174560 -144 -0.1
shell LP_CC2652R7 (read only) 664050 664026 -24 -0.0
.text 578228 578204 -24 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585166 585142 -24 -0.0
.app_xip_area 461952 461928 -24 -0.0
lock cyw930739m2evb_01 (read/write) 590966 590950 -16 -0.0
.app_xip_area 462968 462952 -16 -0.0
esp32 all-clusters-app m5stack (read only) 1079875 1079851 -24 -0.0
.flash.text 1074491 1074467 -24 -0.0
k32w light k32w0+release (read/write) 644076 644044 -32 -0.0
.text 569576 569544 -32 -0.0
lock k32w0+release (read/write) 701364 701340 -24 -0.0
.text 626384 626360 -24 -0.0
linux all-clusters-app debug (read only) 3028281 3028105 -176 -0.0
.text 2575682 2575378 -304 -0.0
all-clusters-minimal-app debug (read only) 2868105 2867897 -208 -0.0
.text 2418050 2417746 -304 -0.0
bridge-app debug+rpc (read only) 2366929 2366753 -176 -0.0
.text 2001826 2001522 -304 -0.0
chip-tool debug (read only) 10656625 10656449 -176 -0.0
.text 8598996 8598692 -304 -0.0
lighting-app debug+rpc (read only) 2590945 2590769 -176 -0.0
.text 2200978 2200674 -304 -0.0
lock-app debug (read only) 2574921 2574713 -208 -0.0
.text 2171890 2171586 -304 -0.0
ota-provider-app debug (read only) 2352049 2351873 -176 -0.0
.text 1980258 1979954 -304 -0.0
ota-requestor-app debug (read only) 2517745 2517569 -176 -0.0
.text 2130130 2129826 -304 -0.0
shell debug (read only) 2596601 2596425 -176 -0.0
.text 2204594 2204290 -304 -0.0
tv-app debug (read only) 3170361 3170185 -176 -0.0
.text 2722194 2721890 -304 -0.0
tv-casting-app debug (read only) 5410809 5410649 -160 -0.0
.text 4800834 4800546 -288 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 92a3c2c 8774fde change % change
bl602 lighting-app bl602 (read/write) 1380634 1380634 0 0.0
.bss 119762 119762 0 0.0
.data 4480 4480 0 0.0
.text 1048708 1048708 0 0.0
bl602+rpc (read/write) 1425890 1425890 0 0.0
.bss 127202 127202 0 0.0
.data 4600 4600 0 0.0
.text 1080208 1080212 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 671367 671343 -24 -0.0
(read/write) 180024 180048 24 0.0
.bss 74284 74284 0 0.0
.data 3372 3372 0 0.0
.rodata 88559 88559 0 0.0
.text 582492 582468 -24 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636759 636735 -24 -0.0
(read/write) 157860 157860 0 0.0
.bss 73572 73572 0 0.0
.data 3372 3372 0 0.0
.rodata 77815 77815 0 0.0
.text 558620 558596 -24 -0.0
lock-ftd LP_CC2652R7 (read only) 673115 673091 -24 -0.0
(read/write) 168468 168492 24 0.0
.bss 71364 71364 0 0.0
.data 3296 3296 0 0.0
.rodata 76499 76499 0 0.0
.text 596136 596112 -24 -0.0
lock-mtd LP_CC2652R7 (read only) 655723 655715 -8 -0.0
(read/write) 181548 181556 8 0.0
.bss 67052 67052 0 0.0
.data 3296 3296 0 0.0
.rodata 101451 101459 8 0.0
.text 553792 553776 -16 -0.0
pump-app LP_CC2652R7 (read only) 683347 683499 152 0.0
(read/write) 159044 158892 -152 -0.1
.bss 71404 71404 0 0.0
.data 3296 3296 0 0.0
.rodata 89395 89515 120 0.1
.text 593468 593500 32 0.0
pump-controller-app LP_CC2652R7 (read only) 667807 667951 144 0.0
(read/write) 174704 174560 -144 -0.1
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84943 85063 120 0.1
.text 582384 582408 24 0.0
shell LP_CC2652R7 (read only) 664050 664026 -24 -0.0
(read/write) 182860 182884 24 0.0
.bss 76604 76604 0 0.0
.data 3376 3376 0 0.0
.rodata 85506 85506 0 0.0
.text 578228 578204 -24 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585166 585142 -24 -0.0
.app_xip_area 461952 461928 -24 -0.0
.bss 65656 65656 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590966 590950 -16 -0.0
.app_xip_area 462968 462952 -16 -0.0
.bss 70440 70440 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 597642 597778 136 0.0
.app_xip_area 475148 475284 136 0.0
.bss 64968 64968 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1097340 1097500 160 0.0
.bss 132860 132860 0 0.0
.data 2068 2068 0 0.0
.text 962388 962548 160 0.0
BRD4161A+rpc (read/write) 1151604 1151764 160 0.0
.bss 149548 149548 0 0.0
.data 2280 2280 0 0.0
.text 999756 999916 160 0.0
BRD4161A+rs911x (read/write) 986748 986916 168 0.0
.bss 162200 162200 0 0.0
.data 2056 2056 0 0.0
.text 822472 822640 168 0.0
lock-app BRD4161A+wf200 (read/write) 1137068 1137180 112 0.0
.bss 144840 144840 0 0.0
.data 2064 2064 0 0.0
.text 990144 990256 112 0.0
window-app BRD4161A (read/write) 1088776 1088936 160 0.0
.bss 134292 134292 0 0.0
.data 2096 2096 0 0.0
.text 952368 952528 160 0.0
esp32 all-clusters-app c3devkit (read only) 1026544 1026568 24 0.0
(read/write) 1487570 1487682 112 0.0
.dram0.bss 70360 70360 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 217168 217280 112 0.1
.flash.text 1026544 1026568 24 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1079875 1079851 -24 -0.0
(read/write) 489528 489640 112 0.0
.dram0.bss 75864 75864 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247524 247636 112 0.0
.flash.text 1074491 1074467 -24 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 644076 644044 -32 -0.0
.bss 69728 69728 0 0.0
.data 2044 2044 0 0.0
.text 569576 569544 -32 -0.0
lock k32w0+release (read/write) 701364 701340 -24 -0.0
.bss 70200 70200 0 0.0
.data 2052 2052 0 0.0
.text 626384 626360 -24 -0.0
linux all-clusters-app debug (read only) 3028281 3028105 -176 -0.0
(read/write) 155760 155760 0 0.0
.bss 61888 61888 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85416 85416 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 273643 273771 128 0.0
.text 2575682 2575378 -304 -0.0
all-clusters-minimal-app debug (read only) 2868105 2867897 -208 -0.0
(read/write) 147496 147496 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78008 78008 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 273803 273899 96 0.0
.text 2418050 2417746 -304 -0.0
bridge-app debug+rpc (read only) 2366929 2366753 -176 -0.0
(read/write) 127456 127456 0 0.0
.bss 50624 50624 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67368 67368 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202600 202728 128 0.1
.text 2001826 2001522 -304 -0.0
chip-tool debug (read only) 10656625 10656449 -176 -0.0
(read/write) 650816 650816 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 615784 615784 0 0.0
.dynamic 608 608 0 0.0
.got 5104 5104 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 551861 551989 128 0.0
.text 8598996 8598692 -304 -0.0
chip-tool-ipv6only arm64 (read only) 10067292 10067484 192 0.0
(read/write) 698577 698577 0 0.0
.bss 33281 33281 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643344 643344 0 0.0
.dynamic 560 560 0 0.0
.got 13712 13712 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 482892 483036 144 0.0
.text 7947476 7947524 48 0.0
lighting-app debug+rpc (read only) 2590945 2590769 -176 -0.0
(read/write) 130048 130048 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 219376 219504 128 0.1
.text 2200978 2200674 -304 -0.0
lock-app debug (read only) 2574921 2574713 -208 -0.0
(read/write) 125416 125416 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69416 69416 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 236496 236592 96 0.0
.text 2171890 2171586 -304 -0.0
ota-provider-app debug (read only) 2352049 2351873 -176 -0.0
(read/write) 118848 118848 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63224 63224 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 208440 208568 128 0.1
.text 1980258 1979954 -304 -0.0
ota-requestor-app debug (read only) 2517745 2517569 -176 -0.0
(read/write) 127192 127192 0 0.0
.bss 50304 50304 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68632 68632 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 215168 215296 128 0.1
.text 2130130 2129826 -304 -0.0
shell debug (read only) 2596601 2596425 -176 -0.0
(read/write) 141912 141912 0 0.0
.bss 57800 57800 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77024 77024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 233778 233906 128 0.1
.text 2204594 2204290 -304 -0.0
thermostat-no-ble arm64 (read only) 2352012 2352204 192 0.0
(read/write) 141681 141681 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75880 75880 0 0.0
.dynamic 560 560 0 0.0
.got 5040 5040 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139828 139972 144 0.1
.text 1974656 1974704 48 0.0
tv-app debug (read only) 3170361 3170185 -176 -0.0
(read/write) 257872 257872 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79096 79096 0 0.0
.dynamic 608 608 0 0.0
.got 4864 4864 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 258376 258504 128 0.0
.text 2722194 2721890 -304 -0.0
tv-casting-app debug (read only) 5410809 5410649 -160 -0.0
(read/write) 158992 158992 0 0.0
.bss 51448 51448 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98672 98672 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 341649 341777 128 0.0
.text 4800834 4800546 -288 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452976 2453072 96 0.0
.bss 214572 214572 0 0.0
.data 5872 5872 0 0.0
.text 1415620 1415716 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1178535 1178663 128 0.0
bss 143230 143230 0 0.0
rodata 142888 143000 112 0.1
text 813580 813600 20 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1158555 1158687 132 0.0
bss 142468 142468 0 0.0
rodata 134580 134696 116 0.1
text 802568 802588 20 0.0
p6 all-clusters-app default (read only) 881512 881512 0 0.0
(read/write) 1694516 1694676 160 0.0
.bss 149176 149176 0 0.0
.data 2656 2656 0 0.0
.text 1534296 1534456 160 0.0
all-clusters-minimal-app default (read only) 882232 882232 0 0.0
(read/write) 1638556 1638716 160 0.0
.bss 148456 148456 0 0.0
.data 2656 2656 0 0.0
.text 1479056 1479216 160 0.0
light-app default (read only) 890552 890552 0 0.0
(read/write) 1557244 1557388 144 0.0
.bss 140344 140344 0 0.0
.data 2448 2448 0 0.0
.text 1406064 1406208 144 0.0
lock-app default (read only) 886056 886056 0 0.0
(read/write) 1594412 1594556 144 0.0
.bss 144824 144824 0 0.0
.data 2464 2464 0 0.0
.text 1438736 1438880 144 0.0
telink light-switch-app tlsr9518adk80d (read/write) 806648 806796 148 0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 570242 570276 34 0.0
lighting-app tlsr9518adk80d (read/write) 828576 828724 148 0.0
bss 71832 71832 0 0.0
noinit 43488 43488 0 0.0
text 588318 588354 36 0.0

@yunhanw-google yunhanw-google enabled auto-merge (squash) August 11, 2022 22:06
@yunhanw-google yunhanw-google merged commit 7347f9b into project-chip:master Aug 11, 2022
@yunhanw-google yunhanw-google mentioned this pull request Aug 11, 2022
Closed
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@yunhanw-google @isiu-apple
Fix status response in command handler. (project-chip#21557)
a89a39a 
When there is issue in incoming request, OnInvokeCommandRequest in
CommandRequest would send status response.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunhanw-google @yufengwangca @bzbarsky-apple