fix: let static_assert fail with the provided message #7005

asterite · 2025-01-09T15:33:18Z

Description

Problem

Resolves #6995

Summary

Additional Context

Documentation

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions · 2025-01-09T15:38:44Z

Execution Report

Program	Execution Time	%
sha256_regression	0.054s	0%
regression_4709	0.001s	0%
ram_blowup_regression	0.573s	0%
rollup-root	0.106s	-3%
rollup-block-merge	0.105s	0%
rollup-base-public	1.234s	2%
rollup-base-private	0.461s	0%
private-kernel-tail	0.021s	0%
private-kernel-reset	0.347s	-1%
private-kernel-inner	0.077s	-7%

github-actions · 2025-01-09T15:38:45Z

Compilation Report

Program	Compilation Time	%
sha256_regression	1.272s	-3%
regression_4709	0.780s	-3%
ram_blowup_regression	18.340s	-1%
rollup-root	3.468s	-4%
rollup-block-merge	3.570s	4%
rollup-base-public	38.320s	10%
rollup-base-private	11.960s	-2%
private-kernel-tail	0.974s	0%
private-kernel-reset	8.326s	-1%
private-kernel-inner	2.146s	-6%

github-actions · 2025-01-09T15:39:55Z

Compilation Memory Report

Program	Peak Memory
keccak256	78.12M
workspace	123.88M
regression_4709	422.97M
ram_blowup_regression	1.58G
rollup-base-public	4.11G
rollup-base-private	1.20G
private-kernel-tail	207.18M
private-kernel-reset	730.60M
private-kernel-inner	294.41M

github-actions · 2025-01-09T15:39:56Z

Execution Memory Report

Program	Peak Memory
keccak256	74.67M
workspace	123.83M
regression_4709	315.99M
ram_blowup_regression	512.41M
rollup-base-public	480.67M
rollup-base-private	326.53M
private-kernel-tail	181.03M
private-kernel-reset	249.70M
private-kernel-inner	209.87M

compiler/noirc_evaluator/src/ssa/ir/printer.rs

compiler/noirc_evaluator/src/ssa/ir/dfg.rs

Co-authored-by: jfecher <[email protected]>

chore: delete docs for versions which aren't used (noir-lang/noir#7020) feat!: Disable mocks in `execute` (noir-lang/noir#6869) chore(docs): backport 1.0.0-beta.0 doc fixes (noir-lang/noir#7014) feat(cli): Add CLI option to filter by contract function name (noir-lang/noir#7018) chore: Add more Field use info (noir-lang/noir#7019) fix: let static_assert fail with the provided message (noir-lang/noir#7005) chore: mark `aztec-nr` as expected to compile (noir-lang/noir#7015) chore: clarity fix in docs (noir-lang/noir#7016) fix: require generic trait impls to be in scope to call them (noir-lang/noir#6913) feat!: require trait primitive functions/calls to have their trait in scope (noir-lang/noir#6901) feat(lsp): use trait method docs for trait impl method docs on hover (noir-lang/noir#7003) chore: turn on averaging for protocol circuits metrics in CI (noir-lang/noir#6999) feat(comptime): Implement to_be_bits and to_le_bits in the interpreter (noir-lang/noir#7008) chore: Add short circuit in ssa-gen for known if conditions (noir-lang/noir#7007) chore: Only resolved globals monomorphization (noir-lang/noir#7006) chore: Remove resolve_is_unconstrained pass (noir-lang/noir#7004) chore: require safety doc comment for unsafe instead of `//@safety` (noir-lang/noir#6992) fix: Reproduce and fix bytecode blowup (noir-lang/noir#6972) chore: mark casts as able to be deduplicated (noir-lang/noir#6996) fix: return trait impl method as FuncId if there's only one (noir-lang/noir#6989) chore(ci): fail properly in `external-repo-checks` (noir-lang/noir#6988) fix: allow multiple trait impls for the same trait as long as one is in scope (noir-lang/noir#6987) chore: Use DFG in SSA printer (noir-lang/noir#6986) chore!: Reserve `enum` and `match` keywords (noir-lang/noir#6961)

* master: chore: simplify a couple of enum variants (#7025) chore: disallow inserting ACIR-only instructions into brillig functions (#7017) feat: unchecked math operations in SSA (#7011) chore: delete docs for versions which aren't used (#7020) feat!: Disable mocks in `execute` (#6869) chore(docs): backport 1.0.0-beta.0 doc fixes (#7014) feat(cli): Add CLI option to filter by contract function name (#7018) chore: Add more Field use info (#7019) fix: let static_assert fail with the provided message (#7005) chore: mark `aztec-nr` as expected to compile (#7015) chore: clarity fix in docs (#7016)

…ang/noir#6985) feat!: disallow calling unconstrained functions outside of `unsafe` blocks and passing unconstrained functions in place of constrained functions (noir-lang/noir#6938) chore: simplify a couple of enum variants (noir-lang/noir#7025) chore: disallow inserting ACIR-only instructions into brillig functions (noir-lang/noir#7017) feat: unchecked math operations in SSA (noir-lang/noir#7011) chore: delete docs for versions which aren't used (noir-lang/noir#7020) feat!: Disable mocks in `execute` (noir-lang/noir#6869) chore(docs): backport 1.0.0-beta.0 doc fixes (noir-lang/noir#7014) feat(cli): Add CLI option to filter by contract function name (noir-lang/noir#7018) chore: Add more Field use info (noir-lang/noir#7019) fix: let static_assert fail with the provided message (noir-lang/noir#7005) chore: mark `aztec-nr` as expected to compile (noir-lang/noir#7015) chore: clarity fix in docs (noir-lang/noir#7016) fix: require generic trait impls to be in scope to call them (noir-lang/noir#6913) feat!: require trait primitive functions/calls to have their trait in scope (noir-lang/noir#6901) feat(lsp): use trait method docs for trait impl method docs on hover (noir-lang/noir#7003) chore: turn on averaging for protocol circuits metrics in CI (noir-lang/noir#6999) feat(comptime): Implement to_be_bits and to_le_bits in the interpreter (noir-lang/noir#7008) chore: Add short circuit in ssa-gen for known if conditions (noir-lang/noir#7007) chore: Only resolved globals monomorphization (noir-lang/noir#7006) chore: Remove resolve_is_unconstrained pass (noir-lang/noir#7004) chore: require safety doc comment for unsafe instead of `//@safety` (noir-lang/noir#6992) fix: Reproduce and fix bytecode blowup (noir-lang/noir#6972) chore: mark casts as able to be deduplicated (noir-lang/noir#6996) fix: return trait impl method as FuncId if there's only one (noir-lang/noir#6989) chore(ci): fail properly in `external-repo-checks` (noir-lang/noir#6988) fix: allow multiple trait impls for the same trait as long as one is in scope (noir-lang/noir#6987) chore: Use DFG in SSA printer (noir-lang/noir#6986) chore!: Reserve `enum` and `match` keywords (noir-lang/noir#6961)

feat!: disallow calling unconstrained functions outside of `unsafe` blocks and passing unconstrained functions in place of constrained functions (noir-lang/noir#6938) chore: simplify a couple of enum variants (noir-lang/noir#7025) chore: disallow inserting ACIR-only instructions into brillig functions (noir-lang/noir#7017) feat: unchecked math operations in SSA (noir-lang/noir#7011) chore: delete docs for versions which aren't used (noir-lang/noir#7020) feat!: Disable mocks in `execute` (noir-lang/noir#6869) chore(docs): backport 1.0.0-beta.0 doc fixes (noir-lang/noir#7014) feat(cli): Add CLI option to filter by contract function name (noir-lang/noir#7018) chore: Add more Field use info (noir-lang/noir#7019) fix: let static_assert fail with the provided message (noir-lang/noir#7005) chore: mark `aztec-nr` as expected to compile (noir-lang/noir#7015) chore: clarity fix in docs (noir-lang/noir#7016) fix: require generic trait impls to be in scope to call them (noir-lang/noir#6913) feat!: require trait primitive functions/calls to have their trait in scope (noir-lang/noir#6901) feat(lsp): use trait method docs for trait impl method docs on hover (noir-lang/noir#7003) chore: turn on averaging for protocol circuits metrics in CI (noir-lang/noir#6999) feat(comptime): Implement to_be_bits and to_le_bits in the interpreter (noir-lang/noir#7008) chore: Add short circuit in ssa-gen for known if conditions (noir-lang/noir#7007) chore: Only resolved globals monomorphization (noir-lang/noir#7006) chore: Remove resolve_is_unconstrained pass (noir-lang/noir#7004) chore: require safety doc comment for unsafe instead of `//@safety` (noir-lang/noir#6992) fix: Reproduce and fix bytecode blowup (noir-lang/noir#6972) chore: mark casts as able to be deduplicated (noir-lang/noir#6996) fix: return trait impl method as FuncId if there's only one (noir-lang/noir#6989) chore(ci): fail properly in `external-repo-checks` (noir-lang/noir#6988) fix: allow multiple trait impls for the same trait as long as one is in scope (noir-lang/noir#6987) chore: Use DFG in SSA printer (noir-lang/noir#6986) chore!: Reserve `enum` and `match` keywords (noir-lang/noir#6961)

fix: let static_assert fail with the provided message

97604ab

asterite added 2 commits January 9, 2025 12:57

Add test

8f21c70

noir-rsa compiles again

b2cd1f6

jfecher reviewed Jan 9, 2025

View reviewed changes

compiler/noirc_evaluator/src/ssa/ir/printer.rs Outdated Show resolved Hide resolved

compiler/noirc_evaluator/src/ssa/ir/dfg.rs Outdated Show resolved Hide resolved

asterite and others added 4 commits January 9, 2025 13:00

Update compiler/noirc_evaluator/src/ssa/ir/printer.rs

4e464a8

Co-authored-by: jfecher <[email protected]>

Use String::from_utf8

7b1fa04

Fix code

c404fe1

Merge branch 'master' into ab/static-assert-message

037b7e1

TomAFrench approved these changes Jan 10, 2025

View reviewed changes

TomAFrench added this pull request to the merge queue Jan 10, 2025

Merged via the queue into master with commit 268229e Jan 10, 2025
87 checks passed

TomAFrench deleted the ab/static-assert-message branch January 10, 2025 13:43

noirwhal mentioned this pull request Jan 10, 2025

chore: Release Noir(1.0.0-beta.2) #6914

Open

TomAFrench mentioned this pull request Jan 10, 2025

Allow fmtstr to be passed to static_assert instead of str. #6884

Open

AztecBot mentioned this pull request Jan 10, 2025

feat: Sync from noir AztecProtocol/aztec-packages#11138

Merged

AztecBot mentioned this pull request Jan 11, 2025

chore(master): Release 0.70.0 AztecProtocol/aztec-packages#11107

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: let static_assert fail with the provided message #7005

fix: let static_assert fail with the provided message #7005

asterite commented Jan 9, 2025

github-actions bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading

fix: let static_assert fail with the provided message #7005

fix: let static_assert fail with the provided message #7005

Conversation

asterite commented Jan 9, 2025

Description

Problem

Summary

Additional Context

Documentation

PR Checklist

github-actions bot commented Jan 9, 2025 • edited Loading

Execution Report

github-actions bot commented Jan 9, 2025 • edited Loading

Compilation Report

github-actions bot commented Jan 9, 2025 • edited Loading

Compilation Memory Report

github-actions bot commented Jan 9, 2025 • edited Loading

Execution Memory Report

github-actions bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading