feat!: require trait primitive functions/calls to have their trait in scope #6901

asterite · 2024-12-20T21:18:24Z

Description

Based on top of #6895

Problem

Part of #6864

Summary

Similar to the previous PRs but this time for primitive types (Field::foo() and field.foo()). In reality Field::foo() already worked before this PR (as a result of some previous PR) but I added tests to make sure that's the case.

This PR also introduces a refactor: previously methods were kept in two places, one for structs and one for everything else (keyed under TypeMethodKey). Now they are all in a single place, and there's a new TypeMethodKey variant for structs. This greatly simplifies/unifies the code.

Additional Context

Documentation

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

…to-be-in-scope-for-methods

github-actions · 2024-12-20T21:22:25Z

Peak Memory Sample

Program	Peak Memory
keccak256	78.51M
workspace	123.47M
regression_4709	422.94M
ram_blowup_regression	1.58G
private-kernel-tail	168.30M
private-kernel-reset	168.33M
private-kernel-inner	168.30M
parity-root	151.61M

github-actions · 2024-12-20T21:23:12Z

Compilation Report

Program	Compilation Time	%
sha256_regression	1.270s	-1%
regression_4709	0.786s	0%
ram_blowup_regression	18.120s	-1%
rollup-root	3.600s	-4%
rollup-block-merge	3.670s	-3%
rollup-base-public	34.900s	-8%
rollup-base-private	14.500s	16%
private-kernel-tail	1.076s	11%
private-kernel-reset	8.262s	-4%
private-kernel-inner	2.164s	4%

github-actions · 2025-01-07T19:35:21Z

Execution Report

Program	Execution Time	%
sha256_regression	0.054s	0%
regression_4709	0.001s	0%
ram_blowup_regression	0.576s	1%
rollup-root	0.104s	-1%
rollup-block-merge	0.106s	-1%
rollup-base-public	1.210s	-1%
rollup-base-private	0.465s	0%
private-kernel-tail	0.022s	4%
private-kernel-reset	0.346s	-1%
private-kernel-inner	0.076s	-2%

github-actions · 2025-01-07T19:36:02Z

Compilation Memory Report

Program	Peak Memory
keccak256	78.11M
workspace	123.43M
regression_4709	422.97M
ram_blowup_regression	1.58G
rollup-base-public	4.11G
rollup-base-private	1.20G
private-kernel-tail	207.19M
private-kernel-reset	730.61M
private-kernel-inner	294.42M

github-actions · 2025-01-07T19:36:02Z

Execution Memory Report

Program	Peak Memory
keccak256	74.66M
workspace	123.78M
regression_4709	315.99M
ram_blowup_regression	512.41M
rollup-base-public	480.66M
rollup-base-private	326.53M
private-kernel-tail	181.04M
private-kernel-reset	249.71M
private-kernel-inner	209.88M

This reverts commit 0007992.

…tions-in-scope-for-primitives

michaeljklein

LGTM

…eir trait in scope (noir-lang/noir#6901) feat(lsp): use trait method docs for trait impl method docs on hover (noir-lang/noir#7003) chore: turn on averaging for protocol circuits metrics in CI (noir-lang/noir#6999) feat(comptime): Implement to_be_bits and to_le_bits in the interpreter (noir-lang/noir#7008) chore: Add short circuit in ssa-gen for known if conditions (noir-lang/noir#7007) chore: Only resolved globals monomorphization (noir-lang/noir#7006) chore: Remove resolve_is_unconstrained pass (noir-lang/noir#7004) chore: require safety doc comment for unsafe instead of `//@safety` (noir-lang/noir#6992) fix: Reproduce and fix bytecode blowup (noir-lang/noir#6972) chore: mark casts as able to be deduplicated (noir-lang/noir#6996) fix: return trait impl method as FuncId if there's only one (noir-lang/noir#6989) chore(ci): fail properly in `external-repo-checks` (noir-lang/noir#6988) fix: allow multiple trait impls for the same trait as long as one is in scope (noir-lang/noir#6987) chore: Use DFG in SSA printer (noir-lang/noir#6986) chore!: Reserve `enum` and `match` keywords (noir-lang/noir#6961)

…hem (noir-lang/noir#6913) feat!: require trait primitive functions/calls to have their trait in scope (noir-lang/noir#6901) feat(lsp): use trait method docs for trait impl method docs on hover (noir-lang/noir#7003) chore: turn on averaging for protocol circuits metrics in CI (noir-lang/noir#6999) feat(comptime): Implement to_be_bits and to_le_bits in the interpreter (noir-lang/noir#7008) chore: Add short circuit in ssa-gen for known if conditions (noir-lang/noir#7007) chore: Only resolved globals monomorphization (noir-lang/noir#7006) chore: Remove resolve_is_unconstrained pass (noir-lang/noir#7004) chore: require safety doc comment for unsafe instead of `//@safety` (noir-lang/noir#6992) fix: Reproduce and fix bytecode blowup (noir-lang/noir#6972) chore: mark casts as able to be deduplicated (noir-lang/noir#6996) fix: return trait impl method as FuncId if there's only one (noir-lang/noir#6989) chore(ci): fail properly in `external-repo-checks` (noir-lang/noir#6988) fix: allow multiple trait impls for the same trait as long as one is in scope (noir-lang/noir#6987) chore: Use DFG in SSA printer (noir-lang/noir#6986) chore!: Reserve `enum` and `match` keywords (noir-lang/noir#6961)

…ng/noir#6913) feat!: require trait primitive functions/calls to have their trait in scope (noir-lang/noir#6901) feat(lsp): use trait method docs for trait impl method docs on hover (noir-lang/noir#7003) chore: turn on averaging for protocol circuits metrics in CI (noir-lang/noir#6999) feat(comptime): Implement to_be_bits and to_le_bits in the interpreter (noir-lang/noir#7008) chore: Add short circuit in ssa-gen for known if conditions (noir-lang/noir#7007) chore: Only resolved globals monomorphization (noir-lang/noir#7006) chore: Remove resolve_is_unconstrained pass (noir-lang/noir#7004) chore: require safety doc comment for unsafe instead of `//@safety` (noir-lang/noir#6992) fix: Reproduce and fix bytecode blowup (noir-lang/noir#6972) chore: mark casts as able to be deduplicated (noir-lang/noir#6996) fix: return trait impl method as FuncId if there's only one (noir-lang/noir#6989) chore(ci): fail properly in `external-repo-checks` (noir-lang/noir#6988) fix: allow multiple trait impls for the same trait as long as one is in scope (noir-lang/noir#6987) chore: Use DFG in SSA printer (noir-lang/noir#6986) chore!: Reserve `enum` and `match` keywords (noir-lang/noir#6961)

chore: delete docs for versions which aren't used (noir-lang/noir#7020) feat!: Disable mocks in `execute` (noir-lang/noir#6869) chore(docs): backport 1.0.0-beta.0 doc fixes (noir-lang/noir#7014) feat(cli): Add CLI option to filter by contract function name (noir-lang/noir#7018) chore: Add more Field use info (noir-lang/noir#7019) fix: let static_assert fail with the provided message (noir-lang/noir#7005) chore: mark `aztec-nr` as expected to compile (noir-lang/noir#7015) chore: clarity fix in docs (noir-lang/noir#7016) fix: require generic trait impls to be in scope to call them (noir-lang/noir#6913) feat!: require trait primitive functions/calls to have their trait in scope (noir-lang/noir#6901) feat(lsp): use trait method docs for trait impl method docs on hover (noir-lang/noir#7003) chore: turn on averaging for protocol circuits metrics in CI (noir-lang/noir#6999) feat(comptime): Implement to_be_bits and to_le_bits in the interpreter (noir-lang/noir#7008) chore: Add short circuit in ssa-gen for known if conditions (noir-lang/noir#7007) chore: Only resolved globals monomorphization (noir-lang/noir#7006) chore: Remove resolve_is_unconstrained pass (noir-lang/noir#7004) chore: require safety doc comment for unsafe instead of `//@safety` (noir-lang/noir#6992) fix: Reproduce and fix bytecode blowup (noir-lang/noir#6972) chore: mark casts as able to be deduplicated (noir-lang/noir#6996) fix: return trait impl method as FuncId if there's only one (noir-lang/noir#6989) chore(ci): fail properly in `external-repo-checks` (noir-lang/noir#6988) fix: allow multiple trait impls for the same trait as long as one is in scope (noir-lang/noir#6987) chore: Use DFG in SSA printer (noir-lang/noir#6986) chore!: Reserve `enum` and `match` keywords (noir-lang/noir#6961)

…ang/noir#6985) feat!: disallow calling unconstrained functions outside of `unsafe` blocks and passing unconstrained functions in place of constrained functions (noir-lang/noir#6938) chore: simplify a couple of enum variants (noir-lang/noir#7025) chore: disallow inserting ACIR-only instructions into brillig functions (noir-lang/noir#7017) feat: unchecked math operations in SSA (noir-lang/noir#7011) chore: delete docs for versions which aren't used (noir-lang/noir#7020) feat!: Disable mocks in `execute` (noir-lang/noir#6869) chore(docs): backport 1.0.0-beta.0 doc fixes (noir-lang/noir#7014) feat(cli): Add CLI option to filter by contract function name (noir-lang/noir#7018) chore: Add more Field use info (noir-lang/noir#7019) fix: let static_assert fail with the provided message (noir-lang/noir#7005) chore: mark `aztec-nr` as expected to compile (noir-lang/noir#7015) chore: clarity fix in docs (noir-lang/noir#7016) fix: require generic trait impls to be in scope to call them (noir-lang/noir#6913) feat!: require trait primitive functions/calls to have their trait in scope (noir-lang/noir#6901) feat(lsp): use trait method docs for trait impl method docs on hover (noir-lang/noir#7003) chore: turn on averaging for protocol circuits metrics in CI (noir-lang/noir#6999) feat(comptime): Implement to_be_bits and to_le_bits in the interpreter (noir-lang/noir#7008) chore: Add short circuit in ssa-gen for known if conditions (noir-lang/noir#7007) chore: Only resolved globals monomorphization (noir-lang/noir#7006) chore: Remove resolve_is_unconstrained pass (noir-lang/noir#7004) chore: require safety doc comment for unsafe instead of `//@safety` (noir-lang/noir#6992) fix: Reproduce and fix bytecode blowup (noir-lang/noir#6972) chore: mark casts as able to be deduplicated (noir-lang/noir#6996) fix: return trait impl method as FuncId if there's only one (noir-lang/noir#6989) chore(ci): fail properly in `external-repo-checks` (noir-lang/noir#6988) fix: allow multiple trait impls for the same trait as long as one is in scope (noir-lang/noir#6987) chore: Use DFG in SSA printer (noir-lang/noir#6986) chore!: Reserve `enum` and `match` keywords (noir-lang/noir#6961)

feat!: disallow calling unconstrained functions outside of `unsafe` blocks and passing unconstrained functions in place of constrained functions (noir-lang/noir#6938) chore: simplify a couple of enum variants (noir-lang/noir#7025) chore: disallow inserting ACIR-only instructions into brillig functions (noir-lang/noir#7017) feat: unchecked math operations in SSA (noir-lang/noir#7011) chore: delete docs for versions which aren't used (noir-lang/noir#7020) feat!: Disable mocks in `execute` (noir-lang/noir#6869) chore(docs): backport 1.0.0-beta.0 doc fixes (noir-lang/noir#7014) feat(cli): Add CLI option to filter by contract function name (noir-lang/noir#7018) chore: Add more Field use info (noir-lang/noir#7019) fix: let static_assert fail with the provided message (noir-lang/noir#7005) chore: mark `aztec-nr` as expected to compile (noir-lang/noir#7015) chore: clarity fix in docs (noir-lang/noir#7016) fix: require generic trait impls to be in scope to call them (noir-lang/noir#6913) feat!: require trait primitive functions/calls to have their trait in scope (noir-lang/noir#6901) feat(lsp): use trait method docs for trait impl method docs on hover (noir-lang/noir#7003) chore: turn on averaging for protocol circuits metrics in CI (noir-lang/noir#6999) feat(comptime): Implement to_be_bits and to_le_bits in the interpreter (noir-lang/noir#7008) chore: Add short circuit in ssa-gen for known if conditions (noir-lang/noir#7007) chore: Only resolved globals monomorphization (noir-lang/noir#7006) chore: Remove resolve_is_unconstrained pass (noir-lang/noir#7004) chore: require safety doc comment for unsafe instead of `//@safety` (noir-lang/noir#6992) fix: Reproduce and fix bytecode blowup (noir-lang/noir#6972) chore: mark casts as able to be deduplicated (noir-lang/noir#6996) fix: return trait impl method as FuncId if there's only one (noir-lang/noir#6989) chore(ci): fail properly in `external-repo-checks` (noir-lang/noir#6988) fix: allow multiple trait impls for the same trait as long as one is in scope (noir-lang/noir#6987) chore: Use DFG in SSA printer (noir-lang/noir#6986) chore!: Reserve `enum` and `match` keywords (noir-lang/noir#6961)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat!: require trait primitive functions/calls to have their trait in scope (noir-lang/noir#6901) feat(lsp): use trait method docs for trait impl method docs on hover (noir-lang/noir#7003) chore: turn on averaging for protocol circuits metrics in CI (noir-lang/noir#6999) feat(comptime): Implement to_be_bits and to_le_bits in the interpreter (noir-lang/noir#7008) chore: Add short circuit in ssa-gen for known if conditions (noir-lang/noir#7007) chore: Only resolved globals monomorphization (noir-lang/noir#7006) chore: Remove resolve_is_unconstrained pass (noir-lang/noir#7004) chore: require safety doc comment for unsafe instead of `//@safety` (noir-lang/noir#6992) fix: Reproduce and fix bytecode blowup (noir-lang/noir#6972) chore: mark casts as able to be deduplicated (noir-lang/noir#6996) fix: return trait impl method as FuncId if there's only one (noir-lang/noir#6989) chore(ci): fail properly in `external-repo-checks` (noir-lang/noir#6988) fix: allow multiple trait impls for the same trait as long as one is in scope (noir-lang/noir#6987) chore: Use DFG in SSA printer (noir-lang/noir#6986) chore!: Reserve `enum` and `match` keywords (noir-lang/noir#6961) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <[email protected]>

asterite added 12 commits December 19, 2024 12:54

fix: track trait IDs for trait impls on structs

1df848d

feat: require trait methods in paths to be in scope

33e7b97

Show trait full path in error message

ed171c3

Fix frontend tests

9294758

Fix bug introduced in fully_qualified_module_path

6eaf88f

Add a couple more comments

28fdbe2

Fix: multiple trait methods were not registered for structs

f661567

Reuse Elaborator::lookup_method in interpreter

c274629

Require traits to be in scope to call methods

c980099

Merge branch 'master' into ab/require-trait-to-be-in-scope

4797814

Merge branch 'ab/require-trait-to-be-in-scope' into ab/require-trait-…

8b6b175

…to-be-in-scope-for-methods

Move test somewhere else

3cbe8d0

asterite mentioned this pull request Dec 23, 2024

fix: require generic trait impls to be in scope to call them #6913

Merged

5 tasks

asterite and others added 9 commits January 3, 2025 12:02

Merge branch 'master' into ab/require-trait-to-be-in-scope-for-methods

07383b8

Remove duplicate method

c94448c

Merge branch 'master' into ab/require-trait-to-be-in-scope-for-methods

fdb2311

Merge branch 'master' into ab/require-trait-to-be-in-scope-for-methods

91abe70

cargo fmt

44dbb3b

Merge branch 'master' into ab/require-trait-to-be-in-scope-for-methods

bddf052

Merge branch 'master' into ab/require-trait-to-be-in-scope-for-methods

95366c0

Merge branch 'master' into ab/require-trait-to-be-in-scope-for-methods

e2fe92d

Merge branch 'master' into ab/require-trait-to-be-in-scope-for-methods

3088b1d

asterite added 2 commits January 7, 2025 17:56

Revert "chore: also print test output to stdout in CI (#6930)"

3248790

This reverts commit 0007992.

Merge branch 'master' into ab/require-trait-to-be-in-scope-for-methods

f3813b4

TomAFrench marked this pull request as ready for review January 7, 2025 21:17

TomAFrench marked this pull request as draft January 7, 2025 21:18

asterite added 5 commits January 7, 2025 21:18

Put struct and primitive methods in the same HashMap

afd89ad

Put struct and primitive methods in the same HashMap

6e2e06c

Try to unify method lookup a bit more

673c3d3

Unify struct and primitive method lookup

ae1337f

Make sure it also works the same for primitive method calls

7a33518

TomAFrench force-pushed the ab/trait-functions-in-scope-for-primitives branch from e6b2286 to 7a33518 Compare January 7, 2025 21:19

Base automatically changed from ab/require-trait-to-be-in-scope-for-methods to master January 8, 2025 10:49

Merge branch 'master' of github.com:noir-lang/noir into ab/trait-func…

2cfaa49

…tions-in-scope-for-primitives

asterite marked this pull request as ready for review January 8, 2025 11:22

asterite requested a review from a team January 8, 2025 11:22

asterite added 2 commits January 8, 2025 15:12

Merge branch 'master' into ab/trait-functions-in-scope-for-primitives

90ff94a

Merge branch 'master' into ab/trait-functions-in-scope-for-primitives

019911b

michaeljklein approved these changes Jan 9, 2025

View reviewed changes

TomAFrench added this pull request to the merge queue Jan 9, 2025

Merged via the queue into master with commit 56c931a Jan 9, 2025
87 checks passed

TomAFrench deleted the ab/trait-functions-in-scope-for-primitives branch January 9, 2025 19:06

noirwhal mentioned this pull request Jan 9, 2025

chore: Release Noir(1.0.0-beta.2) #6914

Open

AztecBot mentioned this pull request Jan 9, 2025

feat: Sync from noir AztecProtocol/aztec-packages#11138

Merged

AztecBot mentioned this pull request Jan 11, 2025

chore(master): Release 0.70.0 AztecProtocol/aztec-packages#11107

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: require trait primitive functions/calls to have their trait in scope #6901

feat!: require trait primitive functions/calls to have their trait in scope #6901

asterite commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

michaeljklein left a comment

feat!: require trait primitive functions/calls to have their trait in scope #6901

feat!: require trait primitive functions/calls to have their trait in scope #6901

Conversation

asterite commented Dec 20, 2024 • edited Loading

Description

Problem

Summary

Additional Context

Documentation

PR Checklist

github-actions bot commented Dec 20, 2024

Peak Memory Sample

github-actions bot commented Dec 20, 2024 • edited Loading

Compilation Report

github-actions bot commented Jan 7, 2025 • edited Loading

Execution Report

github-actions bot commented Jan 7, 2025 • edited Loading

Compilation Memory Report

github-actions bot commented Jan 7, 2025 • edited Loading

Execution Memory Report

michaeljklein left a comment

Choose a reason for hiding this comment

asterite commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading