-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lock on Nargo.toml on several nargo commands #6941
Conversation
Compilation Report
|
Execution Report
|
Execution Memory Report
|
Compilation Memory Report
|
c4a397b
to
5d263d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I said I'd consider using lock_shared
for any that read Nargo.toml
, but otherwise LGTM!
Done! Let me know if it's good now. |
Looks great! I think it makes sense that you don't want to overwrite artefacts during debug and test, which I suppose could take a long time. |
…oir#6926) chore: simplify boolean in a mul of a mul (noir-lang/noir#6951) feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893) chore: Move comment as part of #6945 (noir-lang/noir#6959) chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894) feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952) feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941) feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948) chore: add reproduction case for bignum test failure (noir-lang/noir#6464) chore: bump `noir-gates-diff` (noir-lang/noir#6949) feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835) chore: also print test output to stdout in CI (noir-lang/noir#6930) fix: Non-determinism from under constrained checks (noir-lang/noir#6945) chore: use logs for benchmarking (noir-lang/noir#6911) chore: bump `noir-gates-diff` (noir-lang/noir#6944) chore: bump `noir-gates-diff` (noir-lang/noir#6943) fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942) chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939) feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882) chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871)
chore: simplify boolean in a mul of a mul (noir-lang/noir#6951) feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893) chore: Move comment as part of #6945 (noir-lang/noir#6959) chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894) feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952) feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941) feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948) chore: add reproduction case for bignum test failure (noir-lang/noir#6464) chore: bump `noir-gates-diff` (noir-lang/noir#6949) feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835) chore: also print test output to stdout in CI (noir-lang/noir#6930) fix: Non-determinism from under constrained checks (noir-lang/noir#6945) chore: use logs for benchmarking (noir-lang/noir#6911) chore: bump `noir-gates-diff` (noir-lang/noir#6944) chore: bump `noir-gates-diff` (noir-lang/noir#6943) fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942) chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939) feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882) chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871)
) feat: `--pedantic-solving` flag (noir-lang/noir#6716) feat!: update `aes128_encrypt` to return an array (noir-lang/noir#6973) fix: wrong module to lookup trait when using crate or super (noir-lang/noir#6974) fix: Start RC at 1 again (noir-lang/noir#6958) feat!: turn TypeIsMorePrivateThenItem into an error (noir-lang/noir#6953) fix: don't fail parsing macro if there are parser warnings (noir-lang/noir#6969) fix: error on missing function parameters (noir-lang/noir#6967) feat: don't report warnings for dependencies (noir-lang/noir#6926) chore: simplify boolean in a mul of a mul (noir-lang/noir#6951) feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893) chore: Move comment as part of #6945 (noir-lang/noir#6959) chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894) feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952) feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941) feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948) chore: add reproduction case for bignum test failure (noir-lang/noir#6464) chore: bump `noir-gates-diff` (noir-lang/noir#6949) feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835) chore: also print test output to stdout in CI (noir-lang/noir#6930) fix: Non-determinism from under constrained checks (noir-lang/noir#6945) chore: use logs for benchmarking (noir-lang/noir#6911) chore: bump `noir-gates-diff` (noir-lang/noir#6944) chore: bump `noir-gates-diff` (noir-lang/noir#6943) fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942) chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939) feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882) chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871)
feat: `--pedantic-solving` flag (noir-lang/noir#6716) feat!: update `aes128_encrypt` to return an array (noir-lang/noir#6973) fix: wrong module to lookup trait when using crate or super (noir-lang/noir#6974) fix: Start RC at 1 again (noir-lang/noir#6958) feat!: turn TypeIsMorePrivateThenItem into an error (noir-lang/noir#6953) fix: don't fail parsing macro if there are parser warnings (noir-lang/noir#6969) fix: error on missing function parameters (noir-lang/noir#6967) feat: don't report warnings for dependencies (noir-lang/noir#6926) chore: simplify boolean in a mul of a mul (noir-lang/noir#6951) feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893) chore: Move comment as part of #6945 (noir-lang/noir#6959) chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894) feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952) feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941) feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948) chore: add reproduction case for bignum test failure (noir-lang/noir#6464) chore: bump `noir-gates-diff` (noir-lang/noir#6949) feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835) chore: also print test output to stdout in CI (noir-lang/noir#6930) fix: Non-determinism from under constrained checks (noir-lang/noir#6945) chore: use logs for benchmarking (noir-lang/noir#6911) chore: bump `noir-gates-diff` (noir-lang/noir#6944) chore: bump `noir-gates-diff` (noir-lang/noir#6943) fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942) chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939) feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882) chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871)
* master: (51 commits) feat!: type-check trait default methods (#6645) feat: `--pedantic-solving` flag (#6716) feat!: update `aes128_encrypt` to return an array (#6973) fix: wrong module to lookup trait when using crate or super (#6974) fix: Start RC at 1 again (#6958) feat!: turn TypeIsMorePrivateThenItem into an error (#6953) fix: don't fail parsing macro if there are parser warnings (#6969) fix: error on missing function parameters (#6967) feat: don't report warnings for dependencies (#6926) chore: simplify boolean in a mul of a mul (#6951) feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (#6893) chore: Move comment as part of #6945 (#6959) chore: Separate unconstrained functions during monomorphization (#6894) feat!: turn CannotReexportItemWithLessVisibility into an error (#6952) feat: lock on Nargo.toml on several nargo commands (#6941) feat: don't simplify SSA instructions when creating them from a string (#6948) chore: add reproduction case for bignum test failure (#6464) chore: bump `noir-gates-diff` (#6949) feat(test): Enable the test fuzzer for Wasm (#6835) chore: also print test output to stdout in CI (#6930) ...
) feat: `--pedantic-solving` flag (noir-lang/noir#6716) feat!: update `aes128_encrypt` to return an array (noir-lang/noir#6973) fix: wrong module to lookup trait when using crate or super (noir-lang/noir#6974) fix: Start RC at 1 again (noir-lang/noir#6958) feat!: turn TypeIsMorePrivateThenItem into an error (noir-lang/noir#6953) fix: don't fail parsing macro if there are parser warnings (noir-lang/noir#6969) fix: error on missing function parameters (noir-lang/noir#6967) feat: don't report warnings for dependencies (noir-lang/noir#6926) chore: simplify boolean in a mul of a mul (noir-lang/noir#6951) feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893) chore: Move comment as part of #6945 (noir-lang/noir#6959) chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894) feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952) feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941) feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948) chore: add reproduction case for bignum test failure (noir-lang/noir#6464) chore: bump `noir-gates-diff` (noir-lang/noir#6949) feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835) chore: also print test output to stdout in CI (noir-lang/noir#6930) fix: Non-determinism from under constrained checks (noir-lang/noir#6945) chore: use logs for benchmarking (noir-lang/noir#6911) chore: bump `noir-gates-diff` (noir-lang/noir#6944) chore: bump `noir-gates-diff` (noir-lang/noir#6943) fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942) chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939) feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882) chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871)
feat: `--pedantic-solving` flag (noir-lang/noir#6716) feat!: update `aes128_encrypt` to return an array (noir-lang/noir#6973) fix: wrong module to lookup trait when using crate or super (noir-lang/noir#6974) fix: Start RC at 1 again (noir-lang/noir#6958) feat!: turn TypeIsMorePrivateThenItem into an error (noir-lang/noir#6953) fix: don't fail parsing macro if there are parser warnings (noir-lang/noir#6969) fix: error on missing function parameters (noir-lang/noir#6967) feat: don't report warnings for dependencies (noir-lang/noir#6926) chore: simplify boolean in a mul of a mul (noir-lang/noir#6951) feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893) chore: Move comment as part of #6945 (noir-lang/noir#6959) chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894) feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952) feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941) feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948) chore: add reproduction case for bignum test failure (noir-lang/noir#6464) chore: bump `noir-gates-diff` (noir-lang/noir#6949) feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835) chore: also print test output to stdout in CI (noir-lang/noir#6930) fix: Non-determinism from under constrained checks (noir-lang/noir#6945) chore: use logs for benchmarking (noir-lang/noir#6911) chore: bump `noir-gates-diff` (noir-lang/noir#6944) chore: bump `noir-gates-diff` (noir-lang/noir#6943) fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942) chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939) feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882) chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871)
fix: Do not emit range check for multiplication by bool (noir-lang/noir#6983) fix: do not panic on indices which are not valid `u32`s (noir-lang/noir#6976) feat!: require trait method calls (`foo.bar()`) to have the trait in scope (imported) (noir-lang/noir#6895) feat!: type-check trait default methods (noir-lang/noir#6645) feat: `--pedantic-solving` flag (noir-lang/noir#6716) feat!: update `aes128_encrypt` to return an array (noir-lang/noir#6973) fix: wrong module to lookup trait when using crate or super (noir-lang/noir#6974) fix: Start RC at 1 again (noir-lang/noir#6958) feat!: turn TypeIsMorePrivateThenItem into an error (noir-lang/noir#6953) fix: don't fail parsing macro if there are parser warnings (noir-lang/noir#6969) fix: error on missing function parameters (noir-lang/noir#6967) feat: don't report warnings for dependencies (noir-lang/noir#6926) chore: simplify boolean in a mul of a mul (noir-lang/noir#6951) feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893) chore: Move comment as part of #6945 (noir-lang/noir#6959) chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894) feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952) feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941) feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948) chore: add reproduction case for bignum test failure (noir-lang/noir#6464) chore: bump `noir-gates-diff` (noir-lang/noir#6949) feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835) chore: also print test output to stdout in CI (noir-lang/noir#6930) fix: Non-determinism from under constrained checks (noir-lang/noir#6945) chore: use logs for benchmarking (noir-lang/noir#6911) chore: bump `noir-gates-diff` (noir-lang/noir#6944) chore: bump `noir-gates-diff` (noir-lang/noir#6943) fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942) chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939) feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882) chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871)
fix: Do not emit range check for multiplication by bool (noir-lang/noir#6983) fix: do not panic on indices which are not valid `u32`s (noir-lang/noir#6976) feat!: require trait method calls (`foo.bar()`) to have the trait in scope (imported) (noir-lang/noir#6895) feat!: type-check trait default methods (noir-lang/noir#6645) feat: `--pedantic-solving` flag (noir-lang/noir#6716) feat!: update `aes128_encrypt` to return an array (noir-lang/noir#6973) fix: wrong module to lookup trait when using crate or super (noir-lang/noir#6974) fix: Start RC at 1 again (noir-lang/noir#6958) feat!: turn TypeIsMorePrivateThenItem into an error (noir-lang/noir#6953) fix: don't fail parsing macro if there are parser warnings (noir-lang/noir#6969) fix: error on missing function parameters (noir-lang/noir#6967) feat: don't report warnings for dependencies (noir-lang/noir#6926) chore: simplify boolean in a mul of a mul (noir-lang/noir#6951) feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893) chore: Move comment as part of #6945 (noir-lang/noir#6959) chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894) feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952) feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941) feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948) chore: add reproduction case for bignum test failure (noir-lang/noir#6464) chore: bump `noir-gates-diff` (noir-lang/noir#6949) feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835) chore: also print test output to stdout in CI (noir-lang/noir#6930) fix: Non-determinism from under constrained checks (noir-lang/noir#6945) chore: use logs for benchmarking (noir-lang/noir#6911) chore: bump `noir-gates-diff` (noir-lang/noir#6944) chore: bump `noir-gates-diff` (noir-lang/noir#6943) fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942) chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939) feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882) chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871)
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: impl Default for U128 (noir-lang/noir#6984) fix: Do not emit range check for multiplication by bool (noir-lang/noir#6983) fix: do not panic on indices which are not valid `u32`s (noir-lang/noir#6976) feat!: require trait method calls (`foo.bar()`) to have the trait in scope (imported) (noir-lang/noir#6895) feat!: type-check trait default methods (noir-lang/noir#6645) feat: `--pedantic-solving` flag (noir-lang/noir#6716) feat!: update `aes128_encrypt` to return an array (noir-lang/noir#6973) fix: wrong module to lookup trait when using crate or super (noir-lang/noir#6974) fix: Start RC at 1 again (noir-lang/noir#6958) feat!: turn TypeIsMorePrivateThenItem into an error (noir-lang/noir#6953) fix: don't fail parsing macro if there are parser warnings (noir-lang/noir#6969) fix: error on missing function parameters (noir-lang/noir#6967) feat: don't report warnings for dependencies (noir-lang/noir#6926) chore: simplify boolean in a mul of a mul (noir-lang/noir#6951) feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893) chore: Move comment as part of #6945 (noir-lang/noir#6959) chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894) feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952) feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941) feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948) chore: add reproduction case for bignum test failure (noir-lang/noir#6464) chore: bump `noir-gates-diff` (noir-lang/noir#6949) feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835) chore: also print test output to stdout in CI (noir-lang/noir#6930) fix: Non-determinism from under constrained checks (noir-lang/noir#6945) chore: use logs for benchmarking (noir-lang/noir#6911) chore: bump `noir-gates-diff` (noir-lang/noir#6944) chore: bump `noir-gates-diff` (noir-lang/noir#6943) fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942) chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939) feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882) chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871) END_COMMIT_OVERRIDE --------- Co-authored-by: Michael J Klein <[email protected]> Co-authored-by: Michael Klein <[email protected]> Co-authored-by: Tom French <[email protected]> Co-authored-by: Tom French <[email protected]> Co-authored-by: Charlie Lye <[email protected]> Co-authored-by: ludamad <[email protected]>
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: impl Default for U128 (noir-lang/noir#6984) fix: Do not emit range check for multiplication by bool (noir-lang/noir#6983) fix: do not panic on indices which are not valid `u32`s (noir-lang/noir#6976) feat!: require trait method calls (`foo.bar()`) to have the trait in scope (imported) (noir-lang/noir#6895) feat!: type-check trait default methods (noir-lang/noir#6645) feat: `--pedantic-solving` flag (noir-lang/noir#6716) feat!: update `aes128_encrypt` to return an array (noir-lang/noir#6973) fix: wrong module to lookup trait when using crate or super (noir-lang/noir#6974) fix: Start RC at 1 again (noir-lang/noir#6958) feat!: turn TypeIsMorePrivateThenItem into an error (noir-lang/noir#6953) fix: don't fail parsing macro if there are parser warnings (noir-lang/noir#6969) fix: error on missing function parameters (noir-lang/noir#6967) feat: don't report warnings for dependencies (noir-lang/noir#6926) chore: simplify boolean in a mul of a mul (noir-lang/noir#6951) feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893) chore: Move comment as part of #6945 (noir-lang/noir#6959) chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894) feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952) feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941) feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948) chore: add reproduction case for bignum test failure (noir-lang/noir#6464) chore: bump `noir-gates-diff` (noir-lang/noir#6949) feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835) chore: also print test output to stdout in CI (noir-lang/noir#6930) fix: Non-determinism from under constrained checks (noir-lang/noir#6945) chore: use logs for benchmarking (noir-lang/noir#6911) chore: bump `noir-gates-diff` (noir-lang/noir#6944) chore: bump `noir-gates-diff` (noir-lang/noir#6943) fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942) chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939) feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882) chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871) END_COMMIT_OVERRIDE --------- Co-authored-by: Michael J Klein <[email protected]> Co-authored-by: Michael Klein <[email protected]> Co-authored-by: Tom French <[email protected]> Co-authored-by: Tom French <[email protected]> Co-authored-by: Charlie Lye <[email protected]> Co-authored-by: ludamad <[email protected]>
Description
Problem
Something mentioned over Slack.
Summary
nargo_cli's
build.rs
was using a combination of mutexes and file locks. Instead of only doing it there, this PR moves the file lock to almost everynargo
command. That means that if you donargo execute
twice on the same directory, the second invocation will wait until the first one ends.I changed from
file_lock
tofs2
because it allows doingtry_lock_exclusive
so we can show the user a message saying we are waiting for a lock...Additional Context
I didn't include
nargo test
in here because I think it doesn't produce any output artifact... I don't know ifnargo debug
should do it either. In any case, for the purpose of tests, I think with havingexecute
andinfo
with a lock is good enough.Documentation
Check one:
PR Checklist
cargo fmt
on default settings.