feat!: turn TypeIsMorePrivateThenItem into an error

[asterite]

Description

Problem

Resolves #6936

Summary

In addition to turning the warning into an error, it turned out this program incorrectly gave a warning:

struct Foo {}

trait Bar {
    fn bar() -> Foo; // Type `Foo` is more private than item `bar`
}

fn main() {}

The reason is that we consider all trait methods to be public, but in reality (and according with Rust) they should have the same visibility as the trait they belong to. So this is changed in this PR.

Then, trait methods weren't correctly checked. When calling a trait method on a primitive, some logic regarding primitive methods were checked instead of checking the trait visibility, so this PR fixes that too.

Additional Context

Documentation

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[github-actions]

Execution Report

Program	Execution Time	%
sha256_regression	0.100s	0%
regression_4709	0.001s	0%
ram_blowup_regression	0.579s	0%
rollup-root	0.106s	0%
rollup-block-merge	0.108s	2%
rollup-base-public	1.420s	0%
rollup-base-private	0.696s	6%
private-kernel-tail	0.022s	-5%
private-kernel-reset	0.388s	0%
private-kernel-inner	0.117s	0%

[github-actions]

Compilation Report

Program	Compilation Time	%
sha256_regression	1.364s	3%
regression_4709	0.785s	2%
ram_blowup_regression	14.900s	0%
rollup-root	3.510s	3%
rollup-block-merge	3.580s	4%
rollup-base-public	29.200s	0%
rollup-base-private	19.700s	48%
private-kernel-tail	1.016s	-7%
private-kernel-reset	6.910s	1%
private-kernel-inner	2.150s	2%
noir-contracts	85.400s	0%

[github-actions]

Compilation Memory Report

Program	Peak Memory
keccak256	78.50M
workspace	123.72M
regression_4709	422.91M
ram_blowup_regression	1.58G
rollup-base-public	2.55G
rollup-base-private	1.25G
private-kernel-tail	201.97M
private-kernel-reset	716.60M
private-kernel-inner	292.24M

[github-actions]

Execution Memory Report

Program	Peak Memory
keccak256	74.61M
workspace	123.72M
regression_4709	315.93M
ram_blowup_regression	512.47M
rollup-base-public	773.36M
rollup-base-private	424.92M
private-kernel-tail	182.01M
private-kernel-reset	255.59M
private-kernel-inner	215.19M

[aakoshh]

LGTM!

By the way there are some Noir tests that access private members of structs defined in Noir, giving warnings. Are they going to be considered errors soon, or already?

[asterite]

Are they going to be considered errors soon, or already?

Soon! Though accessing private members of structs is done a lot in Aztec-Packages, and maybe in other external repos, we'll see, but I'm sure that's going to be the toughest one to move forward.

[asterite]

I'll just push another commit to document this visibility behavior.

[github-actions]

🚀 Deployed on https://677d0864d0ce776613b9ab64--noir-docs.netlify.app

[github-actions]

FYI @noir-lang/developerrelations on Noir doc changes.