Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: type-check trait default methods #6645

Merged
merged 15 commits into from
Jan 7, 2025

Conversation

asterite
Copy link
Collaborator

@asterite asterite commented Nov 28, 2024

Description

Problem

Resolves #6519

Summary

This is a breaking change because this code used to compile:

trait Foo {
  fn foo(self) -> Field {
    self.x
  }
}

That is, you could access a member of self in a trait method. Because the trait default method was checked against the actual concrete type, if it had a member x it compiled fine. Now that code is rejected (like in Rust). And... we have code like that in Aztec-Packages.

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@asterite asterite changed the title fix: type-check trait default methods feat!: type-check trait default methods Dec 23, 2024
@asterite asterite force-pushed the ab/type-check-trait-default-methods branch 2 times, most recently from 150b2b4 to 52c1332 Compare December 23, 2024 19:15
@asterite asterite force-pushed the ab/type-check-trait-default-methods branch from 52c1332 to 742b8d0 Compare December 23, 2024 19:15
Copy link
Contributor

github-actions bot commented Dec 23, 2024

Peak Memory Sample

Program Peak Memory
keccak256 78.48M
workspace 123.67M
regression_4709 422.91M
ram_blowup_regression 1.58G
private-kernel-tail 201.82M
private-kernel-reset 717.08M
private-kernel-inner 291.89M
parity-root 172.14M

Copy link
Contributor

github-actions bot commented Dec 23, 2024

Compilation Report

Program Compilation Time %
sha256_regression 1.396s 2%
regression_4709 0.803s 3%
ram_blowup_regression 15.520s -1%
rollup-root 4.210s -8%
rollup-block-merge 3.660s -12%
rollup-base-public 31.700s 6%
rollup-base-private 12.700s 2%
private-kernel-tail 1.060s -1%
private-kernel-reset 6.734s -2%
private-kernel-inner 2.136s -6%
noir-contracts 84.500s -3%

Copy link
Contributor

github-actions bot commented Dec 23, 2024

Execution Report

Program Execution Time %
sha256_regression 0.101s 1%
regression_4709 0.001s 0%
ram_blowup_regression 0.583s -1%
rollup-root 0.106s -1%
rollup-block-merge 0.106s 0%
rollup-base-public 1.460s 2%
rollup-base-private 0.652s 0%
private-kernel-tail 0.023s 0%
private-kernel-reset 0.388s -1%
private-kernel-inner 0.117s 0%

@asterite asterite marked this pull request as ready for review December 23, 2024 20:28
…-lang/noir into ab/type-check-trait-default-methods
TomAFrench added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 6, 2025
An [upcoming PR in Noir](noir-lang/noir#6645)
will start type-checking trait default methods. This PR fixes some of
them: they were accessing self members, but that's not valid in trait
default methods.

Co-authored-by: Tom French <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Compilation Memory Report

Program Peak Memory
keccak256 78.50M
workspace 123.75M
regression_4709 422.91M
ram_blowup_regression 1.58G
rollup-base-public 2.56G
rollup-base-private 1.25G
private-kernel-tail 201.98M
private-kernel-reset 716.61M
private-kernel-inner 292.25M

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Execution Memory Report

Program Peak Memory
keccak256 74.59M
workspace 123.80M
regression_4709 315.93M
ram_blowup_regression 512.47M
rollup-base-public 773.36M
rollup-base-private 424.92M
private-kernel-tail 182.01M
private-kernel-reset 255.60M
private-kernel-inner 215.19M

@asterite
Copy link
Collaborator Author

asterite commented Jan 6, 2025

This one also needs a release of noir-lang/noir-bignum#67

TomAFrench pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 6, 2025
This should fix a few errors that Noir will start reporting soon unless
we update to this newer version.

See noir-lang/noir#6895 and
noir-lang/noir#6645
AztecBot pushed a commit to AztecProtocol/aztec-nr that referenced this pull request Jan 7, 2025
An [upcoming PR in Noir](noir-lang/noir#6645)
will start type-checking trait default methods. This PR fixes some of
them: they were accessing self members, but that's not valid in trait
default methods.

Co-authored-by: Tom French <[email protected]>
@asterite asterite requested a review from a team January 7, 2025 10:37
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Traits are a complex beast...

@jfecher jfecher added this pull request to the merge queue Jan 7, 2025
Merged via the queue into master with commit 8bb3908 Jan 7, 2025
88 checks passed
@jfecher jfecher deleted the ab/type-check-trait-default-methods branch January 7, 2025 21:06
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 7, 2025
)

feat: `--pedantic-solving` flag (noir-lang/noir#6716)
feat!: update `aes128_encrypt` to return an array (noir-lang/noir#6973)
fix: wrong module to lookup trait when using crate or super (noir-lang/noir#6974)
fix: Start RC at 1 again (noir-lang/noir#6958)
feat!: turn TypeIsMorePrivateThenItem into an error (noir-lang/noir#6953)
fix: don't fail parsing macro if there are parser warnings (noir-lang/noir#6969)
fix: error on missing function parameters (noir-lang/noir#6967)
feat: don't report warnings for dependencies (noir-lang/noir#6926)
chore: simplify boolean in a mul of a mul (noir-lang/noir#6951)
feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893)
chore: Move comment as part of #6945 (noir-lang/noir#6959)
chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894)
feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952)
feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941)
feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948)
chore: add reproduction case for bignum test failure (noir-lang/noir#6464)
chore: bump `noir-gates-diff` (noir-lang/noir#6949)
feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835)
chore: also print test output to stdout in CI (noir-lang/noir#6930)
fix: Non-determinism from under constrained checks (noir-lang/noir#6945)
chore: use logs for benchmarking (noir-lang/noir#6911)
chore: bump `noir-gates-diff` (noir-lang/noir#6944)
chore: bump `noir-gates-diff` (noir-lang/noir#6943)
fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942)
chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939)
feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882)
chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 7, 2025
feat: `--pedantic-solving` flag (noir-lang/noir#6716)
feat!: update `aes128_encrypt` to return an array (noir-lang/noir#6973)
fix: wrong module to lookup trait when using crate or super (noir-lang/noir#6974)
fix: Start RC at 1 again (noir-lang/noir#6958)
feat!: turn TypeIsMorePrivateThenItem into an error (noir-lang/noir#6953)
fix: don't fail parsing macro if there are parser warnings (noir-lang/noir#6969)
fix: error on missing function parameters (noir-lang/noir#6967)
feat: don't report warnings for dependencies (noir-lang/noir#6926)
chore: simplify boolean in a mul of a mul (noir-lang/noir#6951)
feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893)
chore: Move comment as part of #6945 (noir-lang/noir#6959)
chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894)
feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952)
feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941)
feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948)
chore: add reproduction case for bignum test failure (noir-lang/noir#6464)
chore: bump `noir-gates-diff` (noir-lang/noir#6949)
feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835)
chore: also print test output to stdout in CI (noir-lang/noir#6930)
fix: Non-determinism from under constrained checks (noir-lang/noir#6945)
chore: use logs for benchmarking (noir-lang/noir#6911)
chore: bump `noir-gates-diff` (noir-lang/noir#6944)
chore: bump `noir-gates-diff` (noir-lang/noir#6943)
fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942)
chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939)
feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882)
chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871)
TomAFrench added a commit that referenced this pull request Jan 8, 2025
* master: (51 commits)
  feat!: type-check trait default methods (#6645)
  feat: `--pedantic-solving` flag (#6716)
  feat!: update `aes128_encrypt` to return an array (#6973)
  fix: wrong module to lookup trait when using crate or super (#6974)
  fix: Start RC at 1 again (#6958)
  feat!: turn TypeIsMorePrivateThenItem into an error (#6953)
  fix: don't fail parsing macro if there are parser warnings (#6969)
  fix: error on missing function parameters (#6967)
  feat: don't report warnings for dependencies (#6926)
  chore: simplify boolean in a mul of a mul (#6951)
  feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (#6893)
  chore: Move comment as part of #6945 (#6959)
  chore: Separate unconstrained functions during monomorphization (#6894)
  feat!: turn CannotReexportItemWithLessVisibility into an error (#6952)
  feat: lock on Nargo.toml on several nargo commands (#6941)
  feat: don't simplify SSA instructions when creating them from a string (#6948)
  chore: add reproduction case for bignum test failure (#6464)
  chore: bump `noir-gates-diff` (#6949)
  feat(test): Enable the test fuzzer for Wasm (#6835)
  chore: also print test output to stdout in CI (#6930)
  ...
TomAFrench added a commit that referenced this pull request Jan 8, 2025
* master:
  feat!: type-check trait default methods (#6645)
  feat: `--pedantic-solving` flag (#6716)
  feat!: update `aes128_encrypt` to return an array (#6973)
  fix: wrong module to lookup trait when using crate or super (#6974)
  fix: Start RC at 1 again (#6958)
  feat!: turn TypeIsMorePrivateThenItem into an error (#6953)
  fix: don't fail parsing macro if there are parser warnings (#6969)
  fix: error on missing function parameters (#6967)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 8, 2025
)

feat: `--pedantic-solving` flag (noir-lang/noir#6716)
feat!: update `aes128_encrypt` to return an array (noir-lang/noir#6973)
fix: wrong module to lookup trait when using crate or super (noir-lang/noir#6974)
fix: Start RC at 1 again (noir-lang/noir#6958)
feat!: turn TypeIsMorePrivateThenItem into an error (noir-lang/noir#6953)
fix: don't fail parsing macro if there are parser warnings (noir-lang/noir#6969)
fix: error on missing function parameters (noir-lang/noir#6967)
feat: don't report warnings for dependencies (noir-lang/noir#6926)
chore: simplify boolean in a mul of a mul (noir-lang/noir#6951)
feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893)
chore: Move comment as part of #6945 (noir-lang/noir#6959)
chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894)
feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952)
feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941)
feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948)
chore: add reproduction case for bignum test failure (noir-lang/noir#6464)
chore: bump `noir-gates-diff` (noir-lang/noir#6949)
feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835)
chore: also print test output to stdout in CI (noir-lang/noir#6930)
fix: Non-determinism from under constrained checks (noir-lang/noir#6945)
chore: use logs for benchmarking (noir-lang/noir#6911)
chore: bump `noir-gates-diff` (noir-lang/noir#6944)
chore: bump `noir-gates-diff` (noir-lang/noir#6943)
fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942)
chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939)
feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882)
chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 8, 2025
feat: `--pedantic-solving` flag (noir-lang/noir#6716)
feat!: update `aes128_encrypt` to return an array (noir-lang/noir#6973)
fix: wrong module to lookup trait when using crate or super (noir-lang/noir#6974)
fix: Start RC at 1 again (noir-lang/noir#6958)
feat!: turn TypeIsMorePrivateThenItem into an error (noir-lang/noir#6953)
fix: don't fail parsing macro if there are parser warnings (noir-lang/noir#6969)
fix: error on missing function parameters (noir-lang/noir#6967)
feat: don't report warnings for dependencies (noir-lang/noir#6926)
chore: simplify boolean in a mul of a mul (noir-lang/noir#6951)
feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893)
chore: Move comment as part of #6945 (noir-lang/noir#6959)
chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894)
feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952)
feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941)
feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948)
chore: add reproduction case for bignum test failure (noir-lang/noir#6464)
chore: bump `noir-gates-diff` (noir-lang/noir#6949)
feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835)
chore: also print test output to stdout in CI (noir-lang/noir#6930)
fix: Non-determinism from under constrained checks (noir-lang/noir#6945)
chore: use logs for benchmarking (noir-lang/noir#6911)
chore: bump `noir-gates-diff` (noir-lang/noir#6944)
chore: bump `noir-gates-diff` (noir-lang/noir#6943)
fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942)
chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939)
feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882)
chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 8, 2025
fix: Do not emit range check for multiplication by bool (noir-lang/noir#6983)
fix: do not panic on indices which are not valid `u32`s (noir-lang/noir#6976)
feat!: require trait method calls (`foo.bar()`) to have the trait in scope (imported) (noir-lang/noir#6895)
feat!: type-check trait default methods (noir-lang/noir#6645)
feat: `--pedantic-solving` flag (noir-lang/noir#6716)
feat!: update `aes128_encrypt` to return an array (noir-lang/noir#6973)
fix: wrong module to lookup trait when using crate or super (noir-lang/noir#6974)
fix: Start RC at 1 again (noir-lang/noir#6958)
feat!: turn TypeIsMorePrivateThenItem into an error (noir-lang/noir#6953)
fix: don't fail parsing macro if there are parser warnings (noir-lang/noir#6969)
fix: error on missing function parameters (noir-lang/noir#6967)
feat: don't report warnings for dependencies (noir-lang/noir#6926)
chore: simplify boolean in a mul of a mul (noir-lang/noir#6951)
feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893)
chore: Move comment as part of #6945 (noir-lang/noir#6959)
chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894)
feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952)
feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941)
feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948)
chore: add reproduction case for bignum test failure (noir-lang/noir#6464)
chore: bump `noir-gates-diff` (noir-lang/noir#6949)
feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835)
chore: also print test output to stdout in CI (noir-lang/noir#6930)
fix: Non-determinism from under constrained checks (noir-lang/noir#6945)
chore: use logs for benchmarking (noir-lang/noir#6911)
chore: bump `noir-gates-diff` (noir-lang/noir#6944)
chore: bump `noir-gates-diff` (noir-lang/noir#6943)
fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942)
chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939)
feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882)
chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 8, 2025
fix: Do not emit range check for multiplication by bool (noir-lang/noir#6983)
fix: do not panic on indices which are not valid `u32`s (noir-lang/noir#6976)
feat!: require trait method calls (`foo.bar()`) to have the trait in scope (imported) (noir-lang/noir#6895)
feat!: type-check trait default methods (noir-lang/noir#6645)
feat: `--pedantic-solving` flag (noir-lang/noir#6716)
feat!: update `aes128_encrypt` to return an array (noir-lang/noir#6973)
fix: wrong module to lookup trait when using crate or super (noir-lang/noir#6974)
fix: Start RC at 1 again (noir-lang/noir#6958)
feat!: turn TypeIsMorePrivateThenItem into an error (noir-lang/noir#6953)
fix: don't fail parsing macro if there are parser warnings (noir-lang/noir#6969)
fix: error on missing function parameters (noir-lang/noir#6967)
feat: don't report warnings for dependencies (noir-lang/noir#6926)
chore: simplify boolean in a mul of a mul (noir-lang/noir#6951)
feat(ssa): Immediately simplify away RefCount instructions in ACIR functions (noir-lang/noir#6893)
chore: Move comment as part of #6945 (noir-lang/noir#6959)
chore: Separate unconstrained functions during monomorphization (noir-lang/noir#6894)
feat!: turn CannotReexportItemWithLessVisibility into an error (noir-lang/noir#6952)
feat: lock on Nargo.toml on several nargo commands (noir-lang/noir#6941)
feat: don't simplify SSA instructions when creating them from a string (noir-lang/noir#6948)
chore: add reproduction case for bignum test failure (noir-lang/noir#6464)
chore: bump `noir-gates-diff` (noir-lang/noir#6949)
feat(test): Enable the test fuzzer for Wasm (noir-lang/noir#6835)
chore: also print test output to stdout in CI (noir-lang/noir#6930)
fix: Non-determinism from under constrained checks (noir-lang/noir#6945)
chore: use logs for benchmarking (noir-lang/noir#6911)
chore: bump `noir-gates-diff` (noir-lang/noir#6944)
chore: bump `noir-gates-diff` (noir-lang/noir#6943)
fix: Show output of `test_program_is_idempotent` on failure (noir-lang/noir#6942)
chore: delete a bunch of dead code from `noirc_evaluator` (noir-lang/noir#6939)
feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (noir-lang/noir#6882)
chore: Bump arkworks to version `0.5.0` (noir-lang/noir#6871)
TomAFrench added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 9, 2025
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat: impl Default for U128
(noir-lang/noir#6984)
fix: Do not emit range check for multiplication by bool
(noir-lang/noir#6983)
fix: do not panic on indices which are not valid `u32`s
(noir-lang/noir#6976)
feat!: require trait method calls (`foo.bar()`) to have the trait in
scope (imported) (noir-lang/noir#6895)
feat!: type-check trait default methods
(noir-lang/noir#6645)
feat: `--pedantic-solving` flag
(noir-lang/noir#6716)
feat!: update `aes128_encrypt` to return an array
(noir-lang/noir#6973)
fix: wrong module to lookup trait when using crate or super
(noir-lang/noir#6974)
fix: Start RC at 1 again (noir-lang/noir#6958)
feat!: turn TypeIsMorePrivateThenItem into an error
(noir-lang/noir#6953)
fix: don't fail parsing macro if there are parser warnings
(noir-lang/noir#6969)
fix: error on missing function parameters
(noir-lang/noir#6967)
feat: don't report warnings for dependencies
(noir-lang/noir#6926)
chore: simplify boolean in a mul of a mul
(noir-lang/noir#6951)
feat(ssa): Immediately simplify away RefCount instructions in ACIR
functions (noir-lang/noir#6893)
chore: Move comment as part of #6945
(noir-lang/noir#6959)
chore: Separate unconstrained functions during monomorphization
(noir-lang/noir#6894)
feat!: turn CannotReexportItemWithLessVisibility into an error
(noir-lang/noir#6952)
feat: lock on Nargo.toml on several nargo commands
(noir-lang/noir#6941)
feat: don't simplify SSA instructions when creating them from a string
(noir-lang/noir#6948)
chore: add reproduction case for bignum test failure
(noir-lang/noir#6464)
chore: bump `noir-gates-diff`
(noir-lang/noir#6949)
feat(test): Enable the test fuzzer for Wasm
(noir-lang/noir#6835)
chore: also print test output to stdout in CI
(noir-lang/noir#6930)
fix: Non-determinism from under constrained checks
(noir-lang/noir#6945)
chore: use logs for benchmarking
(noir-lang/noir#6911)
chore: bump `noir-gates-diff`
(noir-lang/noir#6944)
chore: bump `noir-gates-diff`
(noir-lang/noir#6943)
fix: Show output of `test_program_is_idempotent` on failure
(noir-lang/noir#6942)
chore: delete a bunch of dead code from `noirc_evaluator`
(noir-lang/noir#6939)
feat: require trait function calls (`Foo::bar()`) to have the trait in
scope (imported) (noir-lang/noir#6882)
chore: Bump arkworks to version `0.5.0`
(noir-lang/noir#6871)
END_COMMIT_OVERRIDE

---------

Co-authored-by: Michael J Klein <[email protected]>
Co-authored-by: Michael Klein <[email protected]>
Co-authored-by: Tom French <[email protected]>
Co-authored-by: Tom French <[email protected]>
Co-authored-by: Charlie Lye <[email protected]>
Co-authored-by: ludamad <[email protected]>
AztecBot added a commit to AztecProtocol/aztec-nr that referenced this pull request Jan 10, 2025
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat: impl Default for U128
(noir-lang/noir#6984)
fix: Do not emit range check for multiplication by bool
(noir-lang/noir#6983)
fix: do not panic on indices which are not valid `u32`s
(noir-lang/noir#6976)
feat!: require trait method calls (`foo.bar()`) to have the trait in
scope (imported) (noir-lang/noir#6895)
feat!: type-check trait default methods
(noir-lang/noir#6645)
feat: `--pedantic-solving` flag
(noir-lang/noir#6716)
feat!: update `aes128_encrypt` to return an array
(noir-lang/noir#6973)
fix: wrong module to lookup trait when using crate or super
(noir-lang/noir#6974)
fix: Start RC at 1 again (noir-lang/noir#6958)
feat!: turn TypeIsMorePrivateThenItem into an error
(noir-lang/noir#6953)
fix: don't fail parsing macro if there are parser warnings
(noir-lang/noir#6969)
fix: error on missing function parameters
(noir-lang/noir#6967)
feat: don't report warnings for dependencies
(noir-lang/noir#6926)
chore: simplify boolean in a mul of a mul
(noir-lang/noir#6951)
feat(ssa): Immediately simplify away RefCount instructions in ACIR
functions (noir-lang/noir#6893)
chore: Move comment as part of #6945
(noir-lang/noir#6959)
chore: Separate unconstrained functions during monomorphization
(noir-lang/noir#6894)
feat!: turn CannotReexportItemWithLessVisibility into an error
(noir-lang/noir#6952)
feat: lock on Nargo.toml on several nargo commands
(noir-lang/noir#6941)
feat: don't simplify SSA instructions when creating them from a string
(noir-lang/noir#6948)
chore: add reproduction case for bignum test failure
(noir-lang/noir#6464)
chore: bump `noir-gates-diff`
(noir-lang/noir#6949)
feat(test): Enable the test fuzzer for Wasm
(noir-lang/noir#6835)
chore: also print test output to stdout in CI
(noir-lang/noir#6930)
fix: Non-determinism from under constrained checks
(noir-lang/noir#6945)
chore: use logs for benchmarking
(noir-lang/noir#6911)
chore: bump `noir-gates-diff`
(noir-lang/noir#6944)
chore: bump `noir-gates-diff`
(noir-lang/noir#6943)
fix: Show output of `test_program_is_idempotent` on failure
(noir-lang/noir#6942)
chore: delete a bunch of dead code from `noirc_evaluator`
(noir-lang/noir#6939)
feat: require trait function calls (`Foo::bar()`) to have the trait in
scope (imported) (noir-lang/noir#6882)
chore: Bump arkworks to version `0.5.0`
(noir-lang/noir#6871)
END_COMMIT_OVERRIDE

---------

Co-authored-by: Michael J Klein <[email protected]>
Co-authored-by: Michael Klein <[email protected]>
Co-authored-by: Tom French <[email protected]>
Co-authored-by: Tom French <[email protected]>
Co-authored-by: Charlie Lye <[email protected]>
Co-authored-by: ludamad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid paths in default trait method only error when trait is implemented
2 participants