Skip to content

Commit

Permalink
chore: redo typo PR by longxiangqiao (#11109)
Browse files Browse the repository at this point in the history
Thanks longxiangqiao for
#11108. Our policy
is to redo typo changes to dissuade metric farming. This is an automated
script.
  • Loading branch information
AztecBot authored Jan 8, 2025
1 parent c78cb82 commit b8ef30e
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion aztec-nargo/compile_then_postprocess.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ fi
shift # remove the compile arg so we can inject --show-artifact-paths

# Forward all arguments to nargo, tee output to console.
# Nargo should be outputing errors to stderr, but it doesn't. Use tee to duplicate stdout to stderr to display errors.
# Nargo should be outputting errors to stderr, but it doesn't. Use tee to duplicate stdout to stderr to display errors.
artifacts_to_process=$($NARGO compile --inliner-aggressiveness 0 --show-artifact-paths $@ | tee >(cat >&2) | grep -oP 'Saved contract artifact to: \K.*')

# Postprocess each artifact
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ void ClientIVC::instantiate_stdlib_verification_queue(
*
* @param circuit The circuit to which the constraints are appended
* @param proof A stdlib proof to be recursively verified (either oink or PG)
* @param vkey The stdlib verfication key associated with the proof
* @param vkey The stdlib verification key associated with the proof
* @param type The type of the proof (equivalently, the type of the verifier)
*/
void ClientIVC::perform_recursive_verification_and_databus_consistency_checks(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ class ClientIVCTests : public ::testing::Test {
/**
* @brief A simple-as-possible test demonstrating IVC for two mock circuits
* @details When accumulating only two circuits, only a single round of folding is performed thus no recursive
* verfication occurs.
* verification occurs.
*
*/
TEST_F(ClientIVCTests, Basic)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class AvmComposer {
// The crs_factory holds the path to the srs and exposes methods to extract the srs elements
std::shared_ptr<bb::srs::factories::CrsFactory<Flavor::Curve>> crs_factory_;

// The commitment key is passed to the prover but also used herein to compute the verfication key commitments
// The commitment key is passed to the prover but also used herein to compute the verification key commitments
std::shared_ptr<CommitmentKey> commitment_key;

bool computed_witness = false;
Expand Down
2 changes: 1 addition & 1 deletion bb-pilcom/bb-pil-backend/src/relation_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ fn create_identity<F: FieldElement>(
label: &Option<String>,
indexed_aliases: &HashMap<&String, &AlgebraicExpression<F>>,
) -> Option<BBIdentity> {
// We want to read the types of operators and then create the appropiate code
// We want to read the types of operators and then create the appropriate code
if let Some(expr) = &expression.selector {
let (degree, id, col_aliases) = recurse_expression(expr, indexed_aliases, false);
collected_aliases.extend(col_aliases);
Expand Down
2 changes: 1 addition & 1 deletion bb-pilcom/bb-pil-backend/src/vm_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ struct ColumnGroups {
shifted: Vec<String>,
/// fixed + witness + shifted
all_cols_with_shifts: Vec<String>,
/// Inverses from lookups and permuations
/// Inverses from lookups and permutations
inverses: Vec<String>,
/// Public inputs (in source order)
public_inputs: Vec<(usize, String)>,
Expand Down
2 changes: 1 addition & 1 deletion bb-pilcom/bb-pil-backend/templates/composer.hpp.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class AvmComposer {
// The crs_factory holds the path to the srs and exposes methods to extract the srs elements
std::shared_ptr<bb::srs::factories::CrsFactory<Flavor::Curve>> crs_factory_;

// The commitment key is passed to the prover but also used herein to compute the verfication key commitments
// The commitment key is passed to the prover but also used herein to compute the verification key commitments
std::shared_ptr<CommitmentKey> commitment_key;

bool computed_witness = false;
Expand Down

1 comment on commit b8ef30e

@AztecBot
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: b8ef30e Previous: c1f244c Ratio
nativeconstruct_proof_ultrahonk_power_of_2/20 4631.039611000006 ms/iter 4145.21271000001 ms/iter 1.12
Goblin::merge(t) 142133784 ns/iter 133968091 ns/iter 1.06

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton

Please sign in to comment.