feat: blob sink in sandbox without extra process #11032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Maddiaa0
force-pushed
the
md/10054-blob-sink-in-process
branch
from
a51d30a to
3a4ac5f
Compare
Maddiaa0
force-pushed
the
md/10054-blob-sink-in-process
branch
2 times, most recently
from
140d3ed to
f7262ac
Compare
Maddiaa0
force-pushed
the
md/10054-blob-sink-in-process
branch
from
27c75cd to
4ab57e1
Compare
Maddiaa0
force-pushed
the
md/10054-blob-sink-in-process
branch
from
4ab57e1 to
49b37dd
Compare
LHerskind
approved these changes
Jan 9, 2025
| } | ||
|
|
||
| public async sendBlobsToBlobSink(blockHash: string, blobs: Blob[]): Promise<boolean> { | ||
| // TODO(md): for now we are assuming the indexes of the blobs will be 0, 1, 2 |
There was a problem hiding this comment.
Created issue #11116 for this.
| @@ -382,6 +383,8 @@ describe('e2e_synching', () => { | |||
| await (sequencer as any).stop(); | |||
| await watcher?.stop(); | |||
|
|
|||
| const blobSinkClient = createBlobSinkClient(`http://localhost:${blobSink?.port ?? 5052}`); | |||
There was a problem hiding this comment.
Magic 5052 multiple places in this file.
TomAFrench
added a commit
that referenced
this pull request
Jan 9, 2025
* master: (287 commits) feat: Sync from noir (#11051) chore(docs): Update tx concepts page (#10947) chore(docs): Edit Aztec.nr Guide section (#10866) chore: test:e2e defaults to no-docker (#10966) chore(avm): improve column stats (#11135) chore: Sanity checking of proving job IDs (#11134) feat: permutation argument optimizations (#10960) feat: single tx block root rollup (#11096) refactor: prover db config (#11126) feat: monitor event loop lag (#11127) chore: Greater stability at 1TPS (#10981) chore: Jest reporters for CI (#11125) fix: Sequencer times out L1 tx at end of L2 slot (#11112) feat: browser chunking (#11102) fix: Added start/stop guards to running promise and serial queue (#11120) fix: Don't retransmit txs upon node restart (#11123) fix: Prover node aborts execution at epoch end (#11111) feat: blob sink in sandbox without extra process (#11032) chore: log number of instructions executed for call in AVM. Misc fix. (#11110) git subrepo push --branch=master noir-projects/aztec-nr ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rework of #10248 after discussing with charlie
Try not to have an extra process if we dont need to and hide it behind an interface if we can.
Can interact with a blob sink, whether that is the consensus layer or the extra service. In the sandbox this will just run locally. In end to end tests it is the client that was introduced in the previous pr