Minor suggestions for the Aws quicksight data source #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0Gb (hashicorp#11847) Output from acceptance testing: ``` --- PASS: TestAccAWSFsxLustreFileSystem_disappears (410.68s) --- PASS: TestAccAWSFsxLustreFileSystem_Tags (424.71s) --- PASS: TestAccAWSFsxLustreFileSystem_basic (510.98s) --- PASS: TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime (528.59s) --- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacity (895.44s) --- PASS: TestAccAWSFsxLustreFileSystem_SecurityGroupIds (1017.37s) --- PASS: TestAccAWSFsxLustreFileSystem_ExportPath (1379.91s) --- PASS: TestAccAWSFsxLustreFileSystem_ImportPath (1520.63s) --- PASS: TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize (1701.27s) ```
`http_request_method` takes `values`, not `value`. See: https://github.com/terraform-providers/terraform-provider-aws/blob/5dc05492fa3956dbc1b02980f011f09e004e0d23/aws/resource_aws_lb_listener_rule.go#L477
…11816) Fixed link and modified sentence for readability (too many "its")
…ashicorp#11544) Ref: hashicorp#2291 Even though hashicorp#9710 fixed one case of the problem, there is another case which is harder to reproduce. When a network acl has ingress and egress with same rule number, which is valid per aws doc, if one of them missing (maybe manually deleted), then terraform plan will stop working. The main problem is there is a change in aws api and the egress filter is not supported anymore. Current doc: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeNetworkAcls.html 2017 doc: https://web.archive.org/web/20171216154650/http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeNetworkAcls.html Noted `entry.egress` is gone. So the query return the nacl with same number rule but not which correct type. Which make this for loop https://github.com/terraform-providers/terraform-provider-aws/blob/5348ed3f1c47900f18c7f457a920de5f33cf7142/aws/resource_aws_network_acl_rule.go#L298 couldn't find the correct rule and fall down to the wrong return https://github.com/terraform-providers/terraform-provider-aws/blob/5348ed3f1c47900f18c7f457a920de5f33cf7142/aws/resource_aws_network_acl_rule.go#L304 The fix simple `return nil, nil` so the rule will be deleted Output from acceptance testing: ``` --- PASS: TestAccAWSNetworkAclRule_missingParam (10.12s) --- PASS: TestAccAWSNetworkAclRule_disappears_NetworkAcl (15.26s) --- PASS: TestAccAWSNetworkAclRule_ipv6ICMP (16.77s) --- PASS: TestAccAWSNetworkAclRule_ipv6 (18.20s) --- PASS: TestAccAWSNetworkAclRule_disappears (18.34s) --- PASS: TestAccAWSNetworkAclRule_ingressEgressSameNumberDisappears (19.04s) --- PASS: TestAccAWSNetworkAclRule_basic (23.17s) --- PASS: TestAccAWSNetworkAclRule_tcpProtocol (25.58s) --- PASS: TestAccAWSNetworkAclRule_allProtocol (26.55s) --- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (29.09s) ```
…written into Terraform state (hashicorp#11650) Output from acceptance testing: ``` --- PASS: TestAccAWSDefaultSecurityGroup_basic (9.33s) --- PASS: TestAccAWSDefaultSecurityGroup_classic (12.37s) ```
…ttachment resources (hashicorp#11612) Output from acceptance testing: ``` --- PASS: TestAccAWSOrganizations/Policy (138.40s) --- PASS: TestAccAWSOrganizations/Policy/basic (32.06s) --- PASS: TestAccAWSOrganizations/Policy/concurrent (32.60s) --- PASS: TestAccAWSOrganizations/Policy/Description (29.99s) --- PASS: TestAccAWSOrganizations/Policy/Type (43.75s) --- PASS: TestAccAWSOrganizations/PolicyAttachment (94.82s) --- PASS: TestAccAWSOrganizations/PolicyAttachment/Account (40.77s) --- PASS: TestAccAWSOrganizations/PolicyAttachment/OrganizationalUnit (27.87s) --- PASS: TestAccAWSOrganizations/PolicyAttachment/Root (26.17s) ```
…icorp#11617) References: * hashicorp#11611 The AWS logs service has eventual consistency considerations. The `aws_cloudwatch_log_stream` resource immediately tries to read a stream after creation. If the stream is not found, the logs service returns a 200 OK with an empty list of streams. Since no streams are present, the `aws_cloudwatch_log_stream` resource removes the created resource from state, leading to a "produced an unexpected new value for was present, but now absent" error. With the changes in this commit, the empty list of streams in the response for the newly created resource will result in a NotFoundError being returned and a retry of the read request. A subsequent retry should hopefully be successful, leading to the state being preserved. Output from acceptance testing: ``` make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudWatchLogStream_' ... --- PASS: TestAccAWSCloudWatchLogStream_disappears_LogGroup (16.77s) --- PASS: TestAccAWSCloudWatchLogStream_disappears (19.55s) --- PASS: TestAccAWSCloudWatchLogStream_basic (19.91s) ```
…ng (hashicorp#11649) References: * hashicorp#11305 If a processor has previously been added to the extended S3 configuration for a Kinesis firehose delivery stream and an attempt is made to remove the processor for a subsequent apply, the stream resource currently attempts to pass in a processor with empty data. The UpdateDestination function in the AWS SDK rejects this processor as invalid per its schema and fails the apply. With the changes in this commit, the stream resource would remove empty processor elements before passing them up to the UpdateDestination call. This allows the empty processor elements to be removed successfully. Output from acceptance testing: ``` make testacc TEST=./aws TESTARGS='-run=TestAccAWSKinesisFirehoseDeliveryStream_' ... --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_missingProcessingConfiguration (72.65s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_OpenXJsonSerDe_Empty (84.32s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_ParquetSerDe_Empty (84.82s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_OrcSerDe_Empty (86.81s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging (92.66s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Serializer_Update (99.07s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_basic (100.02s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ErrorOutputPrefix (100.22s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Deserializer_Update (101.59s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3KmsKeyArn (104.93s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_HiveJsonSerDe_Empty (109.56s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithTags (112.94s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ExternalUpdate (114.35s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource (117.80s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_SplunkConfigUpdates (125.21s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3Updates (141.99s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basic (77.82s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3basic (88.79s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates (175.05s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithSSE (199.39s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Enabled (124.94s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates (566.48s) --- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates (706.62s) ```
… in _disappears test
…ers for Route 53 resolver rules and resolver rule associations
Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSS3Bucket_ReplicationSchemaV2' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3Bucket_ReplicationSchemaV2 -timeout 120m === RUN TestAccAWSS3Bucket_ReplicationSchemaV2 === PAUSE TestAccAWSS3Bucket_ReplicationSchemaV2 === CONT TestAccAWSS3Bucket_ReplicationSchemaV2 --- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (255.24s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 255.337s $ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupPlan_withRecoveryPointTags' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupPlan_withRecoveryPointTags -timeout 120m === RUN TestAccAwsBackupPlan_withRecoveryPointTags === PAUSE TestAccAwsBackupPlan_withRecoveryPointTags === CONT TestAccAwsBackupPlan_withRecoveryPointTags --- PASS: TestAccAwsBackupPlan_withRecoveryPointTags (62.92s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 62.964s
This reverts commit 5459f92.
…yvaluetags package (hashicorp#11913) Reference: hashicorp#10688 Output from acceptance testing (failure is reproducible locally but unrelated): ``` --- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (34.10s) --- PASS: TestAccAWSNetworkAcl_disappears (34.71s) --- PASS: TestAccAWSNetworkAcl_espProtocol (35.04s) --- PASS: TestAccAWSNetworkAcl_basic (37.94s) --- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (38.32s) --- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (39.16s) --- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (39.44s) --- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (43.76s) --- PASS: TestAccAWSNetworkAcl_ipv6Rules (43.86s) --- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (45.15s) --- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_update (70.53s) --- PASS: TestAccAWSNetworkAcl_SubnetChange (70.90s) --- PASS: TestAccAWSNetworkAcl_Subnets (75.73s) --- PASS: TestAccAWSNetworkAcl_Ingress_ConfigMode (81.14s) --- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (84.11s) --- FAIL: TestAccAWSNetworkAcl_SubnetsDelete (61.78s) testing.go:640: Step 2 error: errors during apply: Error: InvalidAssociationID.NotFound: The association ID 'aclassoc-0680583195befd52d' does not exist --- PASS: TestAccAWSDefaultNetworkAcl_basic (31.09s) --- PASS: TestAccAWSDefaultNetworkAcl_deny_ingress (31.48s) --- PASS: TestAccAWSDefaultNetworkAcl_withIpv6Ingress (31.55s) --- PASS: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (32.62s) --- PASS: TestAccAWSDefaultNetworkAcl_SubnetRemoval (62.43s) --- PASS: TestAccAWSDefaultNetworkAcl_SubnetReassign (70.95s) --- PASS: TestAccDataSourceAwsNetworkAcls_VpcID (36.42s) --- PASS: TestAccDataSourceAwsNetworkAcls_Filter (37.19s) --- PASS: TestAccDataSourceAwsNetworkAcls_Tags (38.04s) --- PASS: TestAccDataSourceAwsNetworkAcls_basic (52.66s) ```
…shicorp#11932) Reference: hashicorp#10688 Output from acceptance testing: ``` --- PASS: TestAccAWSVpnConnection_tunnelOptions (375.61s) --- PASS: TestAccAWSVpnConnection_withoutStaticRoutes (376.60s) --- PASS: TestAccAWSVpnConnection_disappears (425.76s) --- PASS: TestAccAWSVpnConnection_TransitGatewayID (489.10s) --- PASS: TestAccAWSVpnConnection_basic (821.66s) ```
…e to use keyvaluetags package (hashicorp#11931) Reference: hashicorp#10688 Output from acceptance testing: ``` --- PASS: TestAccAWSVpcEndpointService_removed (402.00s) --- PASS: TestAccAWSVpcEndpointService_basic (496.96s) --- PASS: TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags (552.52s) --- PASS: TestAccDataSourceAwsVpcEndpoint_byId (42.27s) --- PASS: TestAccDataSourceAwsVpcEndpoint_byFilter (42.46s) --- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayBasic (42.52s) --- PASS: TestAccDataSourceAwsVpcEndpoint_byTags (47.33s) --- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags (53.17s) --- PASS: TestAccDataSourceAwsVpcEndpoint_interface (198.80s) --- PASS: TestAccDataSourceAwsVpcEndpointService_interface (15.12s) --- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (15.52s) --- PASS: TestAccDataSourceAwsVpcEndpointService_custom (275.50s) ```
… use keyvaluetags package (hashicorp#11915) Reference: hashicorp#10688 Output from acceptance testing: ``` --- PASS: TestAccAWSRouteTable_panicEmptyRoute (25.53s) --- PASS: TestAccAWSRouteTable_ipv6 (39.37s) --- PASS: TestAccAWSRouteTable_vpcPeering (50.45s) --- PASS: TestAccAWSRouteTable_vgwRoutePropagation (54.85s) --- PASS: TestAccAWSRouteTable_tags (56.74s) --- PASS: TestAccAWSRouteTable_basic (71.67s) --- PASS: TestAccAWSRouteTable_Route_ConfigMode (93.39s) --- PASS: TestAccAWSRouteTable_instance (114.93s) --- PASS: TestAccAWSRouteTable_Route_TransitGatewayID (332.43s) --- PASS: TestAccDataSourceAwsRouteTable_main (32.43s) --- PASS: TestAccDataSourceAwsRouteTable_basic (49.36s) --- PASS: TestAccDataSourceAwsRouteTables (61.83s) ```
…uetags package (hashicorp#11934) Reference: hashicorp#10688 Output from acceptance testing: ``` --- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (274.60s) --- PASS: TestAccAWSSpotFleetRequest_basic (283.14s) --- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (522.10s) --- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (298.59s) --- PASS: TestAccAWSSpotFleetRequest_fleetType (282.73s) --- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (276.40s) --- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (274.55s) --- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (165.46s) --- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (174.06s) --- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (292.48s) --- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (290.78s) --- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (296.09s) --- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (289.26s) --- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (297.04s) --- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (298.03s) --- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (297.99s) --- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (62.05s) --- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (482.51s) --- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (839.04s) --- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (281.29s) --- PASS: TestAccAWSSpotFleetRequest_WithELBs (337.32s) --- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (255.23s) --- PASS: TestAccAWSSpotFleetRequest_withTags (275.65s) --- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (413.66s) --- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (369.73s) --- PASS: TestAccAWSSpotInstanceRequest_withBlockDuration (83.23s) --- PASS: TestAccAWSSpotInstanceRequest_validUntil (93.46s) --- PASS: TestAccAWSSpotInstanceRequest_withoutSpotPrice (104.36s) --- PASS: TestAccAWSSpotInstanceRequest_SubnetAndSGAndPublicIpAddress (113.97s) --- PASS: TestAccAWSSpotInstanceRequest_basic (114.64s) --- PASS: TestAccAWSSpotInstanceRequest_vpc (122.18s) --- PASS: TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes (126.37s) --- PASS: TestAccAWSSpotInstanceRequest_withLaunchGroup (126.68s) --- PASS: TestAccAWSSpotInstanceRequest_getPasswordData (247.92s) ```
…kage (hashicorp#11935) Reference: hashicorp#10688 Output from acceptance testing: ``` --- PASS: TestAccAWSVPCPeeringConnection_peerRegionAutoAccept (18.18s) --- PASS: TestAccAWSVPCPeeringConnection_failedState (18.90s) --- PASS: TestAccAWSVPCPeeringConnection_optionsNoAutoAccept (22.54s) --- PASS: TestAccAWSVPCPeeringConnection_plan (30.03s) --- PASS: TestAccAWSVPCPeeringConnection_basic (32.13s) --- PASS: TestAccAWSVPCPeeringConnection_tags (33.94s) --- PASS: TestAccAWSVPCPeeringConnection_region (35.88s) --- PASS: TestAccAWSVPCPeeringConnection_options (57.71s) --- PASS: TestAccAWSVPCPeeringConnection_accept (68.21s) ```
…ersions from terraform-plugin-sdk helper/validation package (hashicorp#12207) - FloatAtLeast => validation.FloatAtLeast - validateStringNotMatch => validation.StringDoesNotMatch Output from acceptance testing: ``` --- PASS: TestAccAWSDAXCluster_basic (713.63s) --- PASS: TestAccAWSDAXCluster_encryption_disabled (698.35s) --- PASS: TestAccAWSDAXCluster_encryption_enabled (807.20s) --- PASS: TestAccAWSDAXCluster_resize (1416.90s) --- PASS: TestAccAWSElasticacheCluster_AZMode_Memcached (570.01s) --- PASS: TestAccAWSElasticacheCluster_AZMode_Redis (618.90s) --- PASS: TestAccAWSElasticacheCluster_Engine_Memcached (574.22s) --- PASS: TestAccAWSElasticacheCluster_Engine_Redis (502.56s) --- PASS: TestAccAWSElasticacheCluster_EngineVersion_Memcached (1487.14s) --- PASS: TestAccAWSElasticacheCluster_EngineVersion_Redis (1464.30s) --- PASS: TestAccAWSElasticacheCluster_multiAZInVpc (576.46s) --- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Memcached (1172.66s) --- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Redis (922.53s) --- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Decrease (710.71s) --- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Increase (838.85s) --- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_IncreaseWithPreferredAvailabilityZones (817.83s) --- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Redis (2.64s) --- PASS: TestAccAWSElasticacheCluster_ParameterGroupName_Default (506.86s) --- PASS: TestAccAWSElasticacheCluster_Port (538.46s) --- PASS: TestAccAWSElasticacheCluster_Port_Redis_Default (621.13s) --- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone (1341.57s) --- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_InvalidAttributes (3.93s) --- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica (1292.96s) --- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica (1289.92s) --- PASS: TestAccAWSElasticacheCluster_snapshotsWithUpdates (563.50s) --- PASS: TestAccAWSElasticacheCluster_vpc (475.33s) --- PASS: TestAccAWSElasticacheReplicationGroup_basic (675.45s) --- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (9.00s) --- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (1165.93s) --- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NumNodeGroups (3573.90s) --- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (850.63s) --- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (1317.03s) --- PASS: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (1029.64s) --- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (1517.50s) --- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters (1884.26s) --- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (1958.37s) --- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (1884.11s) --- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (1011.87s) --- PASS: TestAccAWSElasticacheReplicationGroup_updateDescription (1136.78s) --- PASS: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (781.49s) --- PASS: TestAccAWSElasticacheReplicationGroup_updateNodeSize (2054.69s) --- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (949.12s) --- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (1651.66s) --- PASS: TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId (1019.37s) --- PASS: TestAccAWSElasticacheReplicationGroup_vpc (745.54s) --- PASS: TestAccAWSSagemakerEndpointConfiguration_Basic (76.34s) --- PASS: TestAccAWSSagemakerEndpointConfiguration_KmsKeyId (45.43s) --- PASS: TestAccAWSSagemakerEndpointConfiguration_ProductionVariants_AcceleratorType (87.98s) --- PASS: TestAccAWSSagemakerEndpointConfiguration_ProductionVariants_InitialVariantWeight (29.49s) --- PASS: TestAccAWSSagemakerEndpointConfiguration_Tags (51.34s) ```
…ument (support Least Outstanding Requests algorithm for Application Load Balancers) (hashicorp#11141) Output from acceptance testing: ``` --- PASS: TestAccDataSourceAWSALBTargetGroup_basic (200.51s) --- PASS: TestAccAWSALBTargetGroup_basic (21.51s) --- PASS: TestAccAWSALBTargetGroup_changeNameForceNew (47.75s) --- PASS: TestAccAWSALBTargetGroup_changePortForceNew (51.25s) --- PASS: TestAccAWSALBTargetGroup_changeProtocolForceNew (49.02s) --- PASS: TestAccAWSALBTargetGroup_changeVpcForceNew (43.55s) --- PASS: TestAccAWSALBTargetGroup_generatedName (36.73s) --- PASS: TestAccAWSALBTargetGroup_lambda (17.06s) --- PASS: TestAccAWSALBTargetGroup_lambdaMultiValueHeadersEnabled (50.30s) --- PASS: TestAccAWSALBTargetGroup_missingPortProtocolVpc (38.43s) --- PASS: TestAccAWSALBTargetGroup_namePrefix (38.05s) --- PASS: TestAccAWSALBTargetGroup_setAndUpdateSlowStart (60.30s) --- PASS: TestAccAWSALBTargetGroup_tags (39.07s) --- PASS: TestAccAWSALBTargetGroup_updateHealthCheck (41.31s) --- PASS: TestAccAWSALBTargetGroup_updateLoadBalancingAlgorithmType (75.02s) --- PASS: TestAccAWSALBTargetGroup_updateSticknessEnabled (75.67s) --- PASS: TestAccAWSLBTargetGroup_basic (17.41s) --- PASS: TestAccAWSLBTargetGroup_basicUdp (16.94s) --- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (44.95s) --- PASS: TestAccAWSLBTargetGroup_changePortForceNew (52.23s) --- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (62.13s) --- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (51.71s) --- PASS: TestAccAWSLBTargetGroup_defaults_application (24.82s) --- PASS: TestAccAWSLBTargetGroup_defaults_network (32.18s) --- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (19.99s) --- PASS: TestAccAWSLBTargetGroup_generatedName (19.61s) --- PASS: TestAccAWSLBTargetGroup_namePrefix (27.16s) --- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (64.78s) --- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (52.06s) --- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (25.47s) --- PASS: TestAccAWSLBTargetGroup_stickinessWithTCPDisabled (36.05s) --- PASS: TestAccAWSLBTargetGroup_stickinessWithTCPEnabledShouldError (30.68s) --- PASS: TestAccAWSLBTargetGroup_tags (56.23s) --- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (53.13s) --- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (45.20s) --- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (41.85s) --- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (13.44s) ```
…les (hashicorp#12228) * fix race condition in example (per recommendation in issue 7021) * fix typo
…2224) This example returns an error because: `A data resource "aws_subnet" "for-each-example" has not been declared in web.` Updating the example to use a declared resource.
retention_in_days actually has fixed values, it's not an arbitrary integer. see https://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_PutRetentionPolicy.html#API_PutRetentionPolicy_RequestSyntax
Fixing a small spelling typo
As of 30 July 2019, the default volume type for EBS volumes is GP2 https://aws.amazon.com/about-aws/whats-new/2019/07/ebs-default-volume-type-updated-to-gp2/
….go (hashicorp#12137) Remove Go panic usage from 'structure.go'.
…r encryption setting. (hashicorp#12177) * Correct default value for client-broker encryption setting. * Updated MSK docs to better explain client_broker default. While TLS_PLAINTEXT is the default, if the parent block is omitted the AWS default of TLS takes effect. The documentation did not make this clear.
…rmation-stack-set-sweepers Fix CloudFormation StackSet acceptance tests and sweepers in GovCloud
…_type_offerings (hashicorp#12139) * New Data Source: aws_ec2_instance_type_offerings Reference: hashicorp#10989 Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (15.95s) --- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (17.38s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (21.98s) --- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (23.84s) ``` * New Data Source: aws_ec2_instance_type_offering Reference: hashicorp#10989 Output from acceptance testing: ``` --- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes (15.95s) --- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_Filter (17.42s) --- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType (19.22s) ```
…eation when no tags are configured (hashicorp#12170) Previously from the acceptance testing (started Feburary 18, 2020): ``` --- FAIL: TestAccAWSMediaStoreContainer_basic (2.83s) testing.go:654: Step 0 error: errors during apply: Error: ValidationException: 1 validation error detected: Value '[]' at 'tags' failed to satisfy constraint: Member must have length greater than or equal to 1 ``` Output from acceptance testing: ``` --- PASS: TestAccAWSMediaStoreContainer_tags (127.62s) --- PASS: TestAccAWSMediaStoreContainer_basic (141.24s) ```
… IAM eventual consistency error with SNS Topic destinations (hashicorp#12171) Previous output from acceptance testing (starting January 8, 2020): ``` --- FAIL: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination (39.34s) testing.go:654: Step 2 error: errors during apply: Error: error putting Lambda Function Event Invoke Config (tf-acc-test-2587868650326248481): InvalidParameterValueException: The function's execution role does not have permissions to call Publish on arn:aws:sns:us-west-2:*******:tf-acc-test-2587868650326248481 --- FAIL: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination (38.93s) testing.go:654: Step 2 error: errors during apply: Error: error putting Lambda Function Event Invoke Config (tf-acc-test-3054348441165405395): InvalidParameterValueException: The function's execution role does not have permissions to call Publish on arn:aws:sns:us-west-2:*******:tf-acc-test-3054348441165405395 ``` Output from acceptance testing: ``` --- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_Latest (61.87s) --- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_FunctionVersion (90.83s) --- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunction (93.91s) --- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_disappears_LambdaFunctionEventInvokeConfig (94.80s) --- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_FunctionName_Arn (99.33s) --- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Swap (101.83s) --- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumEventAgeInSeconds (104.62s) --- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_Qualifier_AliasName (106.73s) --- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnFailure_Destination (107.43s) --- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_basic (110.48s) --- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_MaximumRetryAttempts (145.50s) --- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_Remove (146.86s) --- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_DestinationConfig_OnSuccess_Destination (151.83s) ```
…aseVersion argument value (hashicorp#12172) Reference: awslabs/amazon-eks-ami#423 Reference: aws/containers-roadmap#771 There is currently no lookup mechanism for these values other than the website. See referenced issue for hopeful path forward via a new SSM Parameter, although there does appear to be a delay between the AMI release and EKS API support. Previous output from acceptance testing (master and latest version testing): ``` --- FAIL: TestAccAWSEksNodeGroup_ReleaseVersion (1225.88s) testing.go:654: Step 0 error: errors during apply: Error: error creating EKS Node Group (tf-acc-test-9113909416381506697:tf-acc-test-9113909416381506697): InvalidParameterException: Requested Node Group release version 1.14.7-20190927 is invalid. Allowed release version is 1.14.8-20191213 --- FAIL: TestAccAWSEksNodeGroup_ReleaseVersion (1375.87s) testing.go:654: Step 0 error: errors during apply: Error: error creating EKS Node Group (tf-acc-test-7174874914828901519:tf-acc-test-7174874914828901519): InvalidParameterException: Requested Node Group release version 1.14.9-20200122 is invalid. Allowed release version is 1.14.8-20191213 ``` Output from acceptance testing: ``` --- PASS: TestAccAWSEksNodeGroup_ReleaseVersion (1564.18s) ```
Co-authored-by: WhiteSource Renovate <[email protected]>
…ashicorp#11094](hashicorp#11094). Modified to use keyvaluetags which for QuickSight were enabled by [hashicorp#12220](hashicorp#12220). Aligns with the [Refactor Resource Tagging Code to use keyvaluetags Package](hashicorp#10688) Added `DefaultTimeout`, 60s for now, and respective wait'n'retry functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates to hashicorp#10688, hashicorp#10990
Release note for CHANGELOG:
Modified to use keyvaluetags which for QuickSight were enabled by #12220 which aligns with the Refactor Resource Tagging Code to use keyvaluetags Package
Added
DefaultTimeout-values, only 60s for now, and modified slightly the respective wait'n'retry functionality. Seems to work brilliantly with Athena at least although the respective tests still not written.