-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Data Sources: aws_ec2_instance_type_offering and aws_ec2_instance_type_offerings #12139
Conversation
Reference: #10989 Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (15.95s) --- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (17.38s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (21.98s) --- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (23.84s) ```
Reference: #10989 Output from acceptance testing: ``` --- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes (15.95s) --- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_Filter (17.42s) --- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType (19.22s) ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes (8.75s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (9.30s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (9.44s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_Filter (9.80s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType (9.89s)
This has been released in version 2.52.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Reference: #10989
Release note for CHANGELOG:
These new data source can be used to replace our "hardcoded"
usw2-az4
Availability Zone ID blacklisting for certain EC2 Instance Types in the acceptance testing as well as allow operators to more conditionally select only available instance types in regions and availability zones.Output from acceptance testing in AWS Commercial:
Output from acceptance testing in AWS GovCloud (US):