tfproviderlint R009 check: remove Go panic usage from 'structure.go' #12137
Conversation
Remove Go panic usage from 'structure.go'.
ghost
added
size/S
| @@ -2094,9 +2094,6 @@ func getStringPtr(m interface{}, key string) *string { | |||
| s := v.(string) | |||
| return &s | |||
| } | |||
|
|
|||
| default: | |||
There was a problem hiding this comment.
Return nil instead of panicking.
There was a problem hiding this comment.
👍 Removal of this function in general will be part of #5983
| @@ -2115,56 +2112,6 @@ func (s setMap) SetString(key string, value *string) { | |||
| s[key] = *value | |||
| } | |||
|
|
|||
| // SetStringMap sets key to value as a map[string]interface{}, stripping any nil | |||
There was a problem hiding this comment.
This method is never called so remove it completely.
ewbankkit
changed the title
There was a problem hiding this comment.
Looks good, thanks @ewbankkit 🚀
Output from acceptance testing:
--- PASS: TestAccAWSElasticTranscoderPipeline_withPermissions (11.20s)
--- PASS: TestAccAWSElasticTranscoderPipeline_basic (11.55s)
--- PASS: TestAccAWSElasticTranscoderPipeline_notifications (16.97s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withContentConfig (17.36s)
--- PASS: TestAccAWSElasticTranscoderPreset_basic (20.94s)
--- PASS: TestAccAWSElasticTranscoderPipeline_kmsKey (36.22s)
| @@ -2094,9 +2094,6 @@ func getStringPtr(m interface{}, key string) *string { | |||
| s := v.(string) | |||
| return &s | |||
| } | |||
|
|
|||
| default: | |||
There was a problem hiding this comment.
👍 Removal of this function in general will be part of #5983
bflad
added
service/elastic-transcoder
technical-debt
|
This has been released in version 2.52.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Community Note
Relates #12084.
Remove Go
panic()usage fromstructure.go.Release note for CHANGELOG:
Output from acceptance testing: