Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_iam_service_linked_role: Allow aws_service_name validation to accept values in AWS partitions outside AWS Commercial and AWS GovCloud (US) #11919

Merged
merged 1 commit into from
Mar 3, 2020
Merged

resource/aws_iam_service_linked_role: Allow aws_service_name validation to accept values in AWS partitions outside AWS Commercial and AWS GovCloud (US) #11919

merged 1 commit into from
Mar 3, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 5, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10754

Release note for CHANGELOG:

* resource/aws_iam_service_linked_role: Allow `aws_service_name` argument validation to accept values in AWS partitions outside AWS Commercial and AWS GovCloud (US)

Output from acceptance testing:

--- PASS: TestAccAWSIAMServiceLinkedRole_basic (23.90s)
--- PASS: TestAccAWSIAMServiceLinkedRole_CustomSuffix (24.77s)
--- PASS: TestAccAWSIAMServiceLinkedRole_CustomSuffix_DiffSuppressFunc (25.00s)
--- PASS: TestAccAWSIAMServiceLinkedRole_Description (31.36s)

@bflad
resource/aws_iam_service_linked_role: Allow aws_service_name validati…
e153738 
…on to accept values in AWS partitions outside AWS Commercial and AWS GovCloud (US)

Reference: #10754

Output from acceptance testing:

```
--- PASS: TestAccAWSIAMServiceLinkedRole_basic (23.90s)
--- PASS: TestAccAWSIAMServiceLinkedRole_CustomSuffix (24.77s)
--- PASS: TestAccAWSIAMServiceLinkedRole_CustomSuffix_DiffSuppressFunc (25.00s)
--- PASS: TestAccAWSIAMServiceLinkedRole_Description (31.36s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/iam Issues and PRs that pertain to the iam service. partition/aws-cn Pertains to the aws-cn partition. partition/aws-iso Pertains to the aws-iso partition. partition/aws-iso-b Pertains to the aws-iso-b partition. labels Feb 5, 2020
@bflad bflad requested a review from a team February 5, 2020 22:42
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Feb 5, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Feb 5, 2020
@bflad bflad mentioned this pull request Feb 5, 2020
Closed
@bflad bflad requested a review from a team February 21, 2020 13:39
@bflad bflad added this to the v2.52.0 milestone Mar 3, 2020
@bflad bflad merged commit 10267dc into master Mar 3, 2020
@bflad bflad deleted the b-aws_iam_service_linked_role-validation branch March 3, 2020 14:02
bflad added a commit that referenced this pull request Mar 3, 2020
@bflad
Update CHANGELOG for #11919
5ce2fc7
@ghost
Copy link

ghost commented Mar 6, 2020

This has been released in version 2.52.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. partition/aws-cn Pertains to the aws-cn partition. partition/aws-iso Pertains to the aws-iso partition. partition/aws-iso-b Pertains to the aws-iso-b partition. service/iam Issues and PRs that pertain to the iam service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.52.0
Development

Successfully merging this pull request may close these issues.

IAM service-linked role creation fails for AWS China
2 participants
@bflad @paddycarver