resource/aws_alb_target_group: Add load balancing algorithm type

[dhoeric]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11019

Release note for CHANGELOG:

* resource/aws_alb_target_group: Add load balancing algorithm type

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSALBTargetGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSALBTargetGroup_ -timeout 120m
=== RUN   TestAccAWSALBTargetGroup_basic
=== PAUSE TestAccAWSALBTargetGroup_basic
=== RUN   TestAccAWSALBTargetGroup_namePrefix
=== PAUSE TestAccAWSALBTargetGroup_namePrefix
=== RUN   TestAccAWSALBTargetGroup_generatedName
=== PAUSE TestAccAWSALBTargetGroup_generatedName
=== RUN   TestAccAWSALBTargetGroup_changeNameForceNew
=== PAUSE TestAccAWSALBTargetGroup_changeNameForceNew
=== RUN   TestAccAWSALBTargetGroup_changeProtocolForceNew
=== PAUSE TestAccAWSALBTargetGroup_changeProtocolForceNew
=== RUN   TestAccAWSALBTargetGroup_changePortForceNew
=== PAUSE TestAccAWSALBTargetGroup_changePortForceNew
=== RUN   TestAccAWSALBTargetGroup_changeVpcForceNew
=== PAUSE TestAccAWSALBTargetGroup_changeVpcForceNew
=== RUN   TestAccAWSALBTargetGroup_tags
=== PAUSE TestAccAWSALBTargetGroup_tags
=== RUN   TestAccAWSALBTargetGroup_updateHealthCheck
=== PAUSE TestAccAWSALBTargetGroup_updateHealthCheck
=== RUN   TestAccAWSALBTargetGroup_updateSticknessEnabled
=== PAUSE TestAccAWSALBTargetGroup_updateSticknessEnabled
=== RUN   TestAccAWSALBTargetGroup_setAndUpdateSlowStart
=== PAUSE TestAccAWSALBTargetGroup_setAndUpdateSlowStart
=== RUN   TestAccAWSALBTargetGroup_updateLoadBalancingAlgorithmType
=== PAUSE TestAccAWSALBTargetGroup_updateLoadBalancingAlgorithmType
=== RUN   TestAccAWSALBTargetGroup_lambda
=== PAUSE TestAccAWSALBTargetGroup_lambda
=== RUN   TestAccAWSALBTargetGroup_lambdaMultiValueHeadersEnabled
=== PAUSE TestAccAWSALBTargetGroup_lambdaMultiValueHeadersEnabled
=== RUN   TestAccAWSALBTargetGroup_missingPortProtocolVpc
=== PAUSE TestAccAWSALBTargetGroup_missingPortProtocolVpc
=== CONT  TestAccAWSALBTargetGroup_basic
=== CONT  TestAccAWSALBTargetGroup_updateHealthCheck
=== CONT  TestAccAWSALBTargetGroup_lambda
--- PASS: TestAccAWSALBTargetGroup_basic (33.42s)
=== CONT  TestAccAWSALBTargetGroup_setAndUpdateSlowStart
--- PASS: TestAccAWSALBTargetGroup_lambda (34.25s)
=== CONT  TestAccAWSALBTargetGroup_updateLoadBalancingAlgorithmType
--- PASS: TestAccAWSALBTargetGroup_updateHealthCheck (55.11s)
=== CONT  TestAccAWSALBTargetGroup_missingPortProtocolVpc
--- PASS: TestAccAWSALBTargetGroup_setAndUpdateSlowStart (48.45s)
=== CONT  TestAccAWSALBTargetGroup_lambdaMultiValueHeadersEnabled
--- PASS: TestAccAWSALBTargetGroup_missingPortProtocolVpc (32.19s)
=== CONT  TestAccAWSALBTargetGroup_updateSticknessEnabled
--- PASS: TestAccAWSALBTargetGroup_updateLoadBalancingAlgorithmType (67.02s)
=== CONT  TestAccAWSALBTargetGroup_changeProtocolForceNew
--- PASS: TestAccAWSALBTargetGroup_lambdaMultiValueHeadersEnabled (68.42s)
=== CONT  TestAccAWSALBTargetGroup_tags
--- PASS: TestAccAWSALBTargetGroup_changeProtocolForceNew (51.62s)
=== CONT  TestAccAWSALBTargetGroup_changeVpcForceNew
--- PASS: TestAccAWSALBTargetGroup_updateSticknessEnabled (71.22s)
=== CONT  TestAccAWSALBTargetGroup_changePortForceNew
--- PASS: TestAccAWSALBTargetGroup_tags (53.01s)
=== CONT  TestAccAWSALBTargetGroup_changeNameForceNew
--- PASS: TestAccAWSALBTargetGroup_changeVpcForceNew (52.08s)
=== CONT  TestAccAWSALBTargetGroup_namePrefix
--- PASS: TestAccAWSALBTargetGroup_changePortForceNew (52.12s)
=== CONT  TestAccAWSALBTargetGroup_generatedName
--- PASS: TestAccAWSALBTargetGroup_namePrefix (26.80s)
--- PASS: TestAccAWSALBTargetGroup_generatedName (27.43s)
--- PASS: TestAccAWSALBTargetGroup_changeNameForceNew (46.78s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       250.139s

[piotrb]

eh .. Poke? :)

It's been 28 days since any activity on this PR .. we're waiting for TF support for least_outstanding_requests algorithm :) I don't really see what is holding this back .. perhaps its just fallen through a crack?

[Y-Tian]

+1 What's the ETA on this feature? Anything we can do to help?

[simontabor]

Does anybody know if there's a way to use this branch in a project? I'm assuming not but I need this functionality ASAP.

[piotrb]

I think we can safely drop the ForceNew flag from this new setting .. why did you decide to put it in?

[piotrb]

Does anybody know if there's a way to use this branch in a project? I'm assuming not but I need this functionality ASAP.

There isn't a super straightforward way .. but the repo's build instructions are quite simple .. and then you need to drop it into your ~/.terraform.d/plugins folder following the proper conventions .. it's a bit finicky but works ..

[piotrb]

I've been using this through an overridden provider and it looks good. Let's get this out please :)

[dhoeric]

Does anybody know if there's a way to use this branch in a project? I'm assuming not but I need this functionality ASAP.

Just continue on @piotrb's commented. You can checkout my branch and build it as a "custom" provider, commands:

make build
go build -o terraform-provider-aws
mv terraform-provider-aws ~/.terraform.d/plugins

# run terraform plan :)

Reference:
https://www.terraform.io/docs/extend/writing-custom-providers.html#building-the-plugin
https://www.terraform.io/docs/configuration/providers.html#third-party-plugins

[bflad]

Hi @dhoeric 👋 Thank you for submitting this. Please see the below feedback items and let us know if you have any questions or do not have time to implement them. 👍

[dhoeric]

@bflad Thanks for your comments.
Here are the result on TestAccAWSALBTargetGroup_ and TestAccAWSLBTargetGroup_

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSALBTargetGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 10 -run=TestAccAWSALBTargetGroup_ -timeout 120m
=== RUN   TestAccAWSALBTargetGroup_basic
=== PAUSE TestAccAWSALBTargetGroup_basic
=== RUN   TestAccAWSALBTargetGroup_namePrefix
=== PAUSE TestAccAWSALBTargetGroup_namePrefix
=== RUN   TestAccAWSALBTargetGroup_generatedName
=== PAUSE TestAccAWSALBTargetGroup_generatedName
=== RUN   TestAccAWSALBTargetGroup_changeNameForceNew
=== PAUSE TestAccAWSALBTargetGroup_changeNameForceNew
=== RUN   TestAccAWSALBTargetGroup_changeProtocolForceNew
=== PAUSE TestAccAWSALBTargetGroup_changeProtocolForceNew
=== RUN   TestAccAWSALBTargetGroup_changePortForceNew
=== PAUSE TestAccAWSALBTargetGroup_changePortForceNew
=== RUN   TestAccAWSALBTargetGroup_changeVpcForceNew
=== PAUSE TestAccAWSALBTargetGroup_changeVpcForceNew
=== RUN   TestAccAWSALBTargetGroup_tags
=== PAUSE TestAccAWSALBTargetGroup_tags
=== RUN   TestAccAWSALBTargetGroup_updateHealthCheck
=== PAUSE TestAccAWSALBTargetGroup_updateHealthCheck
=== RUN   TestAccAWSALBTargetGroup_updateSticknessEnabled
=== PAUSE TestAccAWSALBTargetGroup_updateSticknessEnabled
=== RUN   TestAccAWSALBTargetGroup_setAndUpdateSlowStart
=== PAUSE TestAccAWSALBTargetGroup_setAndUpdateSlowStart
=== RUN   TestAccAWSALBTargetGroup_updateLoadBalancingAlgorithmType
=== PAUSE TestAccAWSALBTargetGroup_updateLoadBalancingAlgorithmType
=== RUN   TestAccAWSALBTargetGroup_lambda
=== PAUSE TestAccAWSALBTargetGroup_lambda
=== RUN   TestAccAWSALBTargetGroup_lambdaMultiValueHeadersEnabled
=== PAUSE TestAccAWSALBTargetGroup_lambdaMultiValueHeadersEnabled
=== RUN   TestAccAWSALBTargetGroup_missingPortProtocolVpc
=== PAUSE TestAccAWSALBTargetGroup_missingPortProtocolVpc
=== CONT  TestAccAWSALBTargetGroup_basic
=== CONT  TestAccAWSALBTargetGroup_updateHealthCheck
=== CONT  TestAccAWSALBTargetGroup_lambda
=== CONT  TestAccAWSALBTargetGroup_missingPortProtocolVpc
=== CONT  TestAccAWSALBTargetGroup_lambdaMultiValueHeadersEnabled
=== CONT  TestAccAWSALBTargetGroup_changeProtocolForceNew
=== CONT  TestAccAWSALBTargetGroup_tags
=== CONT  TestAccAWSALBTargetGroup_changeVpcForceNew
=== CONT  TestAccAWSALBTargetGroup_changePortForceNew
=== CONT  TestAccAWSALBTargetGroup_setAndUpdateSlowStart
--- PASS: TestAccAWSALBTargetGroup_basic (35.67s)
=== CONT  TestAccAWSALBTargetGroup_updateLoadBalancingAlgorithmType
--- PASS: TestAccAWSALBTargetGroup_lambda (39.02s)
=== CONT  TestAccAWSALBTargetGroup_updateSticknessEnabled
--- PASS: TestAccAWSALBTargetGroup_missingPortProtocolVpc (42.80s)
=== CONT  TestAccAWSALBTargetGroup_generatedName
--- PASS: TestAccAWSALBTargetGroup_updateHealthCheck (59.66s)
=== CONT  TestAccAWSALBTargetGroup_changeNameForceNew
--- PASS: TestAccAWSALBTargetGroup_tags (60.84s)
=== CONT  TestAccAWSALBTargetGroup_namePrefix
--- PASS: TestAccAWSALBTargetGroup_changePortForceNew (60.86s)
--- PASS: TestAccAWSALBTargetGroup_setAndUpdateSlowStart (60.92s)
--- PASS: TestAccAWSALBTargetGroup_changeProtocolForceNew (61.07s)
--- PASS: TestAccAWSALBTargetGroup_changeVpcForceNew (61.90s)
--- PASS: TestAccAWSALBTargetGroup_generatedName (34.78s)
--- PASS: TestAccAWSALBTargetGroup_lambdaMultiValueHeadersEnabled (82.23s)
--- PASS: TestAccAWSALBTargetGroup_namePrefix (32.41s)
--- PASS: TestAccAWSALBTargetGroup_changeNameForceNew (56.70s)
--- PASS: TestAccAWSALBTargetGroup_updateLoadBalancingAlgorithmType (81.43s)
--- PASS: TestAccAWSALBTargetGroup_updateSticknessEnabled (79.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	118.657s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLBTargetGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 10 -run=TestAccAWSLBTargetGroup_ -timeout 120m
=== RUN   TestAccAWSLBTargetGroup_basic
=== PAUSE TestAccAWSLBTargetGroup_basic
=== RUN   TestAccAWSLBTargetGroup_basicUdp
=== PAUSE TestAccAWSLBTargetGroup_basicUdp
=== RUN   TestAccAWSLBTargetGroup_withoutHealthcheck
=== PAUSE TestAccAWSLBTargetGroup_withoutHealthcheck
=== RUN   TestAccAWSLBTargetGroup_networkLB_TargetGroup
=== PAUSE TestAccAWSLBTargetGroup_networkLB_TargetGroup
=== RUN   TestAccAWSLBTargetGroup_Protocol_Tls
=== PAUSE TestAccAWSLBTargetGroup_Protocol_Tls
=== RUN   TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy
=== PAUSE TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy
=== RUN   TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck
=== PAUSE TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck
=== RUN   TestAccAWSLBTargetGroup_namePrefix
=== PAUSE TestAccAWSLBTargetGroup_namePrefix
=== RUN   TestAccAWSLBTargetGroup_generatedName
=== PAUSE TestAccAWSLBTargetGroup_generatedName
=== RUN   TestAccAWSLBTargetGroup_changeNameForceNew
=== PAUSE TestAccAWSLBTargetGroup_changeNameForceNew
=== RUN   TestAccAWSLBTargetGroup_changeProtocolForceNew
=== PAUSE TestAccAWSLBTargetGroup_changeProtocolForceNew
=== RUN   TestAccAWSLBTargetGroup_changePortForceNew
=== PAUSE TestAccAWSLBTargetGroup_changePortForceNew
=== RUN   TestAccAWSLBTargetGroup_changeVpcForceNew
=== PAUSE TestAccAWSLBTargetGroup_changeVpcForceNew
=== RUN   TestAccAWSLBTargetGroup_tags
=== PAUSE TestAccAWSLBTargetGroup_tags
=== RUN   TestAccAWSLBTargetGroup_enableHealthCheck
=== PAUSE TestAccAWSLBTargetGroup_enableHealthCheck
=== RUN   TestAccAWSLBTargetGroup_updateHealthCheck
=== PAUSE TestAccAWSLBTargetGroup_updateHealthCheck
=== RUN   TestAccAWSLBTargetGroup_updateSticknessEnabled
=== PAUSE TestAccAWSLBTargetGroup_updateSticknessEnabled
=== RUN   TestAccAWSLBTargetGroup_defaults_application
=== PAUSE TestAccAWSLBTargetGroup_defaults_application
=== RUN   TestAccAWSLBTargetGroup_defaults_network
=== PAUSE TestAccAWSLBTargetGroup_defaults_network
=== RUN   TestAccAWSLBTargetGroup_stickinessWithTCPDisabled
=== PAUSE TestAccAWSLBTargetGroup_stickinessWithTCPDisabled
=== RUN   TestAccAWSLBTargetGroup_stickinessWithTCPEnabledShouldError
=== PAUSE TestAccAWSLBTargetGroup_stickinessWithTCPEnabledShouldError
=== CONT  TestAccAWSLBTargetGroup_basic
=== CONT  TestAccAWSLBTargetGroup_changePortForceNew
=== CONT  TestAccAWSLBTargetGroup_defaults_application
=== CONT  TestAccAWSLBTargetGroup_stickinessWithTCPEnabledShouldError
=== CONT  TestAccAWSLBTargetGroup_stickinessWithTCPDisabled
=== CONT  TestAccAWSLBTargetGroup_defaults_network
=== CONT  TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck
=== CONT  TestAccAWSLBTargetGroup_changeProtocolForceNew
=== CONT  TestAccAWSLBTargetGroup_changeNameForceNew
=== CONT  TestAccAWSLBTargetGroup_generatedName
=== CONT  TestAccAWSLBTargetGroup_namePrefix
--- PASS: TestAccAWSLBTargetGroup_stickinessWithTCPEnabledShouldError (12.43s)
--- PASS: TestAccAWSLBTargetGroup_stickinessWithTCPDisabled (34.48s)
=== CONT  TestAccAWSLBTargetGroup_networkLB_TargetGroup
--- PASS: TestAccAWSLBTargetGroup_basic (34.80s)
=== CONT  TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy
--- PASS: TestAccAWSLBTargetGroup_defaults_application (34.86s)
=== CONT  TestAccAWSLBTargetGroup_Protocol_Tls
--- PASS: TestAccAWSLBTargetGroup_generatedName (34.89s)
=== CONT  TestAccAWSLBTargetGroup_enableHealthCheck
--- PASS: TestAccAWSLBTargetGroup_namePrefix (32.45s)
=== CONT  TestAccAWSLBTargetGroup_updateSticknessEnabled
--- PASS: TestAccAWSLBTargetGroup_defaults_network (45.42s)
=== CONT  TestAccAWSLBTargetGroup_updateHealthCheck
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (58.33s)
=== CONT  TestAccAWSLBTargetGroup_tags
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (58.92s)
=== CONT  TestAccAWSLBTargetGroup_withoutHealthcheck
=== CONT  TestAccAWSLBTargetGroup_basicUdp
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (59.02s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (59.57s)
=== CONT  TestAccAWSLBTargetGroup_changeVpcForceNew
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (32.10s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (51.10s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (30.21s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (55.52s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (31.75s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (59.07s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (73.19s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (60.39s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (95.12s)
--- PASS: TestAccAWSLBTargetGroup_tags (91.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	149.804s

[bflad]

Looks great, thanks so much, @dhoeric 🚀

Output from acceptance testing:

--- PASS: TestAccDataSourceAWSALBTargetGroup_basic (200.51s)

--- PASS: TestAccAWSALBTargetGroup_basic (21.51s)
--- PASS: TestAccAWSALBTargetGroup_changeNameForceNew (47.75s)
--- PASS: TestAccAWSALBTargetGroup_changePortForceNew (51.25s)
--- PASS: TestAccAWSALBTargetGroup_changeProtocolForceNew (49.02s)
--- PASS: TestAccAWSALBTargetGroup_changeVpcForceNew (43.55s)
--- PASS: TestAccAWSALBTargetGroup_generatedName (36.73s)
--- PASS: TestAccAWSALBTargetGroup_lambda (17.06s)
--- PASS: TestAccAWSALBTargetGroup_lambdaMultiValueHeadersEnabled (50.30s)
--- PASS: TestAccAWSALBTargetGroup_missingPortProtocolVpc (38.43s)
--- PASS: TestAccAWSALBTargetGroup_namePrefix (38.05s)
--- PASS: TestAccAWSALBTargetGroup_setAndUpdateSlowStart (60.30s)
--- PASS: TestAccAWSALBTargetGroup_tags (39.07s)
--- PASS: TestAccAWSALBTargetGroup_updateHealthCheck (41.31s)
--- PASS: TestAccAWSALBTargetGroup_updateLoadBalancingAlgorithmType (75.02s)
--- PASS: TestAccAWSALBTargetGroup_updateSticknessEnabled (75.67s)

--- PASS: TestAccAWSLBTargetGroup_basic (17.41s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (16.94s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (44.95s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (52.23s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (62.13s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (51.71s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (24.82s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (32.18s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (19.99s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (19.61s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (27.16s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (64.78s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (52.06s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (25.47s)
--- PASS: TestAccAWSLBTargetGroup_stickinessWithTCPDisabled (36.05s)
--- PASS: TestAccAWSLBTargetGroup_stickinessWithTCPEnabledShouldError (30.68s)
--- PASS: TestAccAWSLBTargetGroup_tags (56.23s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (53.13s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (45.20s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (41.85s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (13.44s)

[lizthegrey]

Thanks a million!

[ghost]

This has been released in version 2.52.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!