Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_default_security_group : missing description attribute #11650

Merged
merged 1 commit into from
Feb 6, 2020
Merged

aws_default_security_group : missing description attribute #11650

merged 1 commit into from
Feb 6, 2020

Conversation

david-wells-1
Copy link
Contributor

@david-wells-1 david-wells-1 commented Jan 17, 2020

The terraform aws provider supports as an output (and detailed in the documentation) the description of the default security group, but there is an error when the output is used

The description should be computed and not allowed to be amended

PR corrects this issue and allows default security group description output on apply. No change to description in a terraform plan after the first apply.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11564

Release note for CHANGELOG:

resource aws_default_security_group : missing description attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDefaultSecurityGroup_basic'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSDefaultSecurityGroup_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSDefaultSecurityGroup_basic
=== PAUSE TestAccAWSDefaultSecurityGroup_basic
=== CONT  TestAccAWSDefaultSecurityGroup_basic
--- PASS: TestAccAWSDefaultSecurityGroup_basic (68.33s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	68.380s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.008s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.020s [no tests to run]

...

@david-wells-1 david-wells-1 requested a review from a team January 17, 2020 23:24
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Jan 17, 2020
@bflad bflad added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 18, 2020
@david-wells-1 david-wells-1 changed the title test aws_default_security_group : missing description attribute Jan 18, 2020
@david-wells-1
Copy link
Contributor Author

@bflad can you take a look at this bugfix PR, thanks

@bflad bflad added this to the v2.48.0 milestone Feb 6, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix, @david-wells-1 🚀

Output from acceptance testing:

--- PASS: TestAccAWSDefaultSecurityGroup_basic (9.33s)
--- PASS: TestAccAWSDefaultSecurityGroup_classic (12.37s)

@bflad bflad merged commit 91d75b3 into hashicorp:master Feb 6, 2020
bflad added a commit that referenced this pull request Feb 6, 2020
@ghost
Copy link

ghost commented Feb 7, 2020

This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource aws_default_security_group : missing description attribute
2 participants