Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor suggestions for the Aws quicksight data source #1

Open
wants to merge 1,635 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 40 commits
Commits
Show all changes
1635 commits
Select commit Hold shift + click to select a range
e8591d6
Update CHANGELOG for #11889
bflad Feb 6, 2020
bcd2975
resource/aws_fsx_lustre_file_system: Lower minimum storage cap to 120…
slapula Feb 6, 2020
105db4c
Update CHANGELOG for #11847
bflad Feb 6, 2020
2656d36
fix typo in aws_lb_listener_rule doc (#11856)
natict Feb 6, 2020
d6df033
docs/provider: Fixed link and modified sentence in README (#11816)
bateller Feb 6, 2020
b27d36e
resource/aws_network_acl_rule: Fix provider error when missing rule (…
voanhduy1512 Feb 6, 2020
d0d4464
Update CHANGELOG for #11544
bflad Feb 6, 2020
91d75b3
resource/aws_default_security_group: Ensure description attribute is …
david-wells-1 Feb 6, 2020
d9be981
Update CHANGELOG for #11650
bflad Feb 6, 2020
3c0deb7
services/organization: Support TAG_POLICY type in policy and policy a…
ericksoen Feb 6, 2020
fd31f7d
Update CHANGELOG for #11612
bflad Feb 6, 2020
4cc7019
resource/aws_cloudwatch_log_stream: Prevent early state removal (#11617)
camlow325 Feb 6, 2020
633378e
Update CHANGELOG for #11617
bflad Feb 6, 2020
703cce7
update to re-create resoure when lambda policy sid not found
Feb 6, 2020
c4b6a42
go fmt
Feb 6, 2020
4bdfa72
resource/aws_kinesis_firehose_delivery_stream: Allow processor cleari…
camlow325 Feb 6, 2020
3452fde
Update CHANGELOG for #11649
bflad Feb 6, 2020
30380f9
Merge branch 'master' into 11207_import_aws_batch_job_definition
bflad Feb 6, 2020
13711bb
tests/resource/aws_batch_job_queue: Revert errant ImportState testing…
bflad Feb 6, 2020
9299909
Merge branch '11207_import_aws_batch_job_definition'
bflad Feb 6, 2020
18b6e4f
Update CHANGELOG for #11407
bflad Feb 6, 2020
c25ce4b
v2.48.0
Feb 7, 2020
8b3ffa6
Fixes Route 53 resolver endpoint sweeper to return errors. Adds sweep…
gdavison Feb 7, 2020
ba65aab
Cleanup after v2.48.0 release
Feb 7, 2020
5459f92
r/aws_s3_bucket_object: Refactor to use keyvaluetags package.
Feb 6, 2020
e475f6b
Replace 'tagsMapToHash' with 'KeyValueTags.Hash' method.
ewbankkit Feb 7, 2020
2c6e5a1
Revert "r/aws_s3_bucket_object: Refactor to use keyvaluetags package."
ewbankkit Feb 7, 2020
b1c0ddd
Tidy up use of keyvaluetags.
ewbankkit Feb 7, 2020
93ebae8
r/_aws_s3_bucket_metric: Refactor to use keyvaluetags package.
ewbankkit Feb 7, 2020
41c8400
Removes panics adding during debugging
gdavison Feb 7, 2020
8530b2f
Refactors to use keyvaluetags package
gdavison Feb 7, 2020
afa3bf7
New Service: WorkMail (#11958)
Feb 7, 2020
f0b662c
Update module bflad/tfproviderdocs to v0.5.0 (#11978)
renovate[bot] Feb 10, 2020
9391bbb
docs/data-source/aws_kms_secrets: use identical text string for file …
ericksoen Feb 10, 2020
a941f3e
docs/resource/aws_codebuild_project: Fix documentation example for 's…
ewbankkit Feb 10, 2020
e726dcb
Fix CHANGELOG entry for #9877
bflad Feb 10, 2020
e228270
Update module golangci/golangci-lint to v1.23.4 (#11979)
renovate[bot] Feb 10, 2020
b476662
Add documentation on custom keyvaluetags functions. (#11974)
ewbankkit Feb 10, 2020
18c7fd4
Adds TEST_COUNT makefile parameter
gdavison Feb 10, 2020
5a315da
Merge pull request #11983 from terraform-providers/t-repeat-acc-tests
gdavison Feb 10, 2020
67e501b
docs/resource/aws_lb_listener_rule: Fix attribute names (#11985)
danieladams456 Feb 10, 2020
160c3bc
Merge pull request #11963 from ewbankkit/s3-metrics-keyvaluetags
gdavison Feb 10, 2020
4cb1211
Merge pull request #11916 from ewbankkit/s3-keyvaluetags
gdavison Feb 10, 2020
c24dbc4
resource/aws_gamelift_fleet: Add tags argument (#11559)
DrFaust92 Feb 10, 2020
ae462b1
Update CHANGELOG for #11559
bflad Feb 10, 2020
fd754cb
aws/resource_aws_route53_record.go: update change record set to use S…
abhinavdahiya Feb 10, 2020
dced906
Update CHANGELOG for #11895
bflad Feb 10, 2020
16d8bf2
resource/aws_neptune_cluster: Add enable_cloudwatch_logs_exports argu…
ericksoen Feb 11, 2020
5e3b903
Update CHANGELOG for #11949
bflad Feb 11, 2020
b7592c0
Merge pull request #11948 from terraform-providers/bt-route53-resolver
gdavison Feb 11, 2020
8128181
resource/aws_rds_global_database: Allow Aurora MySQL 5.7 as a Global …
fishfacemcgee Feb 11, 2020
be06482
Update CHANGELOG for #11790
bflad Feb 11, 2020
edee255
resource/aws_db_instance: Enable RDS MSSQL agent log export to CloudW…
Feb 11, 2020
a072423
Update CHANGELOG for #11472
bflad Feb 11, 2020
952e7ac
data-source/aws_api_gateway_rest_api: Add attributes (#10971)
DrFaust92 Feb 11, 2020
c275eb7
Update CHANGELOG for 10971
bflad Feb 11, 2020
226f2e0
docs/data-source/aws_api_gateway_rest_api: Alphabetize attributes and…
bflad Feb 11, 2020
9729804
resource/aws_db_instance: Add delete_automated_backups argument (#8461)
MrLunar Feb 11, 2020
89899e2
Update CHANGELOG for #8461
bflad Feb 11, 2020
b0b7901
resource/aws_neptune_cluster: Add deletion_protection argument (#11731)
DrFaust92 Feb 11, 2020
f1e905a
Update CHANGELOG for #11731
bflad Feb 11, 2020
6762748
data-source/aws_route53_zone: Filter on tags is containment, not exac…
ewbankkit Feb 11, 2020
d2059b5
Update CHANGELOG for #11953
bflad Feb 11, 2020
d084902
tests/provider: Increase make test timeout for Docker environments (#…
Puneeth-n Feb 11, 2020
c0484f9
docs/resource/aws_kinesis_firehose_delivery_stream: Fixed Splunk conf…
jurajseffer Feb 11, 2020
63afda9
New Resource: aws_codestarnotifications_notification_rule (#10991)
spirius Feb 11, 2020
6ea48bd
Update CHANGELOG for #10991
bflad Feb 11, 2020
d68172a
internal/keyvaluetags: Fix CodestarnotificationsUpdateTags generation…
bflad Feb 11, 2020
04603cf
Removes hardcoded partition checks and uses error values and acceptan…
gdavison Feb 11, 2020
80972f9
Merge branch 'master' into f-s3-storage-analytics
gdavison Feb 12, 2020
d7b77ed
docs/provider: Fix and enable markdownlint rules MD003, MD018, MD019,…
bflad Feb 12, 2020
c4f3d29
Merge pull request #11874 from terraform-providers/f-s3-storage-analy…
gdavison Feb 12, 2020
9c4b6a0
Update CHANGELOG for #11874
gdavison Feb 12, 2020
fbd9336
resource/aws_launch_template: Add `cpu_options` configuration block (…
praveensastry Feb 12, 2020
678636a
Update CHANGELOG for #6552
bflad Feb 12, 2020
d59c9f3
resource/aws_launch_configuration: Fix regression from version 2.22.0…
jc-asdf Feb 12, 2020
10c9ffb
Update CHANGELOG for #9810
bflad Feb 12, 2020
c7afe57
tests/resource/aws_launch_configuration: Refactor TestAccAWSLaunchCon…
bflad Feb 12, 2020
e65315b
resource/aws_instance: Add `hibernation` argument (#6961)
hawknewton Feb 12, 2020
1e03c68
Update CHANGELOG for #6961
bflad Feb 12, 2020
d6263e8
tests/resource/aws_instance: Refactor TestAccAWSInstance_hibernation …
bflad Feb 12, 2020
4acb898
service/s3: Refactor S3 Bucket Object data source and resource to use…
ewbankkit Feb 12, 2020
a3b019b
Update module golangci/golangci-lint to v1.23.6 (#11981)
renovate[bot] Feb 12, 2020
7fee424
resource/aws_cognito_user_pool: Allow admin_create_user_config config…
bflad Feb 12, 2020
94c44c1
Update CHANGELOG for #12001
bflad Feb 12, 2020
94c291c
resource/aws_batch_job_definition: Prevent extraneous differences wit…
bflad Feb 12, 2020
a49cc89
Update CHANGELOG for #12000
bflad Feb 12, 2020
494a14c
resource/aws_launch_configuration: Allow missing EC2 Image during roo…
bflad Feb 12, 2020
30aaaa3
Update CHANGELOG for #12009 and #9810
bflad Feb 12, 2020
efabb45
Adds default S3 bucket name to S3 sweeper
gdavison Feb 12, 2020
6eeb6b0
Updates ELB access log bucket names to match S3 sweeper patterns
gdavison Feb 12, 2020
ed6cbd1
Updates ALB and NLB access log bucket names to match S3 sweeper patterns
gdavison Feb 13, 2020
107e9c7
Updates Athena database and Athena named query bucket names to match …
gdavison Feb 13, 2020
2f6d5ae
Updates Redshift bucket names to match S3 sweeper patterns
gdavison Feb 13, 2020
6d7548a
Updates Global Accelerator flow log bucket names to match S3 sweeper …
gdavison Feb 13, 2020
f6fcbaa
Updates Macie S3 association bucket names to match S3 sweeper patterns
gdavison Feb 13, 2020
039bc8f
Updates Elastic Transcoder bucket names to match S3 sweeper patterns
gdavison Feb 13, 2020
7932f97
Passes correct number of subnets to test
gdavison Feb 13, 2020
0efdad0
Merge pull request #11821 from terraform-providers/bt-aws-glue-govclo…
gdavison Feb 13, 2020
bbb94c0
Converts LB subnets to use splat expressions
gdavison Feb 13, 2020
f7ec773
Compiles regexp once
gdavison Feb 13, 2020
992243e
Adds `terraform-remote-s3-test` pattern for S3 backend
gdavison Feb 13, 2020
af3cf11
Merge pull request #12040 from terraform-providers/bt-update-subnets
gdavison Feb 13, 2020
f0f3048
v2.49.0
Feb 14, 2020
fad61d4
Cleanup after v2.49.0 release
Feb 14, 2020
da0ae7d
add acceptance tests
Feb 14, 2020
85962e2
resource/aws_ram_resource_share_accepter: Minor PR review feedback ch…
bflad Feb 18, 2020
8990bfb
Merge branch 'fix_ram_share_issue_10064'
bflad Feb 18, 2020
7804e33
Update CHANGELOG for #11562
bflad Feb 18, 2020
f20dbfe
update r/aws_globalaccelerator_endpoint_group documentation (#12063)
jeet-parekh Feb 18, 2020
270640c
Update the syntax of the examples in sns_topic_subscription to terraf…
grimm26 Feb 18, 2020
0f134ea
Be clear about type for aws_subnet_ids (#12020)
henninge Feb 18, 2020
0fb8457
Merge pull request #12014 from terraform-providers/b-add-s3-random-na…
gdavison Feb 18, 2020
df01b75
Merge pull request #12041 from terraform-providers/b-s3-names-for-swe…
gdavison Feb 18, 2020
89791ba
Fix Doc: InvalidParameterValue: 'MaxAgeRule' and 'MaxCountRule' canno…
ashishmohite Feb 18, 2020
4820e6f
changes
Feb 18, 2020
a3c7502
Merge pull request #11924 from ansoni/issue/11008
gdavison Feb 19, 2020
9f67e78
Update CHANGELOG for #11924
gdavison Feb 19, 2020
e73c302
Update module hashicorp/terraform-plugin-sdk to v1.7.0 (#12012)
renovate[bot] Feb 19, 2020
d67a26f
Update module bflad/tfproviderlint to v0.10.0 (#12074)
renovate[bot] Feb 19, 2020
28664c0
Limits directories for sweepers to just `./aws`
gdavison Feb 19, 2020
7b3b49a
internal/naming: New package for shared naming logic (#12052)
bflad Feb 20, 2020
324fe0d
Update CHANGELOG for #12052
bflad Feb 20, 2020
0164c07
service/sfn: Fixes for tfproviderlint R006 (#12047)
bflad Feb 20, 2020
39ef07c
resource/aws_ssm_document: Fixes for tfproviderlint R006 (#12046)
bflad Feb 20, 2020
fa9f7f0
resource/aws_redshift_snapshot_copy_grant: Fixes for tfproviderlint R…
bflad Feb 20, 2020
6f3de6f
resource/aws_lambda_permission: Fixes for tfproviderlint R006 (#12044)
bflad Feb 20, 2020
d40fad2
resource/aws_iam_policy_attachment: Fixes for tfproviderlint R006 (#1…
bflad Feb 20, 2020
dab6065
resource/aws_codedeploy_deployment_group: Fixes for tfproviderlint R0…
bflad Feb 20, 2020
72127d9
tests/resource/aws_organizations_policy: Add missing testAccOrganizat…
bflad Feb 20, 2020
7d1d7a0
tests/resource/aws_launch_template: Add sweeper (#11962)
bflad Feb 20, 2020
4a56bc2
docs/guides/custom-service-endpoints: Use fully HTML list for Terrafo…
bflad Feb 20, 2020
249000f
Make weight in default_capacity_provider_strategy optional. (#12091)
Jo-Con-El Feb 20, 2020
b56581a
Update default EBS Volume type (#12092)
cwebster2 Feb 20, 2020
7ca8247
Merge branch 'lambda_alias' of ssh://github.com/mnkyl/terraform-provi…
bflad Feb 20, 2020
8774370
data-source/aws_lambda_alias: Modernization for codebase and testing …
bflad Feb 20, 2020
082675d
Merge branch 'mnkyl-lambda_alias'
bflad Feb 20, 2020
24f30d4
Update CHANGELOG for #9490
bflad Feb 20, 2020
b5052bf
Merge pull request #10402 from ewbankkit/issue-9802-MkIII
gdavison Feb 20, 2020
461e925
Update CHANGELOG for #10402
gdavison Feb 20, 2020
5e920f4
resource/aws_lambda_function: Publish new version on config-only func…
nemreid Feb 20, 2020
3ae8e39
Update CHANGELOG for #11211
bflad Feb 20, 2020
a30eb3e
resource/aws_iam_access_key: Add ses_smtp_password_v4 attribute (#11144)
n3ph Feb 20, 2020
5cffb1d
Update CHANGELOG for #11144
bflad Feb 20, 2020
89e3de2
resource/aws_transfer_server: Add host_key argument and host_key_fing…
teraken0509 Feb 20, 2020
16d9fbc
Update CHANGELOG for #8913
bflad Feb 20, 2020
4ccee99
resource/aws_transfer_server: Minor adjustments to new host_key handling
bflad Feb 20, 2020
5be2408
docs/resource/aws_codestarnotifications_notification_rule: Fixed spac…
mlevit Feb 20, 2020
0882926
v2.50.0
Feb 20, 2020
cadf3e2
Cleanup after v2.50.0 release
Feb 20, 2020
8ee4549
resource/aws_ses_receipt_rule: Fixes for tfproviderlint R002 (#12032)
bflad Feb 21, 2020
fe39017
resource/aws_route53_record: Fixes for tfproviderlint R002 (#12031)
bflad Feb 21, 2020
2a9256f
resource/aws_proxy_protocol_policy: Fixes for tfproviderlint R002 (#1…
bflad Feb 21, 2020
bf061e0
resource/aws_redshift_security_group: Fixes for tfproviderlint R002 (…
bflad Feb 21, 2020
499b818
resource/aws_iam_saml_provider: Fixes for tfproviderlint R002 (#12027)
bflad Feb 21, 2020
ebd01b5
resource/aws_iot_certificate: Fixes for tfproviderlint R002 (#12026)
bflad Feb 21, 2020
0981cd5
tests/service/elasticache: Replace deprecated cache.m1 with cache.t3,…
bflad Feb 21, 2020
addd865
tests/provider: Enable tfproviderlint R006 check (#12048)
bflad Feb 21, 2020
4acecb0
resource/aws_glacier_vault: Fixes for tfproviderlint R002 (#11946)
bflad Feb 21, 2020
286667c
Update module aws/aws-sdk-go to v1.29.7 (#11893)
renovate[bot] Feb 21, 2020
473cfe9
service/ec2: New Resources for EC2 Traffic Mirroring (#9372)
johnthedev97 Feb 21, 2020
01f8a69
Update CHANGELOG for #9372
bflad Feb 21, 2020
ae75981
Fix CHANGELOG for #9372
bflad Feb 21, 2020
ec1781c
tests/resource/aws_ec2_traffic_mirror_session: Fix TestAccAWSEc2Traff…
bflad Feb 21, 2020
5a24b92
New Data Source: aws_sfn_state_machine (#10932)
AndyMoore Feb 21, 2020
655e20a
Update CHANGELOG for #10932
bflad Feb 21, 2020
2d5b2cd
resource/aws_lambda_event_source_mapping: Adding ParallelizationFacto…
kostas-theo Feb 21, 2020
8259987
Update CHANGELOG for #11100
bflad Feb 21, 2020
3ed0f60
resource/aws_msk_cluster: Support Cluster expansion and Open Monitori…
marcoreni Feb 21, 2020
f21db0c
Update CHANGELOG for #11451
bflad Feb 21, 2020
29fdce8
docs/resource/aws_glue_job: Updating pythonshell details (#12114)
jiaxililearn Feb 21, 2020
e30cdc9
resource/aws_glue_job: Add notification_property configuration block …
jhole89 Feb 21, 2020
d648145
Update CHANGELOG for #12115
bflad Feb 21, 2020
4875ae5
Fix example of IP ranges usage (#11320)
bigwheel Feb 21, 2020
c162593
docs/provider: Fix aws_ec2_traffic_mirror_* location in terraform.io …
bflad Feb 23, 2020
8271366
resource/aws_workspaces_directory: Prevent panic and remove resource …
ewbankkit Feb 23, 2020
44f3ed9
Update CHANGELOG for #11837
bflad Feb 23, 2020
8b443fe
New Resource: aws_s3_access_point (#11276)
ewbankkit Feb 23, 2020
87fcb50
Update CHANGELOG for #11276
bflad Feb 23, 2020
bfdeb0a
resource/aws_s3_access_point: Address minor PR #11276 feedback
bflad Feb 23, 2020
ef098db
tests/resource/aws_s3_access_point: Fix log.Printf linting issue
bflad Feb 24, 2020
1031dff
Fixes Elastic Beanstalk sweeper names to match resource and prevent w…
gdavison Feb 24, 2020
7705988
Adds `.go-version` file and sets version to 1.13.7
gdavison Feb 25, 2020
fb5e025
Adds validation on CloudFront distribution georestriction type
gdavison Feb 25, 2020
505e9c1
Merge pull request #12156 from terraform-providers/add-go-version
gdavison Feb 25, 2020
e9b8374
service/ec2: Fixes for tfproviderlint R002 (#11947)
bflad Feb 26, 2020
c5350a6
resource/aws_elastic_beanstalk_environment: Fixes for tfproviderlint …
bflad Feb 26, 2020
3807442
service/elastictranscoder: Fixes for tfproviderlint R002 (#11944)
bflad Feb 26, 2020
fd6457f
service/cognito: Fixes for tfproviderlint R002 (#11943)
bflad Feb 26, 2020
03b75be
service/cloudwatchlogs: Fixes for tfproviderlint R002 (#11921)
bflad Feb 26, 2020
ddc62cf
data-source/aws_iam_server_certificate: Fixes for tfproviderlint R002…
bflad Feb 26, 2020
e301765
resource/aws_ec2_client_vpn_endpoint: Refactor to use keyvaluetags pa…
bflad Feb 26, 2020
73b1032
service/ec2: Refactor aws_network_interface(s) data sources and resou…
bflad Feb 26, 2020
6ecb8da
service/directconnect: Refactor tagging logic to keyvaluetags package…
ewbankkit Feb 26, 2020
2db6319
Update CHANGELOG for #11415
bflad Feb 26, 2020
63c5575
resource/aws_lambda_function: Support plan-time validation for runtim…
jhole89 Feb 26, 2020
5d7731e
Update CHANGELOG for #12116
bflad Feb 26, 2020
e3039f4
New Data Source: aws_sfn_activity (#11080)
slizco Feb 26, 2020
7744d9d
Update CHANGELOG for #11080
bflad Feb 26, 2020
6baa89c
v2.51.0
Feb 28, 2020
28f1041
Cleanup after v2.51.0 release
Feb 28, 2020
de490f4
Update module golangci/golangci-lint to v1.23.7 (#12205)
renovate[bot] Feb 28, 2020
abbe2a6
Update module aws/aws-sdk-go to v1.29.12 (#12128)
renovate[bot] Feb 28, 2020
8949cc7
resource/aws_globalaccelerator_accelerator: Add dns_name and hosted_z…
wlonkly Feb 28, 2020
af67efe
Update CHANGELOG for #11670
bflad Feb 28, 2020
023d4f0
resource/aws_globalaccelerator_accelerator: go fmt
bflad Feb 29, 2020
8f2a1e1
Update CHANGELOG.md (#12211)
Ninir Feb 29, 2020
27aba06
get the forck up-to-date
Mar 1, 2020
a88a649
Unexpected difference in directories after code generation. Run 'make…
Mar 1, 2020
273d092
Unexpected difference in directories after code generation. Run 'make…
Mar 1, 2020
9be5ac9
Merge branch 'master' of https://github.com/leppikallio/terraform-pro…
Mar 1, 2020
233df13
.
Mar 1, 2020
5fc7e6e
Merge pull request #12095 from terraform-providers/limit_dirs_for_swe…
gdavison Mar 2, 2020
ed13330
Merge pull request #12147 from terraform-providers/b-elastic-beanstal…
gdavison Mar 2, 2020
5892f5e
Merge pull request #12168 from terraform-providers/b-crash-on-invalid…
gdavison Mar 2, 2020
5ce2afd
Skips CloudFormation StackSet sweepers when not supported
gdavison Mar 2, 2020
64e68a8
Fixes naming of CloudFormation StackSet
gdavison Mar 2, 2020
119e096
Skips CloudFormation StackSets acceptance tests when not supported
gdavison Mar 2, 2020
3a47e7b
docs/provider: Fix invalid HCL in example configurations (#12209)
bflad Mar 3, 2020
10267dc
resource/aws_iam_service_linked_role: Allow aws_service_name validati…
bflad Mar 3, 2020
5ce2fc7
Update CHANGELOG for #11919
bflad Mar 3, 2020
e290994
service/ec2: Refactor Network ACL data source and resources to use ke…
bflad Mar 3, 2020
506c9ba
resource/aws_vpn_connection: Refactor to use keyvaluetags package (#1…
bflad Mar 3, 2020
c516dcd
service/ec2: Refactor VPC Endpoint (Service) data sources and resourc…
bflad Mar 3, 2020
6604d09
service/ec2: Refactor aws_route_table(s) data sources and resource to…
bflad Mar 3, 2020
22c70bc
service/ec2: Refactor Spot Instance and Fleet resources to use keyval…
bflad Mar 3, 2020
b793dfe
resource/aws_vpc_peering_connection: Refactor to use keyvaluetags pac…
bflad Mar 3, 2020
63b09d7
internal/keyvaluetags: Support Quicksight service (#12220)
leppikallio Mar 3, 2020
bfbc65f
provider: Replace local version of schema validators with identical v…
ewbankkit Mar 3, 2020
378a269
resource/aws_lb_target_group: Add `load_balancing_algorithm_type` arg…
dhoeric Mar 3, 2020
a13c756
Update CHANGELOG for #11141
bflad Mar 3, 2020
d629303
docs/resource/aws_s3_bucket_notification: Fix race condition in examp…
joshgubler Mar 3, 2020
3c2fe1b
docs/data-source/aws_subnet_ids: Fixing example resource (#12224)
gfranchini Mar 3, 2020
e9c8c71
fixup(cloudwatch_log_group) documentation (#12193)
quintok Mar 3, 2020
8494851
docs/resource/aws_cloudtrail: Fix spelling typo (#12180)
david-andrews Mar 3, 2020
c57393a
default EBS Volume type (#12155)
mikemartin1090 Mar 3, 2020
27836de
service/elastictranscoder: Fix tfproviderlint R009 check in structure…
ewbankkit Mar 3, 2020
8bf355c
docs/data-source/aws_pricing_product: Add capacitystatus filter (#12122)
bendrucker Mar 3, 2020
5ff0705
docs/resource/aws_msk_cluster: Correct default value for client-broke…
matthewswain Mar 3, 2020
9df13a2
Merge pull request #12227 from terraform-providers/b-cloudformation-s…
gdavison Mar 3, 2020
e9bfb75
New Data Sources: aws_ec2_instance_type_offering and aws_ec2_instance…
bflad Mar 4, 2020
fa8d7d0
Update CHANGELOG for #12139
bflad Mar 4, 2020
5954746
resource/aws_media_store_container: Prevent ValidationException on cr…
bflad Mar 4, 2020
b8cebbc
Update CHANGELOG for #12170
bflad Mar 4, 2020
f34f5dd
resource/aws_lambda_function_event_invoke_config: Retry on additional…
bflad Mar 4, 2020
cba9c69
Update CHANGELOG for #12171
bflad Mar 4, 2020
485cbb9
tests/resource/aws_eks_node_group: Update TestAccAWSEksNodeGroup_Rele…
bflad Mar 4, 2020
3b3f176
Update module aws/aws-sdk-go to v1.29.16 (#12214)
renovate[bot] Mar 4, 2020
2749498
Merge remote-tracking branch 'upstream/master'
Mar 4, 2020
e66d5ce
The original code for the `aws_quicksight_data_source` by @mjgpy3, [#…
Mar 6, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,20 @@
## 2.52.0 (Unreleased)

FEATURES:

* **New Data Source:** `aws_ec2_instance_type_offering` [GH-12139]
* **New Data Source:** `aws_ec2_instance_type_offerings` [GH-12139]

ENHANCEMENTS:

* resource/aws_globalaccelerator_accelerator: Add `dns_name` and `hosted_zone_id` attributes [GH-11670]
* resource/aws_lb_target_group: Add `load_balancing_algorithm_type` argument (support Least Outstanding Requests algorithm for Application Load Balancers) [GH-11141]

BUG FIXES:

* resource/aws_iam_service_linked_role: Allow `aws_service_name` argument validation to accept values in AWS partitions outside AWS Commercial and AWS GovCloud (US) [GH-11919]
* resource/aws_lambda_function_event_invoke_config: Retry on additional IAM eventual consistency error with SNS Topic destinations [GH-12171]
* resource/aws_media_store_container: Prevent `ValidationException` error on creation when no tags are configured [GH-12170]

## 2.51.0 (February 28, 2020)

Expand Down
3 changes: 2 additions & 1 deletion GNUmakefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
SWEEP?=us-east-1,us-west-2
TEST?=./...
SWEEP_DIR?=./aws
GOFMT_FILES?=$$(find . -name '*.go' |grep -v vendor)
PKG_NAME=aws
WEBSITE_REPO=github.com/hashicorp/terraform-website
Expand All @@ -16,7 +17,7 @@ gen:

sweep:
@echo "WARNING: This will destroy infrastructure. Use only in development accounts."
go test $(TEST) -v -sweep=$(SWEEP) $(SWEEPARGS) -timeout 60m
go test $(SWEEP_DIR) -v -sweep=$(SWEEP) $(SWEEPARGS) -timeout 60m

test: fmtcheck
go test $(TEST) $(TESTARGS) -timeout=120s -parallel=4
Expand Down
128 changes: 128 additions & 0 deletions aws/data_source_aws_ec2_instance_type_offering.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
package aws

import (
"fmt"

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/ec2"
"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
)

func dataSourceAwsEc2InstanceTypeOffering() *schema.Resource {
return &schema.Resource{
Read: dataSourceAwsEc2InstanceTypeOfferingRead,

Schema: map[string]*schema.Schema{
"filter": dataSourceFiltersSchema(),
"instance_type": {
Type: schema.TypeString,
Computed: true,
},
"location_type": {
Type: schema.TypeString,
Optional: true,
ValidateFunc: validation.StringInSlice([]string{
ec2.LocationTypeAvailabilityZone,
ec2.LocationTypeAvailabilityZoneId,
ec2.LocationTypeRegion,
}, false),
},
"preferred_instance_types": {
Type: schema.TypeList,
Optional: true,
Elem: &schema.Schema{Type: schema.TypeString},
},
},
}
}

func dataSourceAwsEc2InstanceTypeOfferingRead(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).ec2conn

input := &ec2.DescribeInstanceTypeOfferingsInput{}

if v, ok := d.GetOk("filter"); ok {
input.Filters = buildAwsDataSourceFilters(v.(*schema.Set))
}

if v, ok := d.GetOk("location_type"); ok {
input.LocationType = aws.String(v.(string))
}

var foundInstanceTypes []string

for {
output, err := conn.DescribeInstanceTypeOfferings(input)

if err != nil {
return fmt.Errorf("error reading EC2 Instance Type Offerings: %w", err)
}

if output == nil {
break
}

for _, instanceTypeOffering := range output.InstanceTypeOfferings {
if instanceTypeOffering == nil {
continue
}

foundInstanceTypes = append(foundInstanceTypes, aws.StringValue(instanceTypeOffering.InstanceType))
}

if aws.StringValue(output.NextToken) == "" {
break
}

input.NextToken = output.NextToken
}

if len(foundInstanceTypes) == 0 {
return fmt.Errorf("no EC2 Instance Type Offerings found matching criteria; try different search")
}

var resultInstanceType string

// Search preferred instance types in their given order and set result
// instance type for first match found
if l := d.Get("preferred_instance_types").([]interface{}); len(l) > 0 {
for _, elem := range l {
preferredInstanceType, ok := elem.(string)

if !ok {
continue
}

for _, foundInstanceType := range foundInstanceTypes {
if foundInstanceType == preferredInstanceType {
resultInstanceType = preferredInstanceType
break
}
}

if resultInstanceType != "" {
break
}
}
}

if resultInstanceType == "" && len(foundInstanceTypes) > 1 {
return fmt.Errorf("multiple EC2 Instance Offerings found matching criteria; try different search")
}

if resultInstanceType == "" && len(foundInstanceTypes) == 1 {
resultInstanceType = foundInstanceTypes[0]
}

if resultInstanceType == "" {
return fmt.Errorf("no EC2 Instance Type Offerings found matching criteria; try different search")
}

d.Set("instance_type", resultInstanceType)

d.SetId(resource.UniqueId())

return nil
}
143 changes: 143 additions & 0 deletions aws/data_source_aws_ec2_instance_type_offering_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,143 @@
package aws

import (
"fmt"
"testing"

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/ec2"
"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
)

func TestAccAWSEc2InstanceTypeOfferingDataSource_Filter(t *testing.T) {
dataSourceName := "data.aws_ec2_instance_type_offering.test"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t); testAccPreCheckAWSEc2InstanceTypeOffering(t) },
Providers: testAccProviders,
CheckDestroy: nil,
Steps: []resource.TestStep{
{
Config: testAccAWSEc2InstanceTypeOfferingDataSourceConfigFilter(),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttrSet(dataSourceName, "instance_type"),
),
},
},
})
}

func TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType(t *testing.T) {
dataSourceName := "data.aws_ec2_instance_type_offering.test"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t); testAccPreCheckAWSEc2InstanceTypeOffering(t) },
Providers: testAccProviders,
CheckDestroy: nil,
Steps: []resource.TestStep{
{
Config: testAccAWSEc2InstanceTypeOfferingDataSourceConfigLocationType(),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttrSet(dataSourceName, "instance_type"),
),
},
},
})
}

func TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes(t *testing.T) {
dataSourceName := "data.aws_ec2_instance_type_offering.test"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t); testAccPreCheckAWSEc2InstanceTypeOffering(t) },
Providers: testAccProviders,
CheckDestroy: nil,
Steps: []resource.TestStep{
{
Config: testAccAWSEc2InstanceTypeOfferingDataSourceConfigPreferredInstanceTypes(),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr(dataSourceName, "instance_type", "t3.micro"),
),
},
},
})
}

func testAccPreCheckAWSEc2InstanceTypeOffering(t *testing.T) {
conn := testAccProvider.Meta().(*AWSClient).ec2conn

input := &ec2.DescribeInstanceTypeOfferingsInput{
MaxResults: aws.Int64(5),
}

_, err := conn.DescribeInstanceTypeOfferings(input)

if testAccPreCheckSkipError(err) {
t.Skipf("skipping acceptance testing: %s", err)
}

if err != nil {
t.Fatalf("unexpected PreCheck error: %s", err)
}
}

func testAccAWSEc2InstanceTypeOfferingDataSourceConfigFilter() string {
return fmt.Sprintf(`
# Rather than hardcode an instance type in the testing,
# use the first result from all available offerings.
data "aws_ec2_instance_type_offerings" "test" {}

data "aws_ec2_instance_type_offering" "test" {
filter {
name = "instance-type"
values = [tolist(data.aws_ec2_instance_type_offerings.test.instance_types)[0]]
}
}
`)
}

func testAccAWSEc2InstanceTypeOfferingDataSourceConfigLocationType() string {
return fmt.Sprintf(`
data "aws_availability_zones" "available" {
state = "available"
}

# Rather than hardcode an instance type in the testing,
# use the first result from all available offerings.
data "aws_ec2_instance_type_offerings" "test" {
filter {
name = "location"
values = [data.aws_availability_zones.available.names[0]]
}

location_type = "availability-zone"
}

data "aws_ec2_instance_type_offering" "test" {
filter {
name = "instance-type"
values = [tolist(data.aws_ec2_instance_type_offerings.test.instance_types)[0]]
}

filter {
name = "location"
values = [data.aws_availability_zones.available.names[0]]
}

location_type = "availability-zone"
}
`)
}

func testAccAWSEc2InstanceTypeOfferingDataSourceConfigPreferredInstanceTypes() string {
return fmt.Sprintf(`
data "aws_ec2_instance_type_offering" "test" {
filter {
name = "instance-type"
values = ["t1.micro", "t2.micro", "t3.micro"]
}

preferred_instance_types = ["t3.micro", "t2.micro", "t1.micro"]
}
`)
}
85 changes: 85 additions & 0 deletions aws/data_source_aws_ec2_instance_type_offerings.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
package aws

import (
"fmt"

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/ec2"
"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
)

func dataSourceAwsEc2InstanceTypeOfferings() *schema.Resource {
return &schema.Resource{
Read: dataSourceAwsEc2InstanceTypeOfferingsRead,

Schema: map[string]*schema.Schema{
"filter": dataSourceFiltersSchema(),
"instance_types": {
Type: schema.TypeSet,
Computed: true,
Elem: &schema.Schema{Type: schema.TypeString},
},
"location_type": {
Type: schema.TypeString,
Optional: true,
ValidateFunc: validation.StringInSlice([]string{
ec2.LocationTypeAvailabilityZone,
ec2.LocationTypeAvailabilityZoneId,
ec2.LocationTypeRegion,
}, false),
},
},
}
}

func dataSourceAwsEc2InstanceTypeOfferingsRead(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).ec2conn

input := &ec2.DescribeInstanceTypeOfferingsInput{}

if v, ok := d.GetOk("filter"); ok {
input.Filters = buildAwsDataSourceFilters(v.(*schema.Set))
}

if v, ok := d.GetOk("location_type"); ok {
input.LocationType = aws.String(v.(string))
}

var instanceTypes []string

for {
output, err := conn.DescribeInstanceTypeOfferings(input)

if err != nil {
return fmt.Errorf("error reading EC2 Instance Type Offerings: %w", err)
}

if output == nil {
break
}

for _, instanceTypeOffering := range output.InstanceTypeOfferings {
if instanceTypeOffering == nil {
continue
}

instanceTypes = append(instanceTypes, aws.StringValue(instanceTypeOffering.InstanceType))
}

if aws.StringValue(output.NextToken) == "" {
break
}

input.NextToken = output.NextToken
}

if err := d.Set("instance_types", instanceTypes); err != nil {
return fmt.Errorf("error setting instance_types: %s", err)
}

d.SetId(resource.UniqueId())

return nil
}
Loading