Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_fsx_lustre_file_system: Lower minimum storage cap to 1200Gb #11847

Merged
merged 2 commits into from
Feb 6, 2020

Conversation

slapula
Copy link
Contributor

@slapula slapula commented Feb 1, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11828

Release note for CHANGELOG:

Updates the storage_capacity minimum size from 3600GiB to 1200GiB

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSFsxLustreFileSystem_StorageCapacity'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_StorageCapacity -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_StorageCapacity
=== PAUSE TestAccAWSFsxLustreFileSystem_StorageCapacity
=== CONT  TestAccAWSFsxLustreFileSystem_StorageCapacity
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacity (1221.81s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1221.841s

@slapula slapula requested a review from a team February 1, 2020 04:11
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 1, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 5, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this @slapula 🚀

Output from acceptance testing:

--- PASS: TestAccAWSFsxLustreFileSystem_disappears (410.68s)
--- PASS: TestAccAWSFsxLustreFileSystem_Tags (424.71s)
--- PASS: TestAccAWSFsxLustreFileSystem_basic (510.98s)
--- PASS: TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime (528.59s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacity (895.44s)
--- PASS: TestAccAWSFsxLustreFileSystem_SecurityGroupIds (1017.37s)
--- PASS: TestAccAWSFsxLustreFileSystem_ExportPath (1379.91s)
--- PASS: TestAccAWSFsxLustreFileSystem_ImportPath (1520.63s)
--- PASS: TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize (1701.27s)

@bflad bflad added this to the v2.48.0 milestone Feb 6, 2020
@bflad bflad merged commit bcd2975 into hashicorp:master Feb 6, 2020
bflad added a commit that referenced this pull request Feb 6, 2020
@ghost
Copy link

ghost commented Feb 7, 2020

This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum AWS FSx size is set to 3600GB instead of 1200GB
3 participants