-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ansible_python_interpreter to python3 on debian (fix error with mitogen) #6633
Set ansible_python_interpreter to python3 on debian (fix error with mitogen) #6633
Conversation
c6389b0
to
d4d4285
Compare
d4d4285
to
2e9b16f
Compare
I wonder if we have clear requirement for Python 3? Or is that clear now that Python 2 is EOL? /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Not sure but as we check and install python3 if not already present, I think we are safe with this, otherwise we could |
Python foundation says Python 2 has been unsupported since January 1, 2020 as https://www.python.org/doc/sunset-python-2/ /lgtm |
* 'master' of https://github.com/kubernetes-sigs/kubespray: (32 commits) Update api version, deprecated in 1.19 (kubernetes-sigs#6656) Update etcd to 3.4.13 (kubernetes-sigs#6658) Update dockerfile for v1.19.1 (kubernetes-sigs#6668) yamllint: ignore .git dir (kubernetes-sigs#6667) fix kubelet_flexvolumes_plugins_dir undefined (kubernetes-sigs#6645) Remove deprecated (and removed in 1.19) flag and function --basic-auth-file (kubernetes-sigs#6655) Update CoreDNS to 1.7.0 (kubernetes-sigs#6657) Update various dependencies following 1.19 release (kubernetes-sigs#6660) Add Kubernetes 1.19.1 hashes and set default (kubernetes-sigs#6654) crio: use system default for storage driver by default (kubernetes-sigs#6637) Add iptables_backend to weave options (kubernetes-sigs#6639) Add comment clarifying network allocation and sizes (kubernetes-sigs#6607) Allowing resource management of metrics-server container. Will allow fine-tuning of resource allocation and solving throttling issues. Setting defaults as per the current request & limit allocation: cpu: 43m, memory 55Mi for both limits & requests. (kubernetes-sigs#6652) Fix a bunch of failed quality rules (kubernetes-sigs#6646) Update calico to 3.16.1 (kubernetes-sigs#6644) NetworkManager lists must be separated by , (kubernetes-sigs#6643) Set ansible_python_interpreter to python3 on debian (fix error with mitogen) (kubernetes-sigs#6633) Use v2.14.0 as base image for CI (kubernetes-sigs#6636) Cleanup v1.16 hashes (kubernetes-sigs#6635) Update kube_version_min_required for 2.14 release (kubernetes-sigs#6634) ...
I'd like to see this backport for release-2.14 because I confirmed this fixes the following issue on my Ubuntu 18.04 machine:
|
Care to submit the backported PR ? |
Yes, I did it on #6744 |
…itogen) (#6633) (#6744) Co-authored-by: Florian Ruynat <[email protected]>
* upstream/release-2.14: Fix unintended SIGPIPE (kubernetes-sigs#6817) Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745) (kubernetes-sigs#6832) Update hashes and set default to 1.18.10 (kubernetes-sigs#6842) Set ansible_python_interpreter to python3 on debian (fix error with mitogen) (kubernetes-sigs#6633) (kubernetes-sigs#6744)
What type of PR is this?
/kind bug
What this PR does / why we need it:
When mitogen is enable, ubuntu CI fails
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?: