Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ansible_python_interpreter to python3 on debian (fix error with mitogen) #6633

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

floryut
Copy link
Member

@floryut floryut commented Sep 7, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
When mitogen is enable, ubuntu CI fails

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 7, 2020
@floryut floryut marked this pull request as draft September 7, 2020 11:58
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 7, 2020
@floryut floryut changed the title Set ansible python to python3 on debian (fix error with mitogen) Set ansible_python_interpreter to python3 on debian (fix error with mitogen) Sep 7, 2020
@floryut floryut marked this pull request as ready for review September 7, 2020 12:23
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Sep 7, 2020

I wonder if we have clear requirement for Python 3? Or is that clear now that Python 2 is EOL?

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2020
@floryut
Copy link
Member Author

floryut commented Sep 7, 2020

I wonder if we have clear requirement for Python 3? Or is that clear now that Python 2 is EOL?

/approve

Not sure but as we check and install python3 if not already present, I think we are safe with this, otherwise we could ln -s without forcing to be sure we have a python command existing using python2 or 3

@oomichi
Copy link
Contributor

oomichi commented Sep 8, 2020

Or is that clear now that Python 2 is EOL?

Python foundation says Python 2 has been unsupported since January 1, 2020 as https://www.python.org/doc/sunset-python-2/
In addition there is a similar approach in Kubernetes community like kubernetes-sigs/image-builder#249
Then

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8e3915f into kubernetes-sigs:master Sep 8, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Sep 12, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray: (32 commits)
  Update api version, deprecated in 1.19 (kubernetes-sigs#6656)
  Update etcd to 3.4.13 (kubernetes-sigs#6658)
  Update dockerfile for v1.19.1 (kubernetes-sigs#6668)
  yamllint: ignore .git dir (kubernetes-sigs#6667)
  fix kubelet_flexvolumes_plugins_dir undefined (kubernetes-sigs#6645)
  Remove deprecated (and removed in 1.19) flag and function --basic-auth-file (kubernetes-sigs#6655)
  Update CoreDNS to 1.7.0 (kubernetes-sigs#6657)
  Update various dependencies following 1.19 release (kubernetes-sigs#6660)
  Add Kubernetes 1.19.1 hashes and set default (kubernetes-sigs#6654)
  crio: use system default for storage driver by default (kubernetes-sigs#6637)
  Add iptables_backend to weave options (kubernetes-sigs#6639)
  Add comment clarifying network allocation and sizes (kubernetes-sigs#6607)
  Allowing resource management of metrics-server container.  Will allow fine-tuning of resource allocation and solving throttling issues. Setting defaults as per the current request & limit allocation: cpu: 43m, memory 55Mi for both limits & requests. (kubernetes-sigs#6652)
  Fix a bunch of failed quality rules (kubernetes-sigs#6646)
  Update calico to 3.16.1 (kubernetes-sigs#6644)
  NetworkManager lists must be separated by , (kubernetes-sigs#6643)
  Set ansible_python_interpreter to python3 on debian (fix error with mitogen) (kubernetes-sigs#6633)
  Use v2.14.0 as base image for CI (kubernetes-sigs#6636)
  Cleanup v1.16 hashes (kubernetes-sigs#6635)
  Update kube_version_min_required for 2.14 release (kubernetes-sigs#6634)
  ...
@oomichi
Copy link
Contributor

oomichi commented Sep 16, 2020

I'd like to see this backport for release-2.14 because I confirmed this fixes the following issue on my Ubuntu 18.04 machine:

TASK [bootstrap-os : Install dbus for the hostname module] ******************************************************************************************************************
fatal: [ubuntu]: FAILED! => {"changed": false, "module_stderr": "/bin/sh: 1: /usr/bin/python: not found\n", "module_stdout": "", "msg": "The module failed to execute correct

NO MORE HOSTS LEFT **********************************************************************************************************************************************************

PLAY RECAP ******************************************************************************************************************************************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   
ubuntu                     : ok=8    changed=2    unreachable=0    failed=1    skipped=27   rescued=0    ignored=0   

@floryut
Copy link
Member Author

floryut commented Sep 16, 2020

I'd like to see this backport for release-2.14 because I confirmed this fixes the following issue on my Ubuntu 18.04 machine:

TASK [bootstrap-os : Install dbus for the hostname module] ******************************************************************************************************************
fatal: [ubuntu]: FAILED! => {"changed": false, "module_stderr": "/bin/sh: 1: /usr/bin/python: not found\n", "module_stdout": "", "msg": "The module failed to execute correct

NO MORE HOSTS LEFT **********************************************************************************************************************************************************

PLAY RECAP ******************************************************************************************************************************************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   
ubuntu                     : ok=8    changed=2    unreachable=0    failed=1    skipped=27   rescued=0    ignored=0   

Care to submit the backported PR ?

@oomichi
Copy link
Contributor

oomichi commented Sep 24, 2020

Care to submit the backported PR ?

Yes, I did it on #6744

k8s-ci-robot pushed a commit that referenced this pull request Oct 1, 2020
blacs30 added a commit to blacs30/kubespray that referenced this pull request Nov 1, 2020
* upstream/release-2.14:
  Fix unintended SIGPIPE (kubernetes-sigs#6817)
  Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745) (kubernetes-sigs#6832)
  Update hashes and set default to 1.18.10 (kubernetes-sigs#6842)
  Set ansible_python_interpreter to python3 on debian (fix error with mitogen) (kubernetes-sigs#6633) (kubernetes-sigs#6744)
@floryut floryut mentioned this pull request Dec 19, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants