Fix cinder & external_openstack cacert deployment #6745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/M
LuckySB
reviewed
Sep 25, 2020
|
/cc @oomichi |
The CA cert was only deployed on master nodes
bozzo
force-pushed
the
fix_os_cert_deployment
branch
from
54a7223 to
da4c0df
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bozzo, LuckySB The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
tevren
added a commit
to tevren/kubespray
that referenced
this pull request
Oct 10, 2020
…ster * 'master' of github.com:kubernetes-sigs/kubespray: (1632 commits) Chmod kubeconfig to avoid group-readable (kubernetes-sigs#6800) Update bunch of dependencies (kubernetes-sigs#6801) If no_proxy_exclude_workers is true, workers will be excluded from the no_proxy variable. This prevents docker engine restarting when scaling workers. (kubernetes-sigs#6520) crio: ensure service is started and enabled (kubernetes-sigs#6753) Do not install etcd and etcdctl on master with scale.yml playbook. (kubernetes-sigs#6798) Fix csi-snapshotter timeout option. Fix ebs-external-attacher-role ClusterRole. (kubernetes-sigs#6776) Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745) Added Comment line above checksum section to add clarification about Kubespray's version support and testing (kubernetes-sigs#6785) Update nginx ingress controller to 0.40.1 (kubernetes-sigs#6786) Use v2.14.1 as base image for CI (kubernetes-sigs#6773) Add oomichi to reviewers (kubernetes-sigs#6796) Update triage/support label references to kind/support (kubernetes-sigs#6792) Update kube-router to 1.1.0 (kubernetes-sigs#6793) harden reset to work in more cases (kubernetes-sigs#6781) Add extra arguments variables for openstack and vsphere cloud controller manager daemonsets (kubernetes-sigs#6783) Update cilium with minor fix for CVE (kubernetes-sigs#6784) Add `plugins/mitogen` to `.gitignore` (kubernetes-sigs#6774) Remove arch from flannel image tag (kubernetes-sigs#6765) nginx ingress: fix yaml for multiple nodeselectors (kubernetes-sigs#6768) Forgotten debian10 test during nightly tests (kubernetes-sigs#6769) ...
erulabs
added a commit
to kubesail/kubespray
that referenced
this pull request
Oct 13, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray: crio: ensure service is started and enabled (kubernetes-sigs#6753) Do not install etcd and etcdctl on master with scale.yml playbook. (kubernetes-sigs#6798) Fix csi-snapshotter timeout option. Fix ebs-external-attacher-role ClusterRole. (kubernetes-sigs#6776) Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745) Added Comment line above checksum section to add clarification about Kubespray's version support and testing (kubernetes-sigs#6785) Update nginx ingress controller to 0.40.1 (kubernetes-sigs#6786) Use v2.14.1 as base image for CI (kubernetes-sigs#6773) Add oomichi to reviewers (kubernetes-sigs#6796)
bozzo
added a commit
to bozzo/kubespray
that referenced
this pull request
Oct 17, 2020
The CA cert was only deployed on master nodes
k8s-ci-robot
pushed a commit
that referenced
this pull request
Oct 21, 2020
blacs30
added a commit
to blacs30/kubespray
that referenced
this pull request
Nov 1, 2020
* upstream/release-2.14: Fix unintended SIGPIPE (kubernetes-sigs#6817) Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745) (kubernetes-sigs#6832) Update hashes and set default to 1.18.10 (kubernetes-sigs#6842) Set ansible_python_interpreter to python3 on debian (fix error with mitogen) (kubernetes-sigs#6633) (kubernetes-sigs#6744)
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jan 16, 2021
The CA cert was only deployed on master nodes
jphilip09
pushed a commit
to RIFTIO/kubespray
that referenced
this pull request
Jun 6, 2023
…) (kubernetes-sigs#6832) The CA cert was only deployed on master nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
When using a custom CA cert for openstack external cloud provider, the CA cert was deployed only on master nodes.
Which issue(s) this PR fixes:
Fixes #5978
Special notes for your reviewer:
Does this PR introduce a user-facing change?: