Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.14] Set ansible_python_interpreter to python3 on debian #6744

Merged
merged 1 commit into from
Oct 1, 2020
Merged

[2.14] Set ansible_python_interpreter to python3 on debian #6744

merged 1 commit into from
Oct 1, 2020

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Sep 24, 2020

What type of PR is this?

/kind bug

What this PR does / why we need it:

When mitogen is enable, ubuntu CI fails
This is a backport PR of #6633 for v2.14.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 24, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO September 24, 2020 17:07
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 24, 2020
@oomichi oomichi mentioned this pull request Sep 24, 2020
Merged
@floryut
Copy link
Member

floryut commented Sep 25, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2020
@electrocucaracha
Copy link
Contributor

I usually change the soft link to point python3

sudo rm -f /usr/bin/python
sudo ln -s /usr/bin/python3 /usr/bin/python

@oomichi
Copy link
Contributor Author

oomichi commented Sep 30, 2020 •
edited
Loading

I usually change the soft link to point python3

I know that works.
But I don't think every user needs to do the workaround with taking their own time.

@electrocucaracha
Copy link
Contributor

But I don't think every user needs to do the workaround with taking their own time.

Makes sense, I haven't checked it but it's a way to ensure /usr/bin/python3 binary is present before reaching this point.

@Miouge1
Copy link
Contributor

Miouge1 commented Oct 1, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit 19c000c into kubernetes-sigs:release-2.14 Oct 1, 2020
blacs30 added a commit to blacs30/kubespray that referenced this pull request Nov 1, 2020
@blacs30
Merge remote-tracking branch 'upstream/release-2.14' into master
caaab08 
* upstream/release-2.14:
  Fix unintended SIGPIPE (kubernetes-sigs#6817)
  Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745) (kubernetes-sigs#6832)
  Update hashes and set default to 1.18.10 (kubernetes-sigs#6842)
  Set ansible_python_interpreter to python3 on debian (fix error with mitogen) (kubernetes-sigs#6633) (kubernetes-sigs#6744)
@oomichi oomichi deleted the backport-python3-2 branch March 2, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO EppO approved these changes

@bozzo bozzo Awaiting requested review from bozzo

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oomichi @floryut @electrocucaracha @Miouge1 @k8s-ci-robot @EppO