Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.14] Fix cinder & external_openstack cacert deployment #6832

Merged

Conversation

bozzo
Copy link
Contributor

@bozzo bozzo commented Oct 17, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Backport of #6745

The CA cert was only deployed on master nodes

Which issue(s) this PR fixes:

Fixes #5978

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix the openstack CA cert issue (#5978)

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 17, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2020
@bozzo bozzo force-pushed the 2_14_fix_os_cert_deployment branch from f38ace5 to db75f3f Compare October 17, 2020 18:26
@bozzo bozzo changed the title [2.14] Fix cinder & external_openstack cacert deployment (#6745) [2.14] Fix cinder & external_openstack cacert deployment Oct 17, 2020
@floryut
Copy link
Member

floryut commented Oct 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2020
@oomichi
Copy link
Contributor

oomichi commented Oct 19, 2020

/lgtm

@Miouge1
Copy link
Contributor

Miouge1 commented Oct 21, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bozzo, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 087d9c2 into kubernetes-sigs:release-2.14 Oct 21, 2020
blacs30 added a commit to blacs30/kubespray that referenced this pull request Nov 1, 2020
* upstream/release-2.14:
  Fix unintended SIGPIPE (kubernetes-sigs#6817)
  Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745) (kubernetes-sigs#6832)
  Update hashes and set default to 1.18.10 (kubernetes-sigs#6842)
  Set ansible_python_interpreter to python3 on debian (fix error with mitogen) (kubernetes-sigs#6633) (kubernetes-sigs#6744)
jphilip09 pushed a commit to RIFTIO/kubespray that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants