Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AWS EBS CSI Driver. #6776

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Fix AWS EBS CSI Driver. #6776

merged 1 commit into from
Oct 6, 2020

Conversation

rafal-jan
Copy link
Contributor

  • Fix csi-snapshotter timeout option.
  • Fix ebs-external-attacher-role ClusterRole.

What type of PR is this?

/kind bug

What this PR does / why we need it:
See #6770

Which issue(s) this PR fixes:

Fixes #6770

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 1, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 1, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @rafal-jan!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 1, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @rafal-jan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 1, 2020
@floryut
Copy link
Member

floryut commented Oct 1, 2020

@rafal-jan Thank you for the PR, could you please sign CLA ?

@rafal-jan
Copy link
Contributor Author

@rafal-jan Thank you for the PR, could you please sign CLA ?

Done

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 1, 2020
oomichi
oomichi reviewed Oct 1, 2020
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @oomichi

roles/kubernetes-apps/csi_driver/aws_ebs/templates/aws-ebs-csi-controllerservice-rbac.yml.j2
verbs: ["get", "list", "watch", "patch"]
- apiGroups: ["storage.k8s.io"]
resources: ["volumeattachments/status"]
verbs: ["patch"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this change come from?
I cannot find the reason on both this PR message and the corresponding issue.
In addition, the same name of ClusterRole of https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/aws-ebs-csi-driver/templates/clusterrole-attacher.yaml is the same as the original one, and different from this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this change is in #6770 (comment). The version of csi-attacher was bumped from v1.2.1 to v2.2.0 in Kubespray 2.14.0 for CSI drivers that do not use additional variable for the csi-attacher image tag (that is why someone else had problems with Cinder CSI and fixed them in #6358). The new version of csi-attacher requires different permissions to function properly. Without this change the volumes could not be attached to pods and the csi-attacher container had lots of errors in logs related to permissions.

Also, the file linked by you is for v1.2.0 of csi-attacher (https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/aws-ebs-csi-driver/values.yaml#L18) and that is why it is the same as the original one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your explanation, I got it.
How about putting comment like # This ClusterRole comes external-attacher-runner of kubernetes-csi/external-attacher or something?
It can solve questions like mine and avoid reverting this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that I would prefer adding some kind of test for it but my knowledge about kubespray's CI is very limited so let's go with the comment. How about:

# The permissions in this ClusterRole are tightly coupled with the version of csi-attacher used. More information about this can be found in kubernetes-csi/external-attacher.

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion, that looks good for me :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ;)

@k8s-ci-robot k8s-ci-robot requested a review from oomichi October 1, 2020 22:58
@floryut
Copy link
Member

floryut commented Oct 6, 2020

/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2020
oomichi
oomichi reviewed Oct 6, 2020
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2020
@LuckySB
Copy link
Contributor

LuckySB commented Oct 6, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, LuckySB, rafal-jan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9d7f358 into kubernetes-sigs:master Oct 6, 2020
@rafal-jan rafal-jan deleted the fix-aws-ebs-csi-driver branch October 6, 2020 13:47
tevren added a commit to tevren/kubespray that referenced this pull request Oct 10, 2020
@tevren
Merge branch 'master' of github.com:kubernetes-sigs/kubespray into ma…
1880e30 
…ster

* 'master' of github.com:kubernetes-sigs/kubespray: (1632 commits)
  Chmod kubeconfig to avoid group-readable (kubernetes-sigs#6800)
  Update bunch of dependencies (kubernetes-sigs#6801)
  If no_proxy_exclude_workers is true, workers will be excluded from the no_proxy variable.  This prevents docker engine restarting when scaling workers. (kubernetes-sigs#6520)
  crio: ensure service is started and enabled (kubernetes-sigs#6753)
  Do not install etcd and etcdctl on master with scale.yml playbook. (kubernetes-sigs#6798)
  Fix csi-snapshotter timeout option. Fix ebs-external-attacher-role ClusterRole. (kubernetes-sigs#6776)
  Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745)
  Added Comment line above checksum section to add clarification about Kubespray's version support and testing (kubernetes-sigs#6785)
  Update nginx ingress controller to 0.40.1 (kubernetes-sigs#6786)
  Use v2.14.1 as base image for CI (kubernetes-sigs#6773)
  Add oomichi to reviewers (kubernetes-sigs#6796)
  Update triage/support label references to kind/support (kubernetes-sigs#6792)
  Update kube-router to 1.1.0 (kubernetes-sigs#6793)
  harden reset to work in more cases (kubernetes-sigs#6781)
  Add extra arguments variables for openstack and vsphere cloud controller manager daemonsets (kubernetes-sigs#6783)
  Update cilium with minor fix for CVE (kubernetes-sigs#6784)
  Add `plugins/mitogen` to `.gitignore` (kubernetes-sigs#6774)
  Remove arch from flannel image tag (kubernetes-sigs#6765)
  nginx ingress: fix yaml for multiple nodeselectors (kubernetes-sigs#6768)
  Forgotten debian10 test during nightly tests (kubernetes-sigs#6769)
  ...
erulabs added a commit to kubesail/kubespray that referenced this pull request Oct 13, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
ae654a1 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  crio: ensure service is started and enabled (kubernetes-sigs#6753)
  Do not install etcd and etcdctl on master with scale.yml playbook. (kubernetes-sigs#6798)
  Fix csi-snapshotter timeout option. Fix ebs-external-attacher-role ClusterRole. (kubernetes-sigs#6776)
  Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745)
  Added Comment line above checksum section to add clarification about Kubespray's version support and testing (kubernetes-sigs#6785)
  Update nginx ingress controller to 0.40.1 (kubernetes-sigs#6786)
  Use v2.14.1 as base image for CI (kubernetes-sigs#6773)
  Add oomichi to reviewers (kubernetes-sigs#6796)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
@rafal-jan @LuckySB
Fix csi-snapshotter timeout option. Fix ebs-external-attacher-role Cl…
f7fbfd4 
…usterRole. (kubernetes-sigs#6776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@alijahnas alijahnas Awaiting requested review from alijahnas

@LuckySB LuckySB Awaiting requested review from LuckySB

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS EBS CSI Driver not working after installing with kubespray 2.14.0+
5 participants
@rafal-jan @k8s-ci-robot @floryut @LuckySB @oomichi