Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale cluster playbook failed when etcd installed by kubeadm #6798

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

LuckySB
Copy link
Contributor

@LuckySB LuckySB commented Oct 6, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:

add worker node to cluster failed when
etcd_kubeadm_enabled: true

try to install etcdctl on etcd nodes in role etcd is not need.

When etcd setup by kubedamd - etcdctl installed from docker image, but in scale.yml playbook this task try to install from archive etcd_download_url:.

when install cluster with etcd_kubeadm_enabled: true etcd role not played.
so do not need install etcdctl when add worker node.

Remove task with install etcdctl from etcd role when etcd_kubeadm_enabled=true
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LuckySB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO October 6, 2020 12:16
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2020
@EppO
Copy link
Contributor

EppO commented Oct 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6a4d322 into kubernetes-sigs:master Oct 6, 2020
tevren added a commit to tevren/kubespray that referenced this pull request Oct 10, 2020
…ster

* 'master' of github.com:kubernetes-sigs/kubespray: (1632 commits)
  Chmod kubeconfig to avoid group-readable (kubernetes-sigs#6800)
  Update bunch of dependencies (kubernetes-sigs#6801)
  If no_proxy_exclude_workers is true, workers will be excluded from the no_proxy variable.  This prevents docker engine restarting when scaling workers. (kubernetes-sigs#6520)
  crio: ensure service is started and enabled (kubernetes-sigs#6753)
  Do not install etcd and etcdctl on master with scale.yml playbook. (kubernetes-sigs#6798)
  Fix csi-snapshotter timeout option. Fix ebs-external-attacher-role ClusterRole. (kubernetes-sigs#6776)
  Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745)
  Added Comment line above checksum section to add clarification about Kubespray's version support and testing (kubernetes-sigs#6785)
  Update nginx ingress controller to 0.40.1 (kubernetes-sigs#6786)
  Use v2.14.1 as base image for CI (kubernetes-sigs#6773)
  Add oomichi to reviewers (kubernetes-sigs#6796)
  Update triage/support label references to kind/support (kubernetes-sigs#6792)
  Update kube-router to 1.1.0 (kubernetes-sigs#6793)
  harden reset to work in more cases (kubernetes-sigs#6781)
  Add extra arguments variables for openstack and vsphere cloud controller manager daemonsets (kubernetes-sigs#6783)
  Update cilium with minor fix for CVE (kubernetes-sigs#6784)
  Add `plugins/mitogen` to `.gitignore` (kubernetes-sigs#6774)
  Remove arch from flannel image tag (kubernetes-sigs#6765)
  nginx ingress: fix yaml for multiple nodeselectors (kubernetes-sigs#6768)
  Forgotten debian10 test during nightly tests (kubernetes-sigs#6769)
  ...
erulabs added a commit to kubesail/kubespray that referenced this pull request Oct 13, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  crio: ensure service is started and enabled (kubernetes-sigs#6753)
  Do not install etcd and etcdctl on master with scale.yml playbook. (kubernetes-sigs#6798)
  Fix csi-snapshotter timeout option. Fix ebs-external-attacher-role ClusterRole. (kubernetes-sigs#6776)
  Fix cinder & external_openstack cacert deployment (kubernetes-sigs#6745)
  Added Comment line above checksum section to add clarification about Kubespray's version support and testing (kubernetes-sigs#6785)
  Update nginx ingress controller to 0.40.1 (kubernetes-sigs#6786)
  Use v2.14.1 as base image for CI (kubernetes-sigs#6773)
  Add oomichi to reviewers (kubernetes-sigs#6796)
LuckySB added a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
…ubernetes-sigs#6798)

Remove task with install etcdctl from etcd role when etcd_kubeadm_enabled=true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants