Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated flag for Cinder CSI controllerplugin #6358

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Remove deprecated flag for Cinder CSI controllerplugin #6358

merged 1 commit into from
Jul 13, 2020

Conversation

StevenReitsma
Copy link
Contributor

@StevenReitsma StevenReitsma commented Jul 1, 2020 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
#6221 broke the Cinder CSI plugin because a flag is being used that was removed

Special notes for your reviewer:
The --leader-election-type flag in the csi-attacher container is unsupported from the current version. It's deprecated in csi-provisioner, but the default there is still Endpoints instead of Lease so I guess we have to wait for the removal to change it.

See: https://github.com/kubernetes-csi/external-attacher

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 1, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @StevenReitsma. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 1, 2020
@k8s-ci-robot k8s-ci-robot requested review from alijahnas and LuckySB July 1, 2020 12:20
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 1, 2020
@StevenReitsma StevenReitsma force-pushed the feature/fix-cinder-csi-leader-election branch from 10394b0 to a4d868e Compare July 1, 2020 12:55
@StevenReitsma StevenReitsma changed the title Remove deprecated flags for Cinder CSI controllerplugin Remove deprecated flag for Cinder CSI controllerplugin Jul 1, 2020
@alijahnas
Copy link
Contributor

You mean that these changes will make leader-election-type always to endpoints until it is changed by the CSI driver?

@StevenReitsma
Copy link
Contributor Author

StevenReitsma commented Jul 1, 2020 •
edited
Loading

You mean that these changes will make leader-election-type always to endpoints until it is changed by the CSI driver?

Sorry, I initially removed the deprecated flag for the csi-provisioner as well but noticed afterwards that the default is still endpoints instead of leases for the provisioner, so I've removed that change from this PR.
For the csi-attacher however, only leases is supported and the --leader-election-type flag doesn't exist anymore. Currently, the csi-attacher container does not start without this PR.

@alijahnas
Copy link
Contributor

I see, the new version doesn't know what is the --leader-election-type flag.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2020
@StevenReitsma
Copy link
Contributor Author

StevenReitsma commented Jul 1, 2020 •
edited
Loading

Exactly!

I pushed another bugfix to this PR: the csi-attacher now needs patch verb on the volumeattachments resource in storage.k8s.io. See https://github.com/kubernetes-csi/external-attacher/blob/master/deploy/kubernetes/rbac.yaml#L20

Looks like the change in #6221 wasn't really tested 😄

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2020
@StevenReitsma
Remove old csi-attacher flag and fix RBAC for Cinder CSI
6686def 
Add proper RBAC for new csi-attacher version
@StevenReitsma StevenReitsma force-pushed the feature/fix-cinder-csi-leader-election branch from 0bc82b1 to 6686def Compare July 1, 2020 14:36
@floryut
Copy link
Member

floryut commented Jul 1, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 1, 2020
@StevenReitsma
Copy link
Contributor Author

@alijahnas would you mind taking another look after I made some additional changes? Thanks again.

@LuckySB
Copy link
Contributor

LuckySB commented Jul 7, 2020

/lgtm

@alijahnas

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2020
@alijahnas
Copy link
Contributor

@StevenReitsma
/lgtm

@Miouge1
Copy link
Contributor

Miouge1 commented Jul 13, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, StevenReitsma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit deca5ec into kubernetes-sigs:master Jul 13, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Jul 19, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
13dbcfe 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Add a way to deploy cilium alongside another CNI (kubernetes-sigs#6373)
  Cleanup old build-cephfs-provisioner.yml playbook (kubernetes-sigs#6418)
  Always enable GitLab CI artifacts for cluster-dump (kubernetes-sigs#6412)
  Remove allow-release-candidate-upgrades already include in experimental-upgrades flag (kubernetes-sigs#6349)
  add calico-node selinux (kubernetes-sigs#6359)
  Add oomichi to reviwers of MetalLB addon (kubernetes-sigs#6393)
  Respect kube_override_hostname during removal/upgrade (kubernetes-sigs#6347)
  Fixed fedora modular repos activation for fcos (kubernetes-sigs#6300)
  Fix kube-proxy post deployment removal (kubernetes-sigs#5554)
  Remove old csi-attacher flag and fix RBAC for Cinder CSI (kubernetes-sigs#6358)
  Update cilium minimum kernel preinstall check (kubernetes-sigs#6376)
  Add readiness probe to dns-autoscaler (kubernetes-sigs#6382)
  Add Fedora CoreOS kubevirt image for tests (kubernetes-sigs#6337)
  allow kubeadm to upgrade etcd (kubernetes-sigs#6345)
  crio: harden downloads with retry (kubernetes-sigs#6374)
  Add workaround with include_task for mitogen (kubernetes-sigs#6312)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Sep 16, 2020
@StevenReitsma @LuckySB
Remove old csi-attacher flag and fix RBAC for Cinder CSI (kubernetes-…
406b95d 
…sigs#6358)

Add proper RBAC for new csi-attacher version
This was referenced Sep 30, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuckySB LuckySB LuckySB approved these changes

@alijahnas alijahnas Awaiting requested review from alijahnas

Assignees

@LuckySB LuckySB

@alijahnas alijahnas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@StevenReitsma @k8s-ci-robot @alijahnas @floryut @LuckySB @Miouge1