Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local volume provisioner role workaround for mitogen #6312

Merged

Conversation

spaced
Copy link
Contributor

@spaced spaced commented Jun 23, 2020

workaround for delegate with mitogen

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

Exception ignored in: <bound method Connection.__del__ of <ansible.plugins.connection.mitogen_ssh.Connection object at 0x7f1d3f4ac278>>
Traceback (most recent call last):
  File "/opt/kubespray/plugins/mitogen/ansible_mitogen/connection.py", line 513, in __del__
    self.close()
  File "/opt/kubespray/plugins/mitogen/ansible_mitogen/connection.py", line 827, in close
    self._put_connection()
  File "/opt/kubespray/plugins/mitogen/ansible_mitogen/connection.py", line 808, in _put_connection
    self.chain.reset()
  File "/opt/kubespray/plugins/mitogen/mitogen/parent.py", line 1846, in reset
    self.call_no_reply(mitogen.core.Dispatcher.forget_chain, saved)
  File "/opt/kubespray/plugins/mitogen/mitogen/parent.py", line 1901, in call_no_reply
    self.context.send(self.make_msg(fn, *args, **kwargs))
  File "/opt/kubespray/plugins/mitogen/mitogen/core.py", line 2272, in send
    self.router.route(msg)
  File "/opt/kubespray/plugins/mitogen/mitogen/core.py", line 3345, in route
    self.broker.defer(self._async_route, msg)
  File "/opt/kubespray/plugins/mitogen/mitogen/core.py", line 2826, in defer
    raise Error(self.broker_shutdown_msg)
mitogen.core.Error: An attempt was made to enqueue a message with a Broker that has already exitted. It is likely your program called Broker.shutdown() too early.
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: mitogen.core.Error: An attempt was made to enqueue a message with a Broker that has already exitted. It is likely your program called Broker.shutdown() too early.
fatal: [mymaster0]: FAILED! => {"msg": "Unexpected failure during module execution.", "stdout": ""}

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 23, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and holmsten June 23, 2020 13:54
@k8s-ci-robot
Copy link
Contributor

Hi @spaced. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 23, 2020
@spaced spaced force-pushed the fix_provisioner_mitogen branch from 367ed89 to 75f18f5 Compare June 23, 2020 13:56
@spaced spaced changed the title bug-4533 local volume provisionier role fails with mitogen Local volume provisionier role workaround for mitogen Jun 23, 2020
@spaced spaced changed the title Local volume provisionier role workaround for mitogen Local volume provisioner role workaround for mitogen Jun 23, 2020
@floryut
Copy link
Member

floryut commented Jun 23, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 23, 2020
@spaced spaced force-pushed the fix_provisioner_mitogen branch from 75f18f5 to a3ae660 Compare June 29, 2020 21:36
@floryut
Copy link
Member

floryut commented Jul 2, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2020
@LuckySB
Copy link
Contributor

LuckySB commented Jul 7, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LuckySB, spaced

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9433fe4 into kubernetes-sigs:master Jul 7, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Jul 19, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Add a way to deploy cilium alongside another CNI (kubernetes-sigs#6373)
  Cleanup old build-cephfs-provisioner.yml playbook (kubernetes-sigs#6418)
  Always enable GitLab CI artifacts for cluster-dump (kubernetes-sigs#6412)
  Remove allow-release-candidate-upgrades already include in experimental-upgrades flag (kubernetes-sigs#6349)
  add calico-node selinux (kubernetes-sigs#6359)
  Add oomichi to reviwers of MetalLB addon (kubernetes-sigs#6393)
  Respect kube_override_hostname during removal/upgrade (kubernetes-sigs#6347)
  Fixed fedora modular repos activation for fcos (kubernetes-sigs#6300)
  Fix kube-proxy post deployment removal (kubernetes-sigs#5554)
  Remove old csi-attacher flag and fix RBAC for Cinder CSI (kubernetes-sigs#6358)
  Update cilium minimum kernel preinstall check (kubernetes-sigs#6376)
  Add readiness probe to dns-autoscaler (kubernetes-sigs#6382)
  Add Fedora CoreOS kubevirt image for tests (kubernetes-sigs#6337)
  allow kubeadm to upgrade etcd (kubernetes-sigs#6345)
  crio: harden downloads with retry (kubernetes-sigs#6374)
  Add workaround with include_task for mitogen (kubernetes-sigs#6312)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Sep 16, 2020
@spaced spaced deleted the fix_provisioner_mitogen branch June 10, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants