Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to deploy cilium alongside another CNI #6373

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Add a way to deploy cilium alongside another CNI #6373

merged 1 commit into from
Jul 17, 2020

Conversation

MrFreezeex
Copy link
Member

@MrFreezeex MrFreezeex commented Jul 3, 2020 •
edited
Loading

Signed-off-by: Arthur Outhenin-Chalandre [email protected]

What type of PR is this?
/kind feature

What this PR does / why we need it:
This add a simple way to deploy Cilium alongside another CNI.
With this (and my others PR #5554 and #6334) kubespray could deploy cilium as a replacement for kube-proxy alongside other CNI to benefit from all the features of cilium (observability, high performance with eBPF/XDP/...).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
I added a simple exception for cilium because I believe It is the only CNI that can replace kube-proxy while running with another CNI (or at least I didn't see any documentation for It in others CNI).

Does this PR introduce a user-facing change?:

Add cilium_deploy_additionally to deploy cilium alongside another CNI

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @MrFreezeex. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 3, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and holmsten July 3, 2020 23:49
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2020
@MrFreezeex MrFreezeex force-pushed the cilium-additionally branch from 0faf88d to 921b961 Compare July 4, 2020 00:28
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2020
@MrFreezeex MrFreezeex force-pushed the cilium-additionally branch from 921b961 to df49807 Compare July 5, 2020 16:09
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2020
@floryut
Copy link
Member

floryut commented Jul 6, 2020

@MrFreezeex Don't you also want to add check in download role (where cilium is checked) ?
And maybe roles/kubernetes/preinstall/tasks/0020-verify-settings.yml:133 but this seems outdated and rarely the case I'd say..

@floryut
Copy link
Member

floryut commented Jul 6, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 6, 2020
@MrFreezeex
Add a way to deploy cilium alongside another CNI
b01903b 
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
@MrFreezeex MrFreezeex force-pushed the cilium-additionally branch from df49807 to b01903b Compare July 6, 2020 15:23
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2020
@MrFreezeex
Copy link
Member Author

MrFreezeex commented Jul 6, 2020 •
edited
Loading

@floryut Indeed thanks for the reminder! I updated my PR accordingly. I will also send another PR to update the minimum kernel version.

@EppO
Copy link
Contributor

EppO commented Jul 10, 2020

love it! And I even think flannel could be setup the same way as it can be used along with other CNIs (like calico)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Jul 13, 2020

I like the idea, but I think it will be easy to forget about the or cilium_deploy_additionally.

Would kube_network_plugin as a list of plugins make sense?

@MrFreezeex
Copy link
Member Author

MrFreezeex commented Jul 13, 2020 •
edited
Loading

I like the idea, but I think it will be easy to forget about the or cilium_deploy_additionally.

Would kube_network_plugin as a list of plugins make sense?

I also thought about It too, but I preferred to make It this way to have a smaller PR and because I think a list of network plugin would be a bit overkill for a special case like that. It is however true that It would be easier in term of maintainability to have no special case at all...

I can update my PR to have a list of network plugin but the patchset would be significantly larger. WDYT ?

@Miouge1
Copy link
Contributor

Miouge1 commented Jul 17, 2020

/approve

There was a discussion on Slack about this, good enough for now.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, MrFreezeex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1a1fe99 into kubernetes-sigs:master Jul 17, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Jul 19, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
13dbcfe 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Add a way to deploy cilium alongside another CNI (kubernetes-sigs#6373)
  Cleanup old build-cephfs-provisioner.yml playbook (kubernetes-sigs#6418)
  Always enable GitLab CI artifacts for cluster-dump (kubernetes-sigs#6412)
  Remove allow-release-candidate-upgrades already include in experimental-upgrades flag (kubernetes-sigs#6349)
  add calico-node selinux (kubernetes-sigs#6359)
  Add oomichi to reviwers of MetalLB addon (kubernetes-sigs#6393)
  Respect kube_override_hostname during removal/upgrade (kubernetes-sigs#6347)
  Fixed fedora modular repos activation for fcos (kubernetes-sigs#6300)
  Fix kube-proxy post deployment removal (kubernetes-sigs#5554)
  Remove old csi-attacher flag and fix RBAC for Cinder CSI (kubernetes-sigs#6358)
  Update cilium minimum kernel preinstall check (kubernetes-sigs#6376)
  Add readiness probe to dns-autoscaler (kubernetes-sigs#6382)
  Add Fedora CoreOS kubevirt image for tests (kubernetes-sigs#6337)
  allow kubeadm to upgrade etcd (kubernetes-sigs#6345)
  crio: harden downloads with retry (kubernetes-sigs#6374)
  Add workaround with include_task for mitogen (kubernetes-sigs#6312)
@floryut floryut mentioned this pull request Aug 14, 2020
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Sep 16, 2020
@MrFreezeex @LuckySB
Add a way to deploy cilium alongside another CNI (kubernetes-sigs#6373)
a7c1ccc 
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
@MrFreezeex MrFreezeex mentioned this pull request Mar 14, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@EppO EppO

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MrFreezeex @k8s-ci-robot @floryut @EppO @Miouge1