Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow kubeadm to upgrade etcd #6345

Merged
merged 1 commit into from
Jul 7, 2020
Merged

allow kubeadm to upgrade etcd #6345

merged 1 commit into from
Jul 7, 2020

Conversation

hafe
Copy link
Contributor

@hafe hafe commented Jun 30, 2020 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #6344

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


etcd will be upgraded and its certs renewed when using a kubeadm managed etcd (etcd_kubeadm_enabled: true)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 30, 2020
@k8s-ci-robot k8s-ci-robot requested review from EppO and floryut June 30, 2020 07:50
@k8s-ci-robot
Copy link
Contributor

Hi @hafe. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 30, 2020
@LuckySB
Copy link
Contributor

LuckySB commented Jun 30, 2020

by default etcd installed by kubespray, not kubeadm

need to check etcd_kubeadm_enabled==true before remove thish options

@hafe
Copy link
Contributor Author

hafe commented Jun 30, 2020

by default etcd installed by kubespray, not kubeadm

need to check etcd_kubeadm_enabled==true before remove thish options

I thought the config file section controlled if kubeadm should manage etcd or not. Does anyone know?

@floryut
Copy link
Member

floryut commented Jul 1, 2020

by default etcd installed by kubespray, not kubeadm
need to check etcd_kubeadm_enabled==true before remove thish options

I thought the config file section controlled if kubeadm should manage etcd or not. Does anyone know?

What luckySB means is that you probably need to add a conditional thing, as this flag should only be removed when etcd_kubeadm_enabled is set to true

@hafe
Copy link
Contributor Author

hafe commented Jul 1, 2020

What luckySB means is that you probably need to add a conditional thing, as this flag should only be removed when etcd_kubeadm_enabled is set to true

I understand but my question is why would that be needed?

If kubeadm is not managing etcd why would you have tell it to not update etcd?

@hafe hafe force-pushed the kubeadm-upgrade-etcd-6344 branch from 5703d2f to 69fe8bd Compare July 4, 2020 12:05
@floryut
Copy link
Member

floryut commented Jul 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2020
@floryut
Copy link
Member

floryut commented Jul 6, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 6, 2020
@EppO
Copy link
Contributor

EppO commented Jul 6, 2020

Will etcd_version will be respected for the upgrade by kubeadm?

@hafe
Copy link
Contributor Author

hafe commented Jul 6, 2020

Will etcd_version will be respected for the upgrade by kubeadm?

I believe that is determined by the kubeadm config file laid down by kubespray so yes

@LuckySB
Copy link
Contributor

LuckySB commented Jul 7, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hafe, LuckySB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 22996ba into kubernetes-sigs:master Jul 7, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Jul 19, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
13dbcfe 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Add a way to deploy cilium alongside another CNI (kubernetes-sigs#6373)
  Cleanup old build-cephfs-provisioner.yml playbook (kubernetes-sigs#6418)
  Always enable GitLab CI artifacts for cluster-dump (kubernetes-sigs#6412)
  Remove allow-release-candidate-upgrades already include in experimental-upgrades flag (kubernetes-sigs#6349)
  add calico-node selinux (kubernetes-sigs#6359)
  Add oomichi to reviwers of MetalLB addon (kubernetes-sigs#6393)
  Respect kube_override_hostname during removal/upgrade (kubernetes-sigs#6347)
  Fixed fedora modular repos activation for fcos (kubernetes-sigs#6300)
  Fix kube-proxy post deployment removal (kubernetes-sigs#5554)
  Remove old csi-attacher flag and fix RBAC for Cinder CSI (kubernetes-sigs#6358)
  Update cilium minimum kernel preinstall check (kubernetes-sigs#6376)
  Add readiness probe to dns-autoscaler (kubernetes-sigs#6382)
  Add Fedora CoreOS kubevirt image for tests (kubernetes-sigs#6337)
  allow kubeadm to upgrade etcd (kubernetes-sigs#6345)
  crio: harden downloads with retry (kubernetes-sigs#6374)
  Add workaround with include_task for mitogen (kubernetes-sigs#6312)
@floryut floryut mentioned this pull request Aug 14, 2020
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Sep 16, 2020
@hafe @LuckySB
allow kubeadm to upgrade etcd (kubernetes-sigs#6345)
0bc2d8b 
Co-authored-by: Hans Feldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@floryut floryut Awaiting requested review from floryut

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade with kubeadm managed etcd does not upgrade etcd nor renew its certs
5 participants
@hafe @k8s-ci-robot @LuckySB @floryut @EppO