Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add calico-node selinux #6359

Merged
merged 1 commit into from
Jul 15, 2020
Merged

add calico-node selinux #6359

merged 1 commit into from
Jul 15, 2020

Conversation

chenguoquan1024
Copy link
Contributor

When I use calico network to test selinux for kubernetes， I find that when selinux enable , calico-node fail。
This is due to calico-node.yaml not have securityContext param.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When slinux enable calico-node can not run, we need add securityContext param

Which issue(s) this PR fixes:
projectcalico/calico#2704

Does this PR introduce a user-facing change?:
None

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 1, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @chenguoquan1024. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO July 1, 2020 12:22
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 1, 2020
@floryut
Copy link
Member

floryut commented Jul 1, 2020

What is the difference with #6290 ? (if no diff, please close the other, and in the future you can amend/force push instead of opening multiples PRs ^^)

@chenguoquan1024
Copy link
Contributor Author

What is the difference with #6290 ? (if no diff, please close the other, and in the future you can amend/force push instead of opening multiples PRs ^^)

I close #6290。

@chenguoquan1024
Copy link
Contributor Author

hello@floryut
fatal: [instance-1 -> localhost]: FAILED! => {"changed": false, "elapsed": 240, "msg": "Timeout when waiting for 172.30.72.52:22"}
this error is related to selinux ?

@floryut
Copy link
Member

floryut commented Jul 3, 2020

hello@floryut
fatal: [instance-1 -> localhost]: FAILED! => {"changed": false, "elapsed": 240, "msg": "Timeout when waiting for 172.30.72.52:22"}
this error is related to selinux ?

It is not :) I've restarted your job

@floryut
Copy link
Member

floryut commented Jul 6, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 6, 2020
@chenguoquan1024
Copy link
Contributor Author

@EppO @tomdee please view this pr -:)

@EppO
Copy link
Contributor

EppO commented Jul 8, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2020
@chenguoquan1024
Copy link
Contributor Author

@bozzo @floryut please view for me ：）

@Miouge1
Copy link
Contributor

Miouge1 commented Jul 13, 2020

Is this needed for all situations? If not we should consider a conditional statement to make sure it applies only when necessary. Nobody wants privileged containers if they can be avoided :)

@chenguoquan1024
Copy link
Contributor Author

@Miouge1 this needed for all situations。

@Miouge1
Copy link
Contributor

Miouge1 commented Jul 15, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenguoquan1024, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit e1873ab into kubernetes-sigs:master Jul 15, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Jul 19, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
13dbcfe 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Add a way to deploy cilium alongside another CNI (kubernetes-sigs#6373)
  Cleanup old build-cephfs-provisioner.yml playbook (kubernetes-sigs#6418)
  Always enable GitLab CI artifacts for cluster-dump (kubernetes-sigs#6412)
  Remove allow-release-candidate-upgrades already include in experimental-upgrades flag (kubernetes-sigs#6349)
  add calico-node selinux (kubernetes-sigs#6359)
  Add oomichi to reviwers of MetalLB addon (kubernetes-sigs#6393)
  Respect kube_override_hostname during removal/upgrade (kubernetes-sigs#6347)
  Fixed fedora modular repos activation for fcos (kubernetes-sigs#6300)
  Fix kube-proxy post deployment removal (kubernetes-sigs#5554)
  Remove old csi-attacher flag and fix RBAC for Cinder CSI (kubernetes-sigs#6358)
  Update cilium minimum kernel preinstall check (kubernetes-sigs#6376)
  Add readiness probe to dns-autoscaler (kubernetes-sigs#6382)
  Add Fedora CoreOS kubevirt image for tests (kubernetes-sigs#6337)
  allow kubeadm to upgrade etcd (kubernetes-sigs#6345)
  crio: harden downloads with retry (kubernetes-sigs#6374)
  Add workaround with include_task for mitogen (kubernetes-sigs#6312)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Sep 16, 2020
@chenguoquan1024 @LuckySB
add calico-node selinux (kubernetes-sigs#6359)
6e9bb75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@EppO EppO Awaiting requested review from EppO

Assignees

@EppO EppO

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chenguoquan1024 @k8s-ci-robot @floryut @EppO @Miouge1