Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix kubelet_flexvolumes_plugins_dir undefined #6645

Merged
merged 1 commit into from
Sep 11, 2020
Merged

fix kubelet_flexvolumes_plugins_dir undefined #6645

merged 1 commit into from
Sep 11, 2020

Conversation

w33dw0r7d
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:
Fix kubelet_flexvolumes_plugins_dir undefined error.

Which issue(s) this PR fixes:

Fixes #6640

Special notes for your reviewer:

Need merge in 2.14.0 branch.

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 9, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @w33dw0r7d. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 9, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2020
@floryut
Copy link
Member

floryut commented Sep 9, 2020

@w33dw0r7d Thank you for the PR, could you change the commit message and remove the issue ID ? PR ID will be automatically added to the commit message (which links to the issue)
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2020
@w33dw0r7d w33dw0r7d changed the title '#6640 - fix kubelet_flexvolumes_plugins_dir undefined in v2.14.0' fix kubelet_flexvolumes_plugins_dir undefined Sep 9, 2020
@w33dw0r7d
Copy link
Contributor Author

@floryut done

@floryut
Copy link
Member

floryut commented Sep 9, 2020

Thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2020
@floryut
Copy link
Member

floryut commented Sep 9, 2020

/assign @Miouge1

@Miouge1
Copy link
Contributor

Miouge1 commented Sep 11, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, w33dw0r7d

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 03dff09 into kubernetes-sigs:master Sep 11, 2020
floryut pushed a commit to floryut/kubespray that referenced this pull request Sep 11, 2020
@w33dw0r7d @floryut
fix kubelet_flexvolumes_plugins_dir undefined (kubernetes-sigs#6645)
cfbc21d
@floryut floryut mentioned this pull request Sep 11, 2020
Merged
erulabs added a commit to kubesail/kubespray that referenced this pull request Sep 12, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
cb0b0ae 
* 'master' of https://github.com/kubernetes-sigs/kubespray: (32 commits)
  Update api version, deprecated in 1.19 (kubernetes-sigs#6656)
  Update etcd to 3.4.13 (kubernetes-sigs#6658)
  Update dockerfile for v1.19.1 (kubernetes-sigs#6668)
  yamllint: ignore .git dir (kubernetes-sigs#6667)
  fix kubelet_flexvolumes_plugins_dir undefined (kubernetes-sigs#6645)
  Remove deprecated (and removed in 1.19) flag and function --basic-auth-file (kubernetes-sigs#6655)
  Update CoreDNS to 1.7.0 (kubernetes-sigs#6657)
  Update various dependencies following 1.19 release (kubernetes-sigs#6660)
  Add Kubernetes 1.19.1 hashes and set default (kubernetes-sigs#6654)
  crio: use system default for storage driver by default (kubernetes-sigs#6637)
  Add iptables_backend to weave options (kubernetes-sigs#6639)
  Add comment clarifying network allocation and sizes (kubernetes-sigs#6607)
  Allowing resource management of metrics-server container.  Will allow fine-tuning of resource allocation and solving throttling issues. Setting defaults as per the current request & limit allocation: cpu: 43m, memory 55Mi for both limits & requests. (kubernetes-sigs#6652)
  Fix a bunch of failed quality rules (kubernetes-sigs#6646)
  Update calico to 3.16.1 (kubernetes-sigs#6644)
  NetworkManager lists must be separated by , (kubernetes-sigs#6643)
  Set ansible_python_interpreter to python3 on debian (fix error with mitogen) (kubernetes-sigs#6633)
  Use v2.14.0 as base image for CI (kubernetes-sigs#6636)
  Cleanup v1.16 hashes (kubernetes-sigs#6635)
  Update kube_version_min_required for 2.14 release (kubernetes-sigs#6634)
  ...
k8s-ci-robot pushed a commit that referenced this pull request Sep 18, 2020
@floryut @w33dw0r7d
fix kubelet_flexvolumes_plugins_dir undefined (#6645) (#6670)
fbbbd90 
Co-authored-by: w33dw0r7d <[email protected]>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
@w33dw0r7d @LuckySB
fix kubelet_flexvolumes_plugins_dir undefined (kubernetes-sigs#6645)
a1063f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alijahnas alijahnas Awaiting requested review from alijahnas

@LuckySB LuckySB Awaiting requested review from LuckySB

Assignees

@Miouge1 Miouge1

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubelet_flexvolumes_plugins_dir undefined in v2.14.0
4 participants
@w33dw0r7d @k8s-ci-robot @floryut @Miouge1