-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kubernetes 1.19.1 hashes and set default #6654
Conversation
fa79b84
to
3d7920f
Compare
3d7920f
to
838eb24
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -23,7 +23,6 @@ cert_manager_enabled: true | |||
metrics_server_enabled: false | |||
metrics_server_kubelet_insecure_tls: true | |||
kube_token_auth: true | |||
kube_basic_auth: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is linked to #6655, as it's no longer available in 1.19 anyhow
@@ -81,6 +81,7 @@ | |||
jsonpath='{range .items[?(.spec.hostNetwork)]}{.metadata.name} {.status.podIP} {.status.containerStatuses} {end}'" | |||
changed_when: false | |||
register: hostnet_pods | |||
ignore_errors: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now output a rc1 as the key isn't found (hostNetwork) when not in hostNetwork mode
/lgtm |
* 'master' of https://github.com/kubernetes-sigs/kubespray: (32 commits) Update api version, deprecated in 1.19 (kubernetes-sigs#6656) Update etcd to 3.4.13 (kubernetes-sigs#6658) Update dockerfile for v1.19.1 (kubernetes-sigs#6668) yamllint: ignore .git dir (kubernetes-sigs#6667) fix kubelet_flexvolumes_plugins_dir undefined (kubernetes-sigs#6645) Remove deprecated (and removed in 1.19) flag and function --basic-auth-file (kubernetes-sigs#6655) Update CoreDNS to 1.7.0 (kubernetes-sigs#6657) Update various dependencies following 1.19 release (kubernetes-sigs#6660) Add Kubernetes 1.19.1 hashes and set default (kubernetes-sigs#6654) crio: use system default for storage driver by default (kubernetes-sigs#6637) Add iptables_backend to weave options (kubernetes-sigs#6639) Add comment clarifying network allocation and sizes (kubernetes-sigs#6607) Allowing resource management of metrics-server container. Will allow fine-tuning of resource allocation and solving throttling issues. Setting defaults as per the current request & limit allocation: cpu: 43m, memory 55Mi for both limits & requests. (kubernetes-sigs#6652) Fix a bunch of failed quality rules (kubernetes-sigs#6646) Update calico to 3.16.1 (kubernetes-sigs#6644) NetworkManager lists must be separated by , (kubernetes-sigs#6643) Set ansible_python_interpreter to python3 on debian (fix error with mitogen) (kubernetes-sigs#6633) Use v2.14.0 as base image for CI (kubernetes-sigs#6636) Cleanup v1.16 hashes (kubernetes-sigs#6635) Update kube_version_min_required for 2.14 release (kubernetes-sigs#6634) ...
What type of PR is this?
/kind feature
What this PR does / why we need it:
Update hashes with new kubernetes version
Set default to 1.19.x, let's see.. :)
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?: