Fix a bunch of failed quality rules (in tests) #6646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/M
floryut
changed the title
spaced
approved these changes
Sep 9, 2020
oomichi
reviewed
Sep 9, 2020
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, woopstar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
erulabs
added a commit
to kubesail/kubespray
that referenced
this pull request
Sep 12, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray: (32 commits) Update api version, deprecated in 1.19 (kubernetes-sigs#6656) Update etcd to 3.4.13 (kubernetes-sigs#6658) Update dockerfile for v1.19.1 (kubernetes-sigs#6668) yamllint: ignore .git dir (kubernetes-sigs#6667) fix kubelet_flexvolumes_plugins_dir undefined (kubernetes-sigs#6645) Remove deprecated (and removed in 1.19) flag and function --basic-auth-file (kubernetes-sigs#6655) Update CoreDNS to 1.7.0 (kubernetes-sigs#6657) Update various dependencies following 1.19 release (kubernetes-sigs#6660) Add Kubernetes 1.19.1 hashes and set default (kubernetes-sigs#6654) crio: use system default for storage driver by default (kubernetes-sigs#6637) Add iptables_backend to weave options (kubernetes-sigs#6639) Add comment clarifying network allocation and sizes (kubernetes-sigs#6607) Allowing resource management of metrics-server container. Will allow fine-tuning of resource allocation and solving throttling issues. Setting defaults as per the current request & limit allocation: cpu: 43m, memory 55Mi for both limits & requests. (kubernetes-sigs#6652) Fix a bunch of failed quality rules (kubernetes-sigs#6646) Update calico to 3.16.1 (kubernetes-sigs#6644) NetworkManager lists must be separated by , (kubernetes-sigs#6643) Set ansible_python_interpreter to python3 on debian (fix error with mitogen) (kubernetes-sigs#6633) Use v2.14.0 as base image for CI (kubernetes-sigs#6636) Cleanup v1.16 hashes (kubernetes-sigs#6635) Update kube_version_min_required for 2.14 release (kubernetes-sigs#6634) ...
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Fix 305 and 301 in tests
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?: