Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capi: ubuntu-1804: use python3 #249

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Conversation

jsen-
Copy link
Contributor

@jsen- jsen- commented Jun 8, 2020

make build-qemu-ubuntu-1804 was failing on ansible with /bin/sh: 1: /usr/bin/python, adding the python package to preseed.cfg seems to help

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @jsen-!

It looks like this is your first PR to kubernetes-sigs/image-builder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/image-builder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 8, 2020
@k8s-ci-robot k8s-ci-robot requested review from detiber and ncdc June 8, 2020 11:36
@jsen-
Copy link
Contributor Author

jsen- commented Jun 8, 2020

/assign @ncdc

@detiber
Copy link
Member

detiber commented Jun 8, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2020
@ncdc
Copy link
Contributor

ncdc commented Jun 8, 2020

@codenrhoden any concerns here?

@hidekazuna
Copy link
Contributor

You may use python2. Please use python3.
https://docs.ansible.com/ansible/latest/reference_appendices/python_3_support.html

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2020
@jsen- jsen- changed the title capi: ubuntu-1804: install python capi: ubuntu-1804: use python3 Jun 10, 2020
@jsen-
Copy link
Contributor Author

jsen- commented Jun 10, 2020

according to comment from @hidekazuna, PR was updated so that python3 is used instead of installing python2

/assign @detiber

@k8s-ci-robot
Copy link
Contributor

@jsen-: GitHub didn't allow me to assign the following users: detibe.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

according to comment from @hidekazuna, PR was updated so that python3 is used instead of installing python2

/assign @detibe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codenrhoden
Copy link
Contributor

/lgtm
/approve

@codenrhoden any concerns here?

No concerns with this change specifically. On a broader scope, I've always had a bit of unease in that there isn't a clear cutline for different OS's on which ones are only Python2 or Python3. Looking at the Ubuntu DEBs we install, it appears to be only Python3 packages, but the CentOS and Photon RPMs have a mix of 2/3, and I'm not sure if that's really required, or if it's been bandage on top of bandage to keep things working.

So there's some tech debt there. :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codenrhoden, jsen-

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7ac67f2 into kubernetes-sigs:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants