-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
capi: ubuntu-1804: use python3 #249
Conversation
Welcome @jsen-! |
/assign @ncdc |
/lgtm |
@codenrhoden any concerns here? |
You may use python2. Please use python3. |
according to comment from @hidekazuna, PR was updated so that python3 is used instead of installing python2 /assign @detiber |
@jsen-: GitHub didn't allow me to assign the following users: detibe. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm
No concerns with this change specifically. On a broader scope, I've always had a bit of unease in that there isn't a clear cutline for different OS's on which ones are only Python2 or Python3. Looking at the Ubuntu DEBs we install, it appears to be only Python3 packages, but the CentOS and Photon RPMs have a mix of 2/3, and I'm not sure if that's really required, or if it's been bandage on top of bandage to keep things working. So there's some tech debt there. :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codenrhoden, jsen- The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
make build-qemu-ubuntu-1804
was failing on ansible with/bin/sh: 1: /usr/bin/python
, adding the python package topreseed.cfg
seems to help