Add `geoseries.distance` #13

isVoid · 2023-07-26T06:32:46Z

Description

This PR adds geoseries.distance to compute distances between two geoseries.

Checklist

I am familiar with the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.

…ing distance API (rapidsai#747) Follow up to rapidsai#731 , this PR introduces a new range object named `multilinestring_range` and simplifies the point-linestring distance API. Closes rapidsai#705 . Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Mark Harris (https://github.com/harrism) - H. Thomson Comer (https://github.com/thomcom) URL: rapidsai#747

…idsai#752) This PR augments Cuspatial Vector Equality Test Utility with an extra parameter to allow user pass in pre-defined absolute error. In many cases, cuspatial has to compare results with external libraries such as shapely or gdal. Since cuspatial allows user to pick computation precision based on input data (not a bug!), requiring the result to match external libraries within 4ULP is often too stringent, as external libraries often perform computation in different precisions. Adding the flexibility to specifiy abs error in test utilitiy makes it easy for developer to pick desired error range based on specific use cases. This PR also introduces a test macro that shows lineno of failed tests. Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Mark Harris (https://github.com/harrism) URL: rapidsai#752

This PR replaces the existing markdown issue templates with [form-based YML templates](https://github.blog/changelog/2021-06-23-issues-forms-beta-for-public-repositories/). They provide a more interactive experience and can require certain fields be filled out prior to issue submission. Authors: - Ben Jarmak (https://github.com/jarmak-nv) Approvers: - Mark Harris (https://github.com/harrism) - H. Thomson Comer (https://github.com/thomcom) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#748

This is a port of rapidsai/cudf#12067. Original post: > The current version of nvbench is not compatible with the latest changes to fmt. This PR decouples us from needing to wait on upstreaming the compatibility changes to nvbench. These changes are necessary for building libcudf benchmarks until then. Authors: - Michael Wang (https://github.com/isVoid) Approvers: - H. Thomson Comer (https://github.com/thomcom) URL: rapidsai#783

The `new-issues-to-triage-project.yml` Action automatically adds issues to a few different classic GitHub boards that we're no longer using. This PR deletes the now-unnecessary action. Authors: - Ben Jarmak (https://github.com/jarmak-nv) Approvers: - H. Thomson Comer (https://github.com/thomcom) - AJ Schmidt (https://github.com/ajschmidt8) - Mark Harris (https://github.com/harrism) URL: rapidsai#779

…apidsai#773) This PR adds `float_eq_by_ulp` utility to allow practical near equality for floating point computation in device code. In GIS application, near equal is often required due to rounding error of floating point and may wrong categorization of line collinearity or point on line test. Using this test does not incur visible performance degradation: ``` $ python ~/scratch/nvbench/scripts/nvbench_compare.py naive.json ulp.json ['naive.json', 'ulp.json'] # floating_point_equivalence_benchmark ## [0] Tesla V100-SXM2-32GB | FloatingPointType | NumFloats | Ref Time | Ref Noise | Cmp Time | Cmp Noise | Diff | %Diff | Status | |---------------------|-------------|------------|-------------|------------|-------------|-----------|---------|----------| | F32 | 100000 | 2.617 us | 55.95% | 2.478 us | 53.16% | -0.139 us | -5.30% | PASS | | F32 | 1000000 | 2.508 us | 59.48% | 2.471 us | 53.17% | -0.037 us | -1.49% | PASS | | F32 | 10000000 | 2.509 us | 58.42% | 2.553 us | 52.45% | 0.044 us | 1.76% | PASS | | F32 | 100000000 | 2.612 us | 56.19% | 2.483 us | 55.23% | -0.129 us | -4.94% | PASS | | F64 | 100000 | 2.501 us | 72.35% | 2.483 us | 54.59% | -0.018 us | -0.72% | PASS | | F64 | 1000000 | 2.514 us | 60.63% | 2.564 us | 55.11% | 0.050 us | 1.98% | PASS | | F64 | 10000000 | 2.609 us | 56.87% | 2.492 us | 56.80% | -0.117 us | -4.48% | PASS | | F64 | 100000000 | 2.519 us | 61.38% | 2.495 us | 57.26% | -0.025 us | -0.98% | PASS | ``` Note that the run time is very small in time scale so the result is very noisy. The average time difference is very small though. Authors: - Michael Wang (https://github.com/isVoid) Approvers: - H. Thomson Comer (https://github.com/thomcom) - Mark Harris (https://github.com/harrism) URL: rapidsai#773

…nge`, adds support to multilinestring distance (rapidsai#755) Note, this is the first part of `pairwise_linestring_distance` refactoring, part 1 of PR: rapidsai#753 Depends on rapidsai#752 Contributes to rapidsai#706, rapidsai#703 Closes rapidsai#745 Authors: - Michael Wang (https://github.com/isVoid) Approvers: - H. Thomson Comer (https://github.com/thomcom) - Mark Harris (https://github.com/harrism) URL: rapidsai#755

Closes rapidsai#772 , Address various issue with vector equivalent utility. Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Mark Harris (https://github.com/harrism) URL: rapidsai#777

) Closes rapidsai#563 In addition to refactoring to header-only API, this PR changes the implementation to use `thrust_transform` (two input version) instead of `thrust::adjacent_difference`. This simplifies the code a bit and eliminates the need for the `duplicate_first_element_iterator`, which was a bit confusing. Authors: - Mark Harris (https://github.com/harrism) Approvers: - Michael Wang (https://github.com/isVoid) URL: rapidsai#769

Moves NVIDIA channel last in in the conda dev environment channel list to fix solving when building from source / rapids-compose. Authors: - Mark Harris (https://github.com/harrism) Approvers: - Bradley Dice (https://github.com/bdice) - Mark Sadang (https://github.com/msadang) URL: rapidsai#787

`cudf.merge` doesn't guarantee item ordering, an important feature of `loc`. This PR fixes that by adding a reordering step to post processing the merge. Fixes rapidsai#781 Authors: - H. Thomson Comer (https://github.com/thomcom) Approvers: - Michael Wang (https://github.com/isVoid) URL: rapidsai#782

Closes rapidsai#771 This PR modifies the production of `geometry_offset`, `part_offset`, and `ring_offset` by sampling the existing values in a `GeoSeries` before returning their various offsets. This has the effect of using `cudf.ListSeries` to re-pack any features into a new, dense `GeoColumn`, then returning the offsets based on it. Previously, `GeoSeries` that had been modified by slicing would have the appearance of the sliced elements, but when `_offset` buffers were used they would return the full original offset buffer that the sliced `GeoSeries` had originated from. This was a problem because it made slicing useless for our algorithms. I also modify the `core/spatial/distance.py` and `core/spatial/nearest_points.py` files to use `as_column(linestrings.lines.geometry_offset)` instead of `linestrings.lines.geometry_offset._column` because there doesn't appear to be a reason to use a `cudf.Series` to wrap the offset buffers. They are private methods essentially, don't need indexes, and will eventually be factored out so that they're hidden from the user. I wrote a new test file `test_geocolumn_accessor.py` to exercise the new {`geometry_buffer`...} accessors for all geometry types. Finally I added tests for a base case, a more complicated case, and a case with noncontiugous slices to the inputs of `test_point_linestring_distance.py`, validating that the changes have exactly the effect we need. Authors: - H. Thomson Comer (https://github.com/thomcom) Approvers: - Michael Wang (https://github.com/isVoid) URL: rapidsai#776

Replaces all uses of "polyline" (and abbreviations) globally in cuspatial with "linestring" for consistency. Fixes rapidsai#520 Authors: - Mark Harris (https://github.com/harrism) Approvers: - Michael Wang (https://github.com/isVoid) URL: rapidsai#788

Fixes issues seen in rapidsai#788. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Mark Harris (https://github.com/harrism) - H. Thomson Comer (https://github.com/thomcom) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#791

Closes rapidsai#763 , this PR introduces device primitive for segment-segment intersection. Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Mark Harris (https://github.com/harrism) URL: rapidsai#778

…wise_linestring_distance` (rapidsai#786) This is a port of the second half of rapidsai#753, closes rapidsai#706 Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Mark Harris (https://github.com/harrism) - H. Thomson Comer (https://github.com/thomcom) URL: rapidsai#786