Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Internal Function intersection_count_upper_bound #795

Merged
merged 12 commits into from
Nov 22, 2022
Merged

Add Internal Function intersection_count_upper_bound #795

merged 12 commits into from
Nov 22, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Nov 11, 2022

Description

This PR adds intersection_count_upper_bound and count, for each pair of the input multilinestring, how many intersecting points and overlapping segments at most the pair can produce. This is the first stage of the linestring primitive.

closes #784

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested review from a team as code owners November 11, 2022 00:41
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Nov 11, 2022
@isVoid isVoid requested review from harrism and removed request for cwharris and jrhemstad November 11, 2022 00:41
@isVoid isVoid self-assigned this Nov 11, 2022
@isVoid isVoid added feature request New feature or request non-breaking Non-breaking change labels Nov 11, 2022
@isVoid
Copy link
Contributor Author

isVoid commented Nov 12, 2022

Still depends on #778 to compile.

@isVoid isVoid added the 0 - Blocked Cannot progress due to external reasons label Nov 12, 2022
@harrism harrism added c++ and removed libcuspatial Relates to the cuSpatial C++ library labels Nov 14, 2022
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Nov 15, 2022
@isVoid
Copy link
Contributor Author

isVoid commented Nov 16, 2022

rerun tests

@isVoid isVoid added 3 - Ready for Review Ready for review by team and removed 0 - Blocked Cannot progress due to external reasons labels Nov 16, 2022
harrism
harrism requested changes Nov 16, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress. Just a couple of small fixes.

cpp/include/cuspatial/cuda_utils.hpp Show resolved Hide resolved
cpp/include/cuspatial/detail/utility/device_atomics.cuh Outdated Show resolved Hide resolved
cpp/include/cuspatial/detail/utility/device_atomics.cuh Show resolved Hide resolved
cpp/include/cuspatial/experimental/detail/linestring_intersection_count.cuh Outdated Show resolved Hide resolved
cpp/include/cuspatial/experimental/detail/linestring_intersection_count.cuh Outdated Show resolved Hide resolved
@harrism harrism removed the c++ label Nov 16, 2022
@isVoid isVoid requested a review from harrism November 16, 2022 21:49
@harrism harrism changed the title Adds Internal Function intersection_count_upper_bound Add Internal Function intersection_count_upper_bound Nov 21, 2022
harrism
harrism approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording comment.

cpp/include/cuspatial/detail/utility/device_atomics.cuh Outdated Show resolved Hide resolved
cpp/include/cuspatial/detail/utility/device_atomics.cuh Outdated Show resolved Hide resolved
@isVoid isVoid added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 22, 2022
@isVoid
Copy link
Contributor Author

isVoid commented Nov 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e88e3d3 into rapidsai:branch-22.12 Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad left review comments

@harrism harrism harrism approved these changes

@thomcom thomcom Awaiting requested review from thomcom thomcom is a code owner automatically assigned from rapidsai/cuspatial-cmake-codeowners

Assignees

@isVoid isVoid

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cmake Related to CMake code or build configuration feature request New feature or request libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

intersection_count_upper_bound implementation
3 participants
@isVoid @harrism @jrhemstad