Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose streams in all public copying APIs #13629

Merged
merged 10 commits into from
Jul 13, 2023
Merged

Expose streams in all public copying APIs #13629

merged 10 commits into from
Jul 13, 2023
+567 −123

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jun 28, 2023

Description

Contributes to #925.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added feature request New feature or request 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. breaking Breaking change labels Jun 28, 2023
@vyasr vyasr added this to the Enable streams milestone Jun 28, 2023
@vyasr vyasr requested a review from a team as a code owner June 28, 2023 03:54
@vyasr vyasr self-assigned this Jun 28, 2023
@vyasr vyasr requested review from bdice and mythrocks June 28, 2023 03:54
@github-actions github-actions bot added the CMake CMake build issue label Jun 28, 2023
@vyasr vyasr requested a review from davidwendt July 11, 2023 21:02
bdice
bdice reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor comments/requests. Happy to approve once we've discussed.

cpp/tests/streams/copying_test.cpp Show resolved Hide resolved
cpp/src/transform/one_hot_encode.cu Show resolved Hide resolved
cpp/include/cudf_test/column_wrapper.hpp Show resolved Hide resolved
cpp/include/cudf_test/column_wrapper.hpp Show resolved Hide resolved
cpp/include/cudf/copying.hpp Outdated Show resolved Hide resolved
@vyasr vyasr mentioned this pull request Jul 11, 2023
Closed
@vyasr vyasr requested a review from bdice July 11, 2023 22:21
@vyasr
Copy link
Contributor Author

vyasr commented Jul 11, 2023

@davidwendt apologies for the confusion. I've properly addressed your requests now I believe.

@vyasr vyasr force-pushed the feat/streams_copying branch from 4f4d28f to e8e09f3 Compare July 11, 2023 22:21
bdice
bdice approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Thanks!

mythrocks
mythrocks reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of clarifying questions.

davidwendt
davidwendt requested changes Jul 12, 2023
View reviewed changes
cpp/tests/streams/copying_test.cpp Outdated Show resolved Hide resolved
cpp/include/cudf/copying.hpp Show resolved Hide resolved
@vyasr vyasr requested a review from davidwendt July 12, 2023 20:49
@vyasr
Copy link
Contributor Author

vyasr commented Jul 13, 2023

/merge

@rapids-bot rapids-bot bot merged commit c44da12 into rapidsai:branch-23.08 Jul 13, 2023
@vyasr vyasr deleted the feat/streams_copying branch July 13, 2023 01:32
@isVoid isVoid mentioned this pull request Jul 14, 2023
Merged
3 tasks
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this pull request Jul 17, 2023
@isVoid
Add streams to allocate_like call (#1218)
29fb208 
rapidsai/cudf#13629 added stream argument to all copying APIs. This fix makes sure cuspatial usage is compliant.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #1218
@bdice bdice mentioned this pull request Jul 21, 2023
Merged
3 tasks
This was referenced Jul 24, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@davidwendt davidwendt davidwendt approved these changes

@mythrocks mythrocks mythrocks approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team breaking Breaking change CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
Enable streams
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @bdice @mythrocks @davidwendt