-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve wording #9943
Closed
Closed
Improve wording #9943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: A Thousand Ships <[email protected]>
…stem.rst Co-authored-by: A Thousand Ships <[email protected]>
`AnimationNode`'s inherited classes are `Resource`, `RefCounted`, and `Object`. I assume it meant to say "derived classes", or something along the lines of "and all classes which inherit it".
Bump version
…extension-system Fix project structure diagram in gdextension docs system docs
…ith positive, zero, and negative ranges. (#9489)
Fix glTF capitalization in manual
Add commas before "but" throughout documentation
…ocessing Fix compile error in advanced_postprocessing.rst
In "avoidance_priority" property description, changed "important npcs characters" to "important non playable characters". The term "npc", means "non playable character", so to say "non playable characters characters" seems like an error.
Update iOS system requirements.
Corrected grammar on line 141
Correct menu layout
Fixing issues/9775
Add compilation instructions for RISC-V
Add note about the create_test.py script
Add example to advanced_postprocessing.rst
…-correction Tileset custom metadata correction
Update getting started 2D to 4.3
Document reflection probe limitations in compatability renderer
Add note about limitations of macOS export from Windows.
classref: Sync with current master branch (5675c76)
…-property Fix `ADD_PROPERTY()` calls in GDExtension C++ example to use correct syntax
…ction Document testing signals
Update release support timelines: 4.4 ETA, 3.6 is released
Correct "ConnectionCheck" return type
…eter-evans/create-pull-request-7 Bump peter-evans/create-pull-request from 6 to 7
Fix comment syntax in chroma key example shader
Add 3->4 upgrading information about NDC, light(), and reverse-z
clayjohn
approved these changes
Sep 11, 2024
skyace65
requested changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs to target the master branch, not 4.3. Changes that are relevant get cherry picked to 4.3. We have a guide on how to change that here or you could close this PR and open a new one, either works.
My bad, rebased and opened PR #9945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.