-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compilation instructions for RISC-V #9862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
6eee116
to
7864d01
Compare
Squashed the commits, hopefully all is good now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried following these instructions on an Ubuntu 24.04 x86_64 host and it failed at linking: EDIT: 22.04
[Initial build] Compiling core/error/error_list.cpp ...
[Initial build] Compiling core/error/error_macros.cpp ...
[Initial build] progress_finish(["progress_finish"], [])
[Initial build] Generating servers/rendering/renderer_rd/shaders/environment/voxel_gi_sdf.glsl.gen.h ...
[Initial build] Generating servers/rendering/renderer_rd/shaders/giprobe_write.glsl.gen.h ...
[Initial build] Linking Static Library servers/libservers.linuxbsd.editor.rv64.llvm.a ...
Ranlib Library servers/libservers.linuxbsd.editor.rv64.llvm.a ...
[Initial build] Linking Static Library core/libcore.linuxbsd.editor.rv64.llvm.a ...
Ranlib Library core/libcore.linuxbsd.editor.rv64.llvm.a ...
[Initial build] Linking Program bin/godot.linuxbsd.editor.rv64.llvm ...
mold: unknown -m argument: elf64lriscv
clang: error: linker command failed with exit code 1 (use -v to see invocation)
scons: *** [bin/godot.linuxbsd.editor.rv64.llvm] Error 1
scons: building terminated because of errors.
[Time elapsed: 00:02:42.42]
I see |
@MBCX That is the exact file I downloaded. Filename |
Interesting then. Let me try to compile with the prebuilt and see if I can reproduce it (I compile with a custom-built toolchain). |
@aaronfranke Sadly, I wasn't able to reproduce your issue on my Zorin OS 16.3 laptop (Ubuntu 20.04.3 LTS based) with the same toolchain ( In the meantime, could you try enabling |
According to my test, the openKylin 2.0 system can be compiled successfully, which is my compilation step. https://bbs.openkylin.top/t/topic/171569 Don't forget that you need GCC13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, I figured out what was wrong. I thought my desktop was Ubuntu 24.04 but it was actually 22.04, which has too old of a Mold version in its repositories.
A simple change to the documentation will fix this: Add a note for how to check the supported architectures of Mold.
49cde51
to
2a85b24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks! And congrats on your first merged PR! |
Cherry-picked to 4.3 in #10038. |
This adds detailed instructions for how to successfully build 4.x (and possibly 3.x) versions of Godot for this ISA.
While these instructions are more focused on cross-compilation, it should also work on native RISC-V devices.
Solves #91381.