Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ADD_PROPERTY() calls in GDExtension C++ example to use correct syntax #9918

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 6, 2024

This matches how properties are declared in core Godot.

…syntax

This matches how properties are declared in core Godot.
@Calinou Calinou added bug topic:gdextension cherrypick:4.2 cherrypick:4.3 area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Sep 6, 2024
@Calinou Calinou requested review from paddy-exe and dsnopek September 6, 2024 20:27
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks correct to me :-)

Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhilbrunner mhilbrunner merged commit ea97a4d into godotengine:master Sep 9, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thank you, and thanks for the reviews everyone! :)

@Calinou Calinou deleted the gdextension-cpp-example-fix-add-property branch September 15, 2024 15:52
@mhilbrunner
Copy link
Member

Cherry-picked to 4.3 in #10038.

@Batodalaev
Copy link

Hello everyone.

FYI, https://docs.godotengine.org/ru/4.x/tutorials/scripting/gdextension/gdextension_cpp_example.html not updated yet.

For example this string:
ADD_PROPERTY("GDExample", PropertyInfo(Variant::FLOAT, "speed", PROPERTY_HINT_RANGE, "0,20,0.01"), "set_speed", "get_speed");
here must be removed "GDExample",

Something went wrong?
Or how much time should pass?

@paddy-exe
Copy link
Contributor

@Batodalaev The translated docs are merged before every release candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug cherrypick:4.2 topic:gdextension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants