Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example to advanced_postprocessing.rst #9766

Merged

Conversation

tetrapod00
Copy link
Contributor

@tetrapod00 tetrapod00 commented Aug 16, 2024

Adds a complete example to Advanced Postprocessing. Also removes an unneeded varying to send INV_VIEW_MATRIX to fragment().

The example shader is constructed by following the steps in the tutorial, then adding output ALBEDO lines. It compiles as expected in 4.3 Forward+.

@skyace65 skyace65 added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:shaders labels Aug 16, 2024
Adds a complete example. Also removes an unneeded varying.
@tetrapod00 tetrapod00 force-pushed the advanced-postprocessing-example branch from e2903b6 to d49dfae Compare August 18, 2024 07:16
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the shader and it works!

@skyace65 skyace65 merged commit 4d42b74 into godotengine:master Sep 7, 2024
1 check passed
@skyace65
Copy link
Contributor

skyace65 commented Sep 7, 2024

Thanks! Apologies for the long wait on a review

@tetrapod00 tetrapod00 deleted the advanced-postprocessing-example branch September 7, 2024 18:56
@mhilbrunner
Copy link
Member

Cherry-picked to 4.3 in #10038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:shaders
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants