Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting started 2D to 4.3 #9834

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

Piralein
Copy link
Member

@Piralein Piralein commented Aug 25, 2024

Images:

  • Update Project Settings images, because of new tab order
  • Update Input Map images, because of new icons and action name reference
  • Update Add Script Dialog image, because of color change
  • Update Group images, because it was split into scene and global groups
    - Update Signal connect image, because it gets added with type hints
  • Added image to visualize the "make unique" step for the music resource

Code:
- Added return type to all functions, because they are added by default

Groups:

  • Explained new workflow

closes #9802
closes #9803

@Piralein Piralein added enhancement area:getting started Issues and PRs related to the Getting Started section of the documentation cherrypick:4.3 labels Aug 25, 2024
@skyace65
Copy link
Contributor

skyace65 commented Sep 5, 2024

@Piralein given the discussions in RocketChat could you please remove the return types from this PR so the other fixes can get merged?

Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

player_signal_connection.webp needs to be updated. it still has the -> void in it. Other than that this PR looks good!

@skyace65 skyace65 merged commit 72afe8c into godotengine:master Sep 7, 2024
1 check passed
@skyace65
Copy link
Contributor

skyace65 commented Sep 7, 2024

Thanks!

@Piralein Piralein deleted the update_images branch September 7, 2024 18:09
@mhilbrunner
Copy link
Member

Cherry-picked to 4.3 in #10038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:getting started Issues and PRs related to the Getting Started section of the documentation enhancement
Projects
None yet
3 participants