-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tileset custom metadata correction #9863
Tileset custom metadata correction #9863
Conversation
This was a bug fixed in godotengine/godot#92322 |
The commits needs to be squashed together. Also, I assume you removed the image because it's not used? Besides that, the change looks good to me. Thanks for contributing! |
I will work on squashing it now. As for the image, I did not remove it but rather I replaced it with an alternate image under the same name properly showing the depiction of custom metadata in the inspector. |
…-the-tileset-s-siles, to accurately reflect how the custom metadata property names do appear in the editor. The image using_tilesets_edit_custom_data.webp was also updated to reflect this change. This was oberved on v4.3.stable.official [77dcf97d8]
1da3500
to
22db647
Compare
The squash should be complete, please let me know if I missed anything else. Thank you all for the help and patience with this ticket! |
Thanks! And congrats on your first merged PR! In the future you don't need to do lossy compression on webp images, lossless is fine. It's a bit noticeable on this one but not terrible so I've merged it. |
Cherry-picked to 4.3 in #10038. |
In summary, the tileset tutorial page indicates that custom metadata for the tiles does not show up in editor. On my local build of v4.3 this is not the case.
More infomation can be foind in ticket:
Improper Documentation for Custom Metadata on Tilesets #9857
Please let me know (through the ticket likely) if more information is needed or I am mistaken. Thank you!