Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tileset custom metadata correction #9863

Conversation

EastToastLiving
Copy link
Contributor

In summary, the tileset tutorial page indicates that custom metadata for the tiles does not show up in editor. On my local build of v4.3 this is not the case.

More infomation can be foind in ticket:
Improper Documentation for Custom Metadata on Tilesets #9857

Please let me know (through the ticket likely) if more information is needed or I am mistaken. Thank you!

@AThousandShips AThousandShips added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:2d labels Aug 30, 2024
@AThousandShips AThousandShips requested a review from a team August 30, 2024 14:23
@KoBeWi
Copy link
Member

KoBeWi commented Aug 30, 2024

This was a bug fixed in godotengine/godot#92322

@groud
Copy link
Member

groud commented Sep 4, 2024

The commits needs to be squashed together. Also, I assume you removed the image because it's not used?

Besides that, the change looks good to me. Thanks for contributing!

@EastToastLiving
Copy link
Contributor Author

The commits needs to be squashed together. Also, I assume you removed the image because it's not used?

Besides that, the change looks good to me. Thanks for contributing!

I will work on squashing it now.

As for the image, I did not remove it but rather I replaced it with an alternate image under the same name properly showing the depiction of custom metadata in the inspector.

…-the-tileset-s-siles, to accurately reflect how the custom metadata property names do appear in the editor. The image using_tilesets_edit_custom_data.webp was also updated to reflect this change. This was oberved on v4.3.stable.official [77dcf97d8]
@EastToastLiving EastToastLiving force-pushed the tileset-custom-metadata-correction branch from 1da3500 to 22db647 Compare September 5, 2024 00:58
@EastToastLiving
Copy link
Contributor Author

The squash should be complete, please let me know if I missed anything else.

Thank you all for the help and patience with this ticket!

@skyace65 skyace65 merged commit 493f0ea into godotengine:master Sep 7, 2024
1 check passed
@skyace65
Copy link
Contributor

skyace65 commented Sep 7, 2024

Thanks! And congrats on your first merged PR! In the future you don't need to do lossy compression on webp images, lossless is fine. It's a bit noticeable on this one but not terrible so I've merged it.

@mhilbrunner
Copy link
Member

Cherry-picked to 4.3 in #10038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug topic:2d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants