Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper Documentation for Custom Metadata on Tilesets #9857

Closed
EastToastLiving opened this issue Aug 29, 2024 · 5 comments
Closed

Improper Documentation for Custom Metadata on Tilesets #9857

EastToastLiving opened this issue Aug 29, 2024 · 5 comments
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug

Comments

@EastToastLiving
Copy link
Contributor

v4.3.stable.official [77dcf97d8]

Improper Documentation for Custom Metadata on Tilesets

(https://docs.godotengine.org/en/stable/tutorials/2d/using_tilesets.html#assigning-custom-metadata-to-the-tileset-s-tiles)

The Tileset Tutorial page for Assigning custom metadata to the TIleSet's tiles claims that in the editor the custom property names do not appear, but rather their index is shown. Having tried this out, this appears to be untrue, at least for v4.3.stable.official [77dcf97d8]

I created a pull request for a potential correction under EastToastLiving:tileset-custom-metadata-correction.

In this pull request, I changed the wording of the section and updated the picture of the editor to clearly show the appropriate custom metadata values.

If anything was inappropriately enacted or any information is still needed, please let me know, Thank you.

@tetrapod00
Copy link
Contributor

Your pull request doesn't actually show up in https://github.com/godotengine/godot-docs/pulls. It looks like you missed the final step of actually creating a PR from your branch.

@EastToastLiving
Copy link
Contributor Author

Below is a picture of my Godot build when working with the Tileset Custom Metadata feature:
using_tilesets_edit_custom_data

This is compared to what is currently shown on the Godot turotial page:
image

If anyone else could confirm this on their build of v4.3 that would be a great sanity check.

@EastToastLiving
Copy link
Contributor Author

EastToastLiving commented Aug 29, 2024

Your pull request doesn't actually show up in https://github.com/godotengine/godot-docs/pulls. It looks like you missed the final step of actually creating a PR from your branch.

I will look into this now, thank you for the heads up! Whoops!

@EastToastLiving
Copy link
Contributor Author

Your pull request doesn't actually show up in https://github.com/godotengine/godot-docs/pulls. It looks like you missed the final step of actually creating a PR from your branch.

I have now successfully actually completed the pulll request. Thank you for double checking that!

@skyace65 skyace65 added the area:manual Issues and PRs related to the Manual/Tutorials section of the documentation label Sep 8, 2024
@skyace65
Copy link
Contributor

skyace65 commented Sep 8, 2024

Closing this as #9863 was merged.

@skyace65 skyace65 closed this as completed Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug
Projects
None yet
Development

No branches or pull requests

3 participants