Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wording of OpenGL support on desktop platforms. #9945

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

danila-zol
Copy link
Contributor

No description provided.

@danila-zol danila-zol mentioned this pull request Sep 12, 2024
@@ -228,8 +228,8 @@ support Vulkan. OpenGL 3.3 Core Profile is used on desktop platforms to run this
driver, as most graphics drivers on desktop don't support OpenGL ES.
WebGL 2.0 is used for web exports.

It is possible to use the use of OpenGL ES 3.0 directly on desktop platforms
using the ``--rendering-driver opengl3_es`` command line argument, although this
It is possible to use OpenGL ES 3.0 directly on desktop platforms
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's only supposed on Linux, not on all desktop platforms. Windows and macOS can use GLES over Angle, but not directly.

Copy link
Member

@Calinou Calinou Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, open source (Mesa) Linux drivers have support for it but Windows/macOS drivers don't. There is no visual difference either way between OpenGL ES and desktop OpenGL on Linux drivers.

@AThousandShips AThousandShips added the area:contributing Issues and PRs related to the Contributing/Development section of the documentation label Sep 18, 2024
@fire fire changed the title Improve wording Improve wording of OpenGL ES support on desktop platforms. Sep 22, 2024
@fire fire changed the title Improve wording of OpenGL ES support on desktop platforms. Improve wording of OpenGL support on desktop platforms. Sep 22, 2024
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Congratulations for your first merged pull request 🎉

@Calinou Calinou added bug and removed enhancement labels Nov 26, 2024
@Calinou Calinou merged commit 4fc9e5e into godotengine:master Nov 26, 2024
@danila-zol danila-zol deleted the patch-1 branch November 27, 2024 07:21
@mhilbrunner
Copy link
Member

Cherrypicked to 4.3 in #10347.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants