-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Remove rate aggregation #112342
Closed
cauemarcondes
wants to merge
10,000
commits into
elastic:master
from
cauemarcondes:apm-throughput-fix
Closed
[APM] Remove rate aggregation #112342
cauemarcondes
wants to merge
10,000
commits into
elastic:master
from
cauemarcondes:apm-throughput-fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atures to index names (elastic#109567) (elastic#110067) **Ticket:** elastic#102089 🚨 **This PR is critical for Observability 7.15** 🚨 ## Summary This PR introduces changes that fix the usage of alerts-as-data index naming in RBAC. It builds on top of elastic#109346 and replaces elastic#108872. TODO: - [x] Address elastic#109346 (review) - [x] Make changes to `AlertsClient.getAuthorizedAlertsIndices()` so it starts using `RuleDataService` to get index names by feature ids. - [x] Delete the hardcoded `mapConsumerToIndexName` where we had incorrect index names. - [x] Close elastic#108872 ### Checklist Delete any items that are not applicable to this PR. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Georgii Gorbachev <[email protected]>
…) (elastic#110070) Co-authored-by: Brian Seeders <[email protected]>
…new item (elastic#109345) (elastic#109662) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Nathan Reese <[email protected]>
…lastic#109776) (elastic#110074) * move activity log paging method close to call api method refs 417d093 * add middleware additional activity log tests * add a more specific server side test for activity log actions and responses refs elastic/pull/101032 * remove obsolete server side audit log index mock method refs elastic/pull/101032 Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Ashokaditya <[email protected]>
…ic#110052) (elastic#110085) * [ML] add mappings for the new rule type * [ML] add telemetry for enabled health checks * [ML] update xpack_plugins.json Co-authored-by: Dima Arnautov <[email protected]>
) Co-authored-by: Casper Hübertz <[email protected]>
…lastic#110066) (elastic#110100) * fix: use package policy ID when checking hasUpgrade * fix: latest package version broken link * refactor: use set for collecting unique namespace values Co-authored-by: Mark Hopkin <[email protected]>
… Host option is missing from alert details take actions menu (elastic#109991) (elastic#110105) Co-authored-by: Candace Park <[email protected]>
… transpiler (elastic#109745) (elastic#110103) * chore(NA): moving @kbn/securitysolution-io-ts-alerting-types to babel transpiler * chore(NA): correct deps on runtime Co-authored-by: Tiago Costa <[email protected]>
…n jobs health rule type (elastic#110069) (elastic#110110) Co-authored-by: Dima Arnautov <[email protected]>
Co-authored-by: Marius Dragomir <[email protected]>
…c#109276) (elastic#110125) **Ticket:** elastic#109293 🚨 **This PR is critical for Observability 7.15** 🚨 ## Summary This PR fixes the indexing implementation in `rule_registry`. It implements the suggestions for backwards compatibility described in the ticket: - changes the naming scheme and introduces the concept of "backing indices", so that names of the concrete ("backing") indices != names of their aliases - adds versioning based on the current Kibana version TODO: - [x] Change index naming (implement the concept of backing indices) - [x] Include Kibana version into the index template metadata - [x] Include Kibana version into the document fields - [x] Remove `version` from `IndexOptions` (parameters provided by solutions/plugins when initializing alerts-as-data indices) - [x] Fix CI ### Checklist - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Georgii Gorbachev <[email protected]>
…t menu (elastic#109914) (elastic#110128) Co-authored-by: Steph Milovic <[email protected]>
…09887) (elastic#110149) * Fix upgrades for packages with restructured inputs Addresses errors surfaced when testing upgrades from AWS 0.6.1 to 0.10.4. Namely, when inputs are removed from a package between versions,we were initially throwing errors for each input in the new package that didn't exist on the outdated package version. Now, we instead simply skip over cases like this in which an input no longer exists on the new package version. * Add basic test cases for restructured packages Co-authored-by: Kyle Pollich <[email protected]>
Co-authored-by: Patryk Kopyciński <[email protected]>
…dices (elastic#109976) (elastic#110163) * use include frozen setting in csv export * add api integration test * add fixes * Update x-pack/test/reporting_api_integration/reporting_and_security/search_frozen_indices.ts * test polish * update per feedback
…#110174) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
…110189) fixes elastic/issues/108864 Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Ashokaditya <[email protected]>
…) (elastic#110193) Co-authored-by: Anton Dosov <[email protected]>
elastic#110094) (elastic#110200) Co-authored-by: Anton Dosov <[email protected]>
…lation protection (elastic#110179) (elastic#110208) Co-authored-by: Esteban Beltran <[email protected]>
…astic#110216) # Conflicts: # src/plugins/discover/public/application/apps/main/components/sidebar/discover_sidebar_responsive.test.tsx
…tegration test (elastic#109715) (elastic#110108) * [RAC] [APM] removes hardcoded alerts as data index from apm integration test (elastic#109715) * removes hardcoded index from apm integration tests * adds integration tests for rule registry's get index route * more cleanup * fail try-catch if response is not empty, adds comments as to why index refresh catch block is empty * fix name of index Co-authored-by: Devin W. Hurley <[email protected]>
…lastic#110229) Co-authored-by: Michael Olorunnisola <[email protected]>
…lastic#110231) Co-authored-by: mgiota <[email protected]> Co-authored-by: Felix Stürmer <[email protected]> Co-authored-by: mgiota <[email protected]>
…110188) (elastic#110240) * [APM] Decrease link size on Traces list * [APM] Change impact column size to fixed Co-authored-by: Casper Hübertz <[email protected]>
…1732) (elastic#111968) * use existing filterManager * remove unused default value * unit test * fix type Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Angela Chuang <[email protected]>
…ll screen (elastic#111038) (elastic#111980) * account for banners when data grid is full screen * account for banner when canvas is full screen * change height per feedback * add withKibana * rm withKibana; move vars out of Fullscreen * Use hasHeaderBanner$ * add banner height var comments * fix ts error Co-authored-by: Catherine Liu <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Michael Marcialis <[email protected]> Co-authored-by: Catherine Liu <[email protected]>
…c#111998) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Corey Robertson <[email protected]>
…te (elastic#111856) (elastic#112004) * do not call addErrorHash if it is timeline template * unit test * fix types * trim kqlQueryExpression * revert change Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Angela Chuang <[email protected]>
…elastic#111323) (elastic#112015) * [Discover] Fix a functional test * Fix failing type * Select index pattern first * Select index pattern first Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
…#111967) (elastic#112013) Co-authored-by: spalger <[email protected]> Co-authored-by: Spencer <[email protected]> Co-authored-by: spalger <[email protected]>
…line (elastic#111908) (elastic#112023) * bring back drag drop in active timeline detail view * only allow drag and drop in query tab * fix snapshot * fix bug on alert summary to remove dragdrop Co-authored-by: Xavier Mouligneau <[email protected]>
…elastic#111042) (elastic#112038) Co-authored-by: Xavier Mouligneau <[email protected]> Co-authored-by: Davis Plumlee <[email protected]> Co-authored-by: Xavier Mouligneau <[email protected]>
…UUID (elastic#108922) (elastic#112049) * Remove ALERT_RULE_ID in favor of ALERT_RULE_UUID * Update snapshot * KEVINNN * fix test * Add back home.disableWelcomeScreen=true * Only disable welcome screen in security solution cypress tests Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/timelines/public/hooks/use_add_to_case.ts
…ime field (elastic#111455) (elastic#112050) * [Security Solution] Add host.os.name.caseless mapping and runtime field (elastic#111455) * Add host.os.name.caseless field and runtime field * Tests * Only add backwards compatibility mappings to old indices by version * Always update aliases_version field even if there are no compat mappings * Add test for newest index version * More comments Co-authored-by: Kibana Machine <[email protected]> * Skip failing test Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Larry Gregory <[email protected]>
…ilter (elastic#110459) (elastic#112089) * version 1 of fix: we set the time range on the search source at CSV generation time * updated jest tests and updated API for getSharingData * make time range optional for getSharingData * pivot to updating "getTime" functionality by introducing a new flag * update jest snapshots * update comment * refactored coerceToAbsoluteTime -> coerceRelativeTimeToAbsoluteTime and updated behaviour to be more specific * fix jest test * do not change createFilter API, rather create new createRelativeFilter API, also only use this in one place in discover * update jest tests * update mock * update jest test mock Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # src/plugins/data/common/query/timefilter/get_time.test.ts
…#112067) (elastic#112092) Co-authored-by: Christos Nasikas <[email protected]>
…lastic#111568) (elastic#112116) Co-authored-by: Pablo Machado <[email protected]>
* [Fleet] Cosmetic fixes Made Add integration button filled * [Fleet] Cosmetic fixes Filled button fixes * [Fleet] Cosmetic fixes 3. Assign policy button * [Fleet] Cosmetic fixes 4. Duplicate policy * [Fleet] Cosmetic fixes 5. full stop * [Fleet] Cosmetic fixes 6. enrollment token name * [Fleet] Cosmetic fixes 2. auth settings * [Fleet] Cosmetic fixes review fixes * [Fleet] Cosmetic fixes Responsive fix fleet broken icons * [Fleet] Cosmetic fixes 8. data streams table layout auto * [Fleet] Cosmetic fixes responsive 2. fixed icon overlap * [Fleet] Cosmetic fixes reduced empty space in header * [Fleet] Cosmetic fixes fix add integration form * improve css selector * moved css to styled component Co-authored-by: juliaElastic <[email protected]>
…elastic#112132) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: shahzad31 <[email protected]> Co-authored-by: Dominique Clarke <[email protected]> Co-authored-by: shahzad31 <[email protected]>
…lastic#112123) (elastic#112124) (elastic#112152) Co-authored-by: Oliver Gupte <[email protected]>
…c#111925) (elastic#112159) # Conflicts: # test/functional/apps/discover/_runtime_fields_editor.ts
…c#112213) * add version and appId to reports * tests * code review * cr 2 * manual parsing + todo Co-authored-by: Liza Katz <[email protected]>
…l tests (elastic#111942) (elastic#112227) Co-authored-by: Felix Stürmer <[email protected]>
cauemarcondes
added
Team:APM
All issues that need APM UI Team support
release_note:skip
Skip the PR/issue when compiling release notes
v7.15.0
labels
Sep 15, 2021
Pinging @elastic/apm-ui (Team:apm) |
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / APM API Integration tests (basic).x-pack/test/apm_api_integration/tests/observability_overview/observability_overview·ts.APM API tests basic apm_8.0.0 Observability overview when data is loaded returns the service count and transaction coordinatesStandard Out
Stack Trace
Kibana Pipeline / general / APM API Integration tests (basic).x-pack/test/apm_api_integration/tests/observability_overview/observability_overview·ts.APM API tests basic apm_8.0.0 Observability overview when data is loaded returns the service count and transaction coordinatesStandard Out
Stack Trace
Metrics [docs]
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:APM
All issues that need APM UI Team support
v7.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #112240
Remove rate aggs and calculate throughput manually.