[SECURITY SOLUTION] Bring back Drag drop in query tabs of active timeline #111908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
enhancement
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
desk tested locally. drag and drop works as before for the event detail panel when on the query tab, and is disabled on all the others. tried to break it by switching to different tabs while the detail panel was open but drag and drop was enabled and disabled as appropriate. failing snapshot seems like it will pass once it's updated, lgtm |
kqualters-elastic
approved these changes
Sep 13, 2021
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 13, 2021
…line (elastic#111908) * bring back drag drop in active timeline detail view * only allow drag and drop in query tab * fix snapshot * fix bug on alert summary to remove dragdrop
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 13, 2021
…line (elastic#111908) * bring back drag drop in active timeline detail view * only allow drag and drop in query tab * fix snapshot * fix bug on alert summary to remove dragdrop
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
kibanamachine
added a commit
that referenced
this pull request
Sep 13, 2021
…line (#111908) (#112023) * bring back drag drop in active timeline detail view * only allow drag and drop in query tab * fix snapshot * fix bug on alert summary to remove dragdrop Co-authored-by: Xavier Mouligneau <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 14, 2021
…line (#111908) (#112024) * bring back drag drop in active timeline detail view * only allow drag and drop in query tab * fix snapshot * fix bug on alert summary to remove dragdrop Co-authored-by: Xavier Mouligneau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We realized during testing that we were not able to drag and drop value from the host/network/event details inside of the active timeline. As a team we decided that user should still have this functionality in the query tab of the active timeline.
Checklist