Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Fix hidden lens modal when creating case from flyout #112067

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Sep 14, 2021

Summary

If you attach an alert to a new case the cases flyout opens. Then if you try to add a lens to the case the modal is hidden behind the flyout make it impossible for the user to interact with it. This PR fixes this issue and ensures that the cases flyout is in front of the timeline but behind the lens modal.

Video with the fix:

bug.mp4

Ref: #112057

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.15.0 v7.16.0 Team:Threat Hunting:Cases labels Sep 14, 2021
@cnasikas cnasikas self-assigned this Sep 14, 2021
@cnasikas cnasikas requested a review from a team as a code owner September 14, 2021 10:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@cnasikas cnasikas enabled auto-merge (squash) September 14, 2021 10:54
@cnasikas cnasikas added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 14, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
timelines 419.5KB 419.5KB +4.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.15
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 14, 2021
kibanamachine added a commit that referenced this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants