[Uptime][Synthetics Integration] add browser callout #108935

dominiqueclarke · 2021-08-17T15:29:21Z

Summary

Adds an EuiCallout when the browser option is selected.

The current content is under review. The content was pulled directly from the issue, but will be update upon product and design review.

elasticmachine · 2021-08-17T15:29:23Z

Pinging @elastic/uptime (Team:uptime)

dominiqueclarke · 2021-08-17T15:30:03Z

x-pack/plugins/uptime/public/components/fleet_package/custom_fields.tsx

+                      }
+                      values={{
+                        link: (
+                          <EuiLink target="_blank" href="" external>


This link still needs to be provided.

For now I'd say https://www.elastic.co/guide/en/observability/current/synthetic-monitoring.html is fine. I've opened elastic/observability-docs#989 to track adding more docs

dominiqueclarke · 2021-08-19T15:25:56Z

@elasticmachine merge upstream

…browser-callout

dominiqueclarke · 2021-08-23T14:12:02Z

@elasticmachine merge upstream

…browser-callout

drewpost · 2021-08-24T13:05:40Z

To create a "Browser" monitor, please ensure you are using the "complete" elastic-agent Docker container as this contains the dependencies to run these monitors which can be downloaded from HERE. For more information, please visit our synthetics documentation.

"here" links directly to the complete agent download instructions
"synthetic documentation" links to our docs

cc @dominiqueclarke

justinkambic

Had a question about copy, otherwise looking good.

justinkambic · 2021-08-24T13:48:23Z

x-pack/plugins/uptime/public/components/fleet_package/custom_fields.tsx

+                  title={
+                    <FormattedMessage
+                      id="xpack.uptime.createPackagePolicy.stepConfigure.monitorIntegrationSettingsSection.monitorType.browser.warning.description"
+                      defaultMessage='Browser monitoring requires using the "complete" variant of the elastic–agent docker container. Other distributions of elastic that agent will not work correctly with it because they lack the required browser and other binaries. For more information see our {link}'


Suggested change

defaultMessage='Browser monitoring requires using the "complete" variant of the elastic–agent docker container. Other distributions of elastic that agent will not work correctly with it because they lack the required browser and other binaries. For more information see our {link}'

defaultMessage='Browser monitoring requires using the "complete" variant of the elastic–agent docker container. Other distributions of elastic that agent will not work correctly with it because they lack the required browser and other binaries. For more information see our {link}.'

Also, this sentence:

Other distributions of elastic that agent will not work correctly with it because they lack the required browser and other binaries.

This reads weirdly to me. Are we saying that "distributions of elastic" might not work correctly?

This copy was a placeholder. Drew just provided the final version.

Whoops, sorry, I saw that he commented and was confused why they didn't match. Should've put 2 + 2 together!

justinkambic · 2021-09-01T18:19:45Z

@elasticmachine merge upstream

…browser-callout

shahzad31 · 2021-09-06T09:55:33Z

x-pack/plugins/uptime/public/components/fleet_package/custom_fields.tsx

@@ -122,6 +124,34 @@ export const CustomFields = memo<Props>(
                  />
                </EuiFormRow>
              )}
+              <EuiSpacer size="s" />
+              {isBrowser && (


does it make sense to show this everytime user is adding a browser moniotor, is there a way to detect if they already have a working browser monitor, in that case i think user is probaly already educated and doesn;t need this additional context.

That makes sense. There isn't a way to do this easily. We'd have to make a call to a fleet api to collect the users policies and check from there. Alternatively, we could do a query against the datastream to see if it has any documents with monitor.type of browser.

It may be worth it to keep the call out though, since the user still need to make sure they are assigning the integration policy to the correct agent policy and they make have to change the selection at the bottom. Could be a good reminder.

dominiqueclarke · 2021-09-10T11:58:11Z

@elasticmachine merge upstream

…browser-callout

shahzad31 · 2021-09-14T12:59:21Z

@elasticmachine merge upstream

…browser-callout

shahzad31

LGTM !!

justinkambic

I'm not going to hold this one up but I think we might want to highlight the container's name as code or something in the future. It can be a little hard to track the flow of the sentence without denoting that it's a container name.

LGTM

kibanamachine · 2021-09-14T15:34:42Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`uptime`	1.0MB	1.0MB	+1.3KB

History

💔 Build #152506 failed 9a77598
💛 Build #150350 was flaky 17122a6
💚 Build #147763 succeeded 83ff712
💚 Build #146973 succeeded 0032b2d
💚 Build #146925 succeeded 9a3c374

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-09-14T15:42:35Z

The following labels were identified as gaps in your version labels and will be added automatically:

v7.16.0

If any of these should not be on your pull request, please manually remove them.

Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: shahzad31 <[email protected]>

kibanamachine · 2021-09-14T15:45:24Z

💚 Backport successful

Status	Branch	Result
✅	7.15
✅	7.x

The backport PRs will be merged automatically after passing CI.

Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: shahzad31 <[email protected]> Co-authored-by: Dominique Clarke <[email protected]> Co-authored-by: shahzad31 <[email protected]>

add browser callout

f8d8450

dominiqueclarke requested a review from a team as a code owner August 17, 2021 15:29

dominiqueclarke commented Aug 17, 2021

View reviewed changes

dominiqueclarke requested a review from liciavale August 17, 2021 15:30

add browser callout link

cec98a5

dominiqueclarke added bug Fixes for quality problems that affect the customer experience and removed enhancement New value added to drive a business result labels Aug 18, 2021

mistic added v7.16.0 and removed v7.15.0 labels Aug 18, 2021

adjust content

9a3c374

Merge branch 'master' into feature/108710-synthetics-integration-add-…

0032b2d

…browser-callout

dominiqueclarke added v7.15.0 and removed v7.16.0 labels Aug 19, 2021

Merge branch 'master' into feature/108710-synthetics-integration-add-…

83ff712

…browser-callout

justinkambic reviewed Aug 24, 2021

View reviewed changes

Merge branch 'master' into feature/108710-synthetics-integration-add-…

17122a6

…browser-callout

shahzad31 reviewed Sep 6, 2021

View reviewed changes

update link

8409b9b

Merge branch 'master' into feature/108710-synthetics-integration-add-…

9a77598

…browser-callout

kibanamachine and others added 2 commits September 14, 2021 08:59

Merge branch 'master' into feature/108710-synthetics-integration-add-…

6c72163

…browser-callout

update test

adcbe01

shahzad31 approved these changes Sep 14, 2021

View reviewed changes

justinkambic approved these changes Sep 14, 2021

View reviewed changes

shahzad31 merged commit 4b33115 into elastic:master Sep 14, 2021

shahzad31 deleted the feature/108710-synthetics-integration-add-browser-callout branch September 14, 2021 15:42

kibanamachine added the v7.16.0 label Sep 14, 2021

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 14, 2021

[Uptime][Synthetics Integration] add browser callout (elastic#108935)

772371f

Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: shahzad31 <[email protected]>

kibanamachine mentioned this pull request Sep 14, 2021

[7.15] [Uptime][Synthetics Integration] add browser callout (#108935) #112132

Merged

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 14, 2021

[Uptime][Synthetics Integration] add browser callout (elastic#108935)

5df43d9

Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: shahzad31 <[email protected]>

kibanamachine mentioned this pull request Sep 14, 2021

[7.x] [Uptime][Synthetics Integration] add browser callout (#108935) #112133

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Uptime][Synthetics Integration] add browser callout #108935

[Uptime][Synthetics Integration] add browser callout #108935

dominiqueclarke commented Aug 17, 2021

elasticmachine commented Aug 17, 2021

dominiqueclarke Aug 17, 2021

andrewvc Aug 17, 2021

dominiqueclarke commented Aug 19, 2021

dominiqueclarke commented Aug 23, 2021

drewpost commented Aug 24, 2021

justinkambic left a comment

justinkambic Aug 24, 2021

dominiqueclarke Aug 24, 2021

justinkambic Aug 24, 2021

justinkambic commented Sep 1, 2021

shahzad31 Sep 6, 2021

dominiqueclarke Sep 9, 2021

dominiqueclarke commented Sep 10, 2021

shahzad31 commented Sep 14, 2021

shahzad31 left a comment

justinkambic left a comment

kibanamachine commented Sep 14, 2021

kibanamachine commented Sep 14, 2021

kibanamachine commented Sep 14, 2021

	defaultMessage='Browser monitoring requires using the "complete" variant of the elastic–agent docker container. Other distributions of elastic that agent will not work correctly with it because they lack the required browser and other binaries. For more information see our {link}'
	defaultMessage='Browser monitoring requires using the "complete" variant of the elastic–agent docker container. Other distributions of elastic that agent will not work correctly with it because they lack the required browser and other binaries. For more information see our {link}.'

[Uptime][Synthetics Integration] add browser callout #108935

[Uptime][Synthetics Integration] add browser callout #108935

Conversation

dominiqueclarke commented Aug 17, 2021

Summary

elasticmachine commented Aug 17, 2021

dominiqueclarke Aug 17, 2021

Choose a reason for hiding this comment

andrewvc Aug 17, 2021

Choose a reason for hiding this comment

dominiqueclarke commented Aug 19, 2021

dominiqueclarke commented Aug 23, 2021

drewpost commented Aug 24, 2021

justinkambic left a comment

Choose a reason for hiding this comment

justinkambic Aug 24, 2021

Choose a reason for hiding this comment

dominiqueclarke Aug 24, 2021

Choose a reason for hiding this comment

justinkambic Aug 24, 2021

Choose a reason for hiding this comment

justinkambic commented Sep 1, 2021

shahzad31 Sep 6, 2021

Choose a reason for hiding this comment

dominiqueclarke Sep 9, 2021

Choose a reason for hiding this comment

dominiqueclarke commented Sep 10, 2021

shahzad31 commented Sep 14, 2021

shahzad31 left a comment

Choose a reason for hiding this comment

justinkambic left a comment

Choose a reason for hiding this comment

kibanamachine commented Sep 14, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

kibanamachine commented Sep 14, 2021

kibanamachine commented Sep 14, 2021

💚 Backport successful