Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Fixes issue with removing first workpad page #110495

Merged
merged 3 commits into from
Sep 13, 2021
Merged

[Canvas] Fixes issue with removing first workpad page #110495

merged 3 commits into from
Sep 13, 2021

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Aug 30, 2021 •
edited
Loading

Summary

If the first page was removed, then it was trying to go to page 0, which caused problem

Closes #110487

@crob611 crob611 requested a review from a team as a code owner August 30, 2021 15:21
@crob611 crob611 added bug Fixes for quality problems that affect the customer experience v7.14.2 v7.15.0 v7.16.0 v8.0.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review labels Aug 30, 2021
@crob611
Copy link
Contributor Author

crob611 commented Sep 9, 2021

@elasticmachine merge upstream

@crob611 crob611 added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 13, 2021
@crob611
Copy link
Contributor Author

crob611 commented Sep 13, 2021

@elasticmachine merge upstream

poffdeluxe
poffdeluxe approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as advertised

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.6MB 1.6MB +14.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crob611 crob611 merged commit edc147b into elastic:master Sep 13, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 13, 2021
@kibanamachine
Fixes issue with removing first workpad page (elastic#110495)
beeefde 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Sep 13, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 13, 2021
@kibanamachine
Fixes issue with removing first workpad page (elastic#110495)
b56d94f 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Sep 13, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 13, 2021
@kibanamachine
Fixes issue with removing first workpad page (elastic#110495)
60fa472 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Sep 13, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x
✅ 7.14

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 13, 2021
@kibanamachine
Fixes issue with removing first workpad page (#110495) (#112000)
1eca310 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Corey Robertson <[email protected]>
kibanamachine added a commit that referenced this pull request Sep 13, 2021
@kibanamachine
Fixes issue with removing first workpad page (#110495) (#111998)
a738b26 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Corey Robertson <[email protected]>
kibanamachine added a commit that referenced this pull request Sep 13, 2021
@kibanamachine
Fixes issue with removing first workpad page (#110495) (#111999)
e77e072 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Corey Robertson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poffdeluxe poffdeluxe poffdeluxe approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review v7.14.2 v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Canvas] Deleting first page breaks workpad
3 participants
@crob611 @kibanamachine @poffdeluxe